This project is archived and is in readonly mode.
some strings do not serialize/unserialize correctly
I have a serialized field that can contain markdown wiki content. In some cases, saving perfectly ordinary Markdown content will return a YAML::DomainType object, rather than the original string.
For example this markdown document starts with an image and then has a horizontal rule:
-----
However, storing this string in a serialized field causes ActiveRecord to return a YAML::DomainType object, rather than the original string. This happens because the test in object_from_yaml that checks whether a String is just a String, or if it is a serialized object, isn't strict enough. This markdown string has a line that starts with --- (which is enough to get ActiveRecord to call YAML::load on the string), and the ! at the beginning looks to the yaml parser like a domaintype specification.
My proposed fix is to change the test for serialized YAML content from /^---/ to /\A---/.
-
object_from_yaml.diff
1.15 KB
-
rails- State changed from new to open
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
rails
- State changed from open to stale