#6328 Give more information about validation methods that need to be overridden - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#6328 ✓resolved

Give more information about validation methods that need to be overridden

Reported by Mike Gehard | January 24th, 2011 @ 12:47 AM

ActiveModel::Validator and ActiveModel::EachValidator require subclasses to implement different methods. Currently these methods simply throw a NotImplementedError without any description of what needs to be implemented.

This patch adds some extra text to the exceptions to give the developer a better idea of what needs to be implemented in the subclasses.

Comments and changes to this ticket

You flagged this item as spam.
Roger Leite January 28th, 2011 @ 05:22 PM
Missing patch file.
You flagged this item as spam.
Mike Gehard January 28th, 2011 @ 07:45 PM
Seems that Lighthouse won't allow me to attach a file...
You flagged this item as spam.
Mike Gehard January 28th, 2011 @ 07:47 PM
Seems to be a problem with Chrome...I uploaded this patch from Firefox.
- enhance_abstract_method_exceptions.diff 1.4 KB
Rohit Arondekar January 29th, 2011 @ 01:09 PM
- State changed from “new” to “open”
- Assigned user set to “José Valim”
- Importance changed from “” to “Low”
This is definitely a good idea!

Patch applies cleanly to both master and 3-0-stable and the tests pass.
You flagged this item as spam.
Mike Gehard February 9th, 2011 @ 01:35 PM
I found a couple more instances of where additional text would be helpful. I have recreated the patch to include the new additions. The enhance_abstract_method_exceptions.diff file is obsolete, please use the enhance_abstract_method_exceptions_take_2.diff.
- enhance_abstract_method_exceptions_take_2.diff 2.7 KB
Repository March 12th, 2011 @ 03:44 PM
- State changed from “open” to “resolved”
(from [58de03f077b0da1cb923f28835b00cd092de3c08]) Add additional text to NotImplementedErrors [#6328 state:resolved]

Signed-off-by: Santiago Pastorino santiago@wyeworks.com
https://github.com/rails/rails/commit/58de03f077b0da1cb923f28835b00...