This project is archived and is in readonly mode.

#6352 open
yinhm

collection_singular_ids inconsistent with collections when source and conditions present

Reported by yinhm | February 1st, 2011 @ 08:32 AM

Imaging your have a User model, which define a has_many association like:

  
  has_many(:subscribed_groups,
           :through => :subscriptions,
           :conditions => "streams.category ='group'",
           :source => :stream)

user.subscribed_groups and user.subscribed_group_ids will generating different SQL and returns different records.

Adding a extra criterion fixed this:

activerecord-3.0.3/lib/active_record/associations.rb diffs:

1504c1504,1505
<               if reflection.through_reflection && reflection.source_reflection.belongs_to? 
---
>               if reflection.through_reflection && reflection.source_reflection.belongs_to? && 
>                   reflection.options[:conditions]

Comments and changes to this ticket

  • rails

    rails May 2nd, 2011 @ 01:00 AM

    • State changed from “new” to “open”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • rails

    rails May 2nd, 2011 @ 01:00 AM

    • State changed from “open” to “stale”
  • Anatoliy Lysenko

    Anatoliy Lysenko May 7th, 2011 @ 02:29 PM

    • State changed from “stale” to “open”

    [state:open] Is not fixed on master c444b0f67bf5f998

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

Pages