Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

collection_singular_ids inconsistent with collections when source and conditions present

#6352

Imaging your have a User model, which define a has_many association like:

  
  has_many(:subscribed_groups,
           :through => :subscriptions,
           :conditions => "streams.category ='group'",
           :source => :stream)

user.subscribed_groups and user.subscribed_group_ids will generating different SQL and returns different records.

Adding a extra criterion fixed this:

activerecord-3.0.3/lib/active_record/associations.rb diffs:

1504c1504,1505
<               if reflection.through_reflection && reflection.source_reflection.belongs_to? 
---
>               if reflection.through_reflection && reflection.source_reflection.belongs_to? && 
>                   reflection.options[:conditions]

Reported by yinhm · February 1st, 2011 @ 08:32 AM

State: open
Milestone: none
Assigned to: nobody
Importance: none

Activity

  1. rails
    rails
    • State changed from new to open

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    May 2nd, 2011 @ 01:00 AM

  2. rails
    rails
    • State changed from open to stale

    May 2nd, 2011 @ 01:00 AM

  3. Anatoliy Lysenko
    Anatoliy Lysenko
    • State changed from stale to open

    [state:open] Is not fixed on master c444b0f67bf5f998

    May 7th, 2011 @ 02:29 PM