This project is archived and is in readonly mode.
ActiveSupport: nil.id could not be 4
Cosmetic: proper care about nil.id for Ruby impls.
nil.id could not be 4. Just a exception message thing.
% ~/ruby/rubinius-1.2.1/bin/rbx -ve 'p nil.object_id' rubinius
1.2.1 (1.8.7 release 2011-02-15 JI) [x86_64-unknown-linux-gnu]
53
Patch attached for activesupport/lib/active_support/whiny_nil.rb
-
Andrew White- State changed from new to open
- Assigned user set to Andrew White
- Importance changed from to Low
I think you mean 'may not be 4' - 'could not' implies that it's never 4.
Rather than making the message even more ambiguous I think we should just put the result of nil.object_id in there. You'll need a test that stubs nil.object_id to return a different value and asserts the error message is correct before I can apply the patch.
-
Repository- State changed from open to resolved
(from [824107b2edb12ec275673c1f0e656a5e7ed6f4bf]) Report the correct value of nil.id in the exception message as different ruby implementations may have different values,
for example Rubinius returns 53 for nil.id.[#6444 ActiveSupport: nil.id could not be 4 state:resolved] https://github.com/rails/rails/commit/824107b2edb12ec275673c1f0e656...
-
Repository
(from [5e7ce47fb9ab50858fe067a6eb6c0462c5c5681e]) Report the correct value of nil.id in the exception message as different ruby implementations may have different values,
for example Rubinius returns 53 for nil.id.[#6444 ActiveSupport: nil.id could not be 4 state:resolved] https://github.com/rails/rails/commit/5e7ce47fb9ab50858fe067a6eb6c0...