Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Revert deleted tests by past commit

#6526

Hi, in this commit:

https://github.com/rails/rails/commit/080345baca1076a9788dff4803153...

some code was refactored and the tests deleted. I think the refactor was great, but the tests shouldn't have been deleted, as the validations still applies. This tests should be keep so the functionality is guaranteed independent of the implementation.

I attach a patch reverting only the tests part.

Reported by Diego Carrion · March 4th, 2011 @ 07:24 PM

State: committed
Milestone: none
Assigned to: Santiago Pastorino Santiago Pastorino
Importance: Low

Activity

  1. José Valim
    José Valim
    • Assigned user changed from José Valim to Santiago Pastorino
    • Importance changed from to Low

    March 4th, 2011 @ 07:32 PM

  2. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to committed

    Pushed, well done manxa :P

    March 4th, 2011 @ 08:11 PM