Rails Ruby on Rails → 2.x

Comments and changes to this ticket

• You flagged this item as spam.
  

  Michael Bumann August 15th, 2008 @ 01:08 AM

  see also: #772

• You flagged this item as spam.
  

  Tekin August 15th, 2008 @ 09:09 AM

  Great minds!

• You flagged this item as spam.
  

  Tom Ward August 15th, 2008 @ 02:52 PM

  Might it be nicer to automatically provide a helper method/instance variable to indicate whether the first or last records in the collection are being passed?

• 

  Tekin August 15th, 2008 @ 04:38 PM

  • no changes were found...

  • add_collection_size_and_first_last_booleans_to_partials.diff 3.5 KB

• You flagged this item as spam.
  

  Tekin August 15th, 2008 @ 04:38 PM

  I guess so. In fact, Michael's patch does just that!

  I've combined Michael's patch with mine, attached.

• 

  DHH August 16th, 2008 @ 05:29 AM

  • State changed from “new” to “wontfix”

  I'm really not a fan of this auto-setting of locals. I think setting the counter local is already kinda fishy, but at least it's something that would otherwise be kinda hard. Setting the size of the collection is perfectly doable through current means, so I don't think it's worth the magic spell to do it automatically.

  You're of course always free to turn it into a plugin ;)

• You flagged this item as spam.
  

  Tekin August 16th, 2008 @ 11:05 AM

  • Title changed from “PATCH: assign collection_size local variable in partials” to “PATCH: assign collection counter local variable in partials based on the :as option”

  A small part of the patch might still be worth keeping though - the part that creates a counter based on the :as parameter. It doesn't feel right that specifying the :as option doesn't set "#{:as}_counter". I've attached another patch.

  • as_sets_counter_for_partial_collections.diff 1.9 KB