This project is archived and is in readonly mode.
coerce blank strings to nil values for boolean and integer fields
This patch fixes ActiveRecord to consistently coerce blank strings to nil values for boolean and integer fields. Prior to this change, blank strings were coerced to false for booleans, while integer fields coerced empty strings to nil and non-empty blank strings (i.e. containing whitespace) to 0.
Apparently there's a bit of controversy over this functionality. Please see this thread: http://groups.google.com/group/r...
-
blank_strings_are_nil.diff
2.99 KB
-
Tom WardCoercing blank strings to nil for non-string columns makes a whole load of sense to me. A definite +1.
-
Michael Koziarski- State changed from new to committed
-
Jeremy Kemper- State changed from committed to incomplete
- Milestone cleared.
This causes value_to_boolean(false) to return nil.
-
Repository(from [a5eb297424f68583636b762686726bc0c84703c0]) Revert "coerce blank strings to nil values for boolean and integer fields"
This reverts commit aee14630d4dc0856e597794cc731fac68c2d2e34.
[#860 coerce blank strings to nil values for boolean and integer fields state:incomplete] http://github.com/rails/rails/co...
-
Michael Koziarski
Kinda disconcerting this didn't hit any test failures, so we probably need one.
It should check .is_a? String
-
Josh Susser
Updated patch to fix issue. Changed the tests to actually test a :boolean field instead of an :integer one, so there is real coverage now (instead of pretend).
-
blank_strings_are_nil.diff
5.13 KB
-
-
Repository
- State changed from incomplete to resolved
(from [e48e77e0222292176cd9f68658dd54524f582d9b]) coerce blank strings to nil values for boolean and integer fields
[#860 coerce blank strings to nil values for boolean and integer fields state:resolved] http://github.com/rails/rails/co...