This project is archived and is in readonly mode.

onDrop option in ActionView::Helpers::ScriptaculousHelper.drop_receiving_element does not pass correct parameters

#952

line 200 in actionpack-2.1.0/lib/action_view/helpers/scriptaculous_helper.rb should be changed from

@@@ruby options[:onDrop] ||= "function(element){" + remote_function(options) + "}"



to

@@@ruby
options[:onDrop]   ||= "function(draggable,droppable,event){" + remote_function(options) + "}"

so that that the draggable element, the droppable element, and the event object will be available.

Thanks!

Reported by 47primes · September 1st, 2008 @ 10:27 PM

Pratik
- Assigned user set to Pratik
- State changed from new to incomplete
Could you please upload a patch with a test case - http://rails.lighthouseapp.com/p... ?

Thanks.

December 20th, 2008 @ 06:46 PM
Ryan Bigg
- State changed from incomplete to open
I heard you like patches.
- ondrop.patch 6.82 KB
April 11th, 2010 @ 01:08 AM
Jeremy Kemper
- Milestone changed from 2.x to 3.x
[bulk edit]

May 4th, 2010 @ 06:48 PM
Santiago Pastorino
- Importance changed from to
This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

February 2nd, 2011 @ 05:05 PM
Santiago Pastorino
- State changed from open to stale
February 2nd, 2011 @ 05:05 PM