This project is archived and is in readonly mode.
compute_public_path adds an extension to a source w/ a querystring
compute_public_path in ActionView::Helpers::AssetTagHelper adds an extension (.js, .css, etc.) to a source that was supplied with a querystring, so this:
<%= javascript_src_tag "http://fakedomain/foo?some_val=1" %>
looks like
<script type="text/javascript" src="http://fakedomain/foo?some_val=1.js"></script>
Attached is a patch that inserts an existence check for "?" before adding the extension.
-
416e7bc.patch
801 Bytes
-
DHH- State changed from new to incomplete
Looks good, needs test (change ticket status to verified when added).
-
-
netshade
(as a side note, i don't have the ability to change ticket status, if the "change ticket status" was directed to me)
-
DHH
This no longer seems to apply cleanly against master. Could you create a new, single patch against master?
-
CancelProfileIsBroken
- Tag changed from action_view, helper, patch to action_view, bugmash, helper, patch
-
Jatinder Singh
This is not longer valid, as the latest changes in compute_public_path only add extensions to files, and not URIs.
-
Rizwan Rezaverified
+1 This bug is present.
javascript_path("http://fake.domain/super/xmlhr?callback=fake") # should be this # => http://fake.domain/super/xmlhr?callback=fake # right now... # => http://fake.domain/super/xmlhr?callback=fake.js -
Rizwan Reza
not reproducible in master.
-
Rizwan Reza
This patch works for 2-3-stable, backports the functionality from master.
-
-
Jeremy Kemper- Tag changed from action_view, bugmash, helper, patch to action_view, helper, patch
- State changed from incomplete to wontfix
- Milestone cleared.
Resolved that we shouldn't break compat.
-
Rizwan Reza
- Tag changed from action_view, helper, patch to action_view, bugmash, helper, patch
This is no longer being applied, please close the ticket.
-
CancelProfileIsBroken
- Tag changed from action_view, bugmash, helper, patch to action_view, helper, patch