This project is archived and is in readonly mode.
compute_public_path adds an extension to a source w/ a querystring
Reported by netshade | September 5th, 2008 @ 07:06 PM
compute_public_path in ActionView::Helpers::AssetTagHelper adds an extension (.js, .css, etc.) to a source that was supplied with a querystring, so this:
<%= javascript_src_tag "http://fakedomain/foo?some_val=1" %>
looks like
<script type="text/javascript" src="http://fakedomain/foo?some_val=1.js"></script>
Attached is a patch that inserts an existence check for "?" before adding the extension.
Comments and changes to this ticket
-
DHH September 10th, 2008 @ 05:19 AM
- State changed from “new” to “incomplete”
Looks good, needs test (change ticket status to verified when added).
-
-
netshade September 10th, 2008 @ 04:06 PM
(as a side note, i don't have the ability to change ticket status, if the "change ticket status" was directed to me)
-
DHH November 8th, 2008 @ 12:42 PM
This no longer seems to apply cleanly against master. Could you create a new, single patch against master?
-
CancelProfileIsBroken August 3rd, 2009 @ 07:37 PM
- Tag changed from “action_view, helper, patch” to “action_view, bugmash, helper, patch”
-
Jatinder Singh August 9th, 2009 @ 11:29 AM
This is not longer valid, as the latest changes in compute_public_path only add extensions to files, and not URIs.
-
Rizwan Reza August 9th, 2009 @ 08:36 PM
verified
+1 This bug is present.
javascript_path("http://fake.domain/super/xmlhr?callback=fake") # should be this # => http://fake.domain/super/xmlhr?callback=fake # right now... # => http://fake.domain/super/xmlhr?callback=fake.js -
-
Rizwan Reza August 9th, 2009 @ 09:53 PM
This patch works for 2-3-stable, backports the functionality from master.
-
-
Jeremy Kemper August 9th, 2009 @ 11:14 PM
- Tag changed from “action_view, bugmash, helper, patch” to “action_view, helper, patch”
- State changed from “incomplete” to “wontfix”
- Milestone cleared.
Resolved that we shouldn't break compat.
-
Rizwan Reza August 9th, 2009 @ 11:15 PM
- Tag changed from “action_view, helper, patch” to “action_view, bugmash, helper, patch”
This is no longer being applied, please close the ticket.
-
CancelProfileIsBroken August 9th, 2009 @ 11:16 PM
- Tag changed from “action_view, bugmash, helper, patch” to “action_view, helper, patch”
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
CancelProfileIsBroken
DHH
Jeremy Kemper