Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Will Bryant

Will Bryant

Not a member

Will Bryant's latest activity

Tuesday, October 07 2008
1110 Eager loading regression for find with :includes of associations already :inc... was updated in Ruby on Rails
  • Will Bryant
    Will Bryant commented at 10:51 PM

    OK, just merge the first patch then, and leave out the additional-...diff (or at least, leave out the test case in it).
  • Will Bryant
    Will Bryant commented at 1:56 AM

    If Fred's #1060 patch gets merged, please merge this as well as my patch above - it fixes this #1110 bug for HABTM also. (You can actually merge it safely even ...
Monday, October 06 2008
1110 Eager loading regression for find with :includes of associations already :inc... was updated in Ruby on Rails
  • Will Bryant
    Will Bryant commented at 11:13 PM

    Fred, no patch there for HABTMs as they don't work at all with includes defined on the association - the :select passed to find gets ignored due to the options[...
Tuesday, September 30 2008
1110 Eager loading regression for find with :includes of associations already :inc... was updated in Ruby on Rails
  • Will Bryant
    Will Bryant commented at 9:57 AM

    Righto, I'll drop Fred an email.

    I'm not doing it, but my clients are :).

    They wanted the association to always load the child association, hence the :include o...
  • Will Bryant
    Will Bryant commented at 9:01 AM

    Fred as in Frederick Cheung from the mailing list? AFAIK he hasn't had this issue himself.
Saturday, September 27 2008
1101 Eager association loading sanitizes conditions using the wrong table was updated in Ruby on Rails
  • Will Bryant
    Will Bryant commented at 5:04 AM

    Backported to the 2-1-stable repository, since that's diverged from 2.1.1 release far enough for that not to apply.
1110 Eager loading regression for find with :includes of associations already :inc... was updated in Ruby on Rails
  • Will Bryant
    Will Bryant commented at 4:54 AM

    Patch and tests attached for has_many, has_one, and belongs_to. HABTM and has_many :though have unrelated issues so no change needed there.
Thursday, September 25 2008
1110 Eager loading regression for find with :includes of associations already :inc... was created in Ruby on Rails
  • Will Bryant
    Will Bryant created the ticket at 12:50 PM

    If you have a has_many defined with :includes:

    
class Author < ActiveRecord::Base
  has_many :posts_with_comments, :include => :comments, :class_name => "Post...
Wednesday, September 24 2008
1101 Eager association loading sanitizes conditions using the wrong table was updated in Ruby on Rails
  • Will Bryant
    Will Bryant commented at 12:14 PM

    Erm, ignore the ticket number in that second filename :).
  • Will Bryant
    Will Bryant commented at 11:02 AM

    For the convenience of anyone who needs to patch this on their project running the released version of rails, here's a backport against your frozen-in vendor/ra...