Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Miles Egan's latest activity

Tuesday, July 13 2010
3759 Rails 3 AR performance has regressed since Rails 2 was updated in Ruby on Rails
  • Miles Egan
    Miles Egan commented at 5:32 AM

    Tried this on a slightly more formal benchmark, with a test script like this:

    10.times do
      1000.times{ Post.create(:title => "bla", :body => "x" * 1000) }
      m...
5098 Rails 3 Beta 4 ActiveRecord 5X slower than Rails 2.3.5 was updated in Ruby on Rails
  • Miles Egan
    Miles Egan commented at 4:24 AM

    drjoke - I'm not seeing a similar performance difference on my Ubuntu laptop with postgresql. Rails 3 seems about 20% slower here. What hardware and db engine a...

5094 ActiveRelation doesn't quote columns that are SQL keywords was updated in Ruby on Rails
  • Miles Egan
    Miles Egan commented at 3:18 AM

    I think this is actually an Arel thing. If you look at the code for the ordering clause in arel. Specifically, if you look at
    lib/arel/engines/sql/formatters.rb...

Sunday, July 11 2010
5081 undefined method `money_precision=' for #<Class:0x105d7dda8> in postgresql_ad... was updated in Ruby on Rails
  • Miles Egan
    Miles Egan commented at 8:29 PM

    Sorry about the bad formatting there. Still getting used to this forum. I should add that I'm testing on a Ubuntu machine, so that might account for the differe...

  • Miles Egan
    Miles Egan commented at 8:28 PM

    I just tried loading a new Rails 3 app with your gemfile and creating a test class with this definition:

    class CreateTestObjects < ActiveRecord::Migration
    def s...

  • Miles Egan
    Miles Egan commented at 6:53 PM

    It's hard to debug this without a little more information. What command are you running to generate this error? Can you share the portion of the schema that thi...

5084 File Field shouldn't include a size attribute was updated in Ruby on Rails
  • Miles Egan
    Miles Egan commented at 6:45 PM

    It looks to me like this is still an issue in master. I've attached a patch that fixes this and adds a test case.

3030 Rails does not handle TypeError from Rack on malformed query strings was updated in Ruby on Rails
  • Miles Egan
    Miles Egan commented at 3:01 AM

    Here's an alternative solution, if you think it's reasonable to assert that request_parameters and query_parameters should never be nil.

Saturday, July 10 2010
3030 Rails does not handle TypeError from Rack on malformed query strings was updated in Ruby on Rails
  • Miles Egan
    Miles Egan commented at 10:32 PM

    Ok I've followed the instructions on that page and added a test case that triggers the error and verifies that it's handled correctly. Please let me know if thi...

  • Miles Egan
    Miles Egan commented at 8:49 PM

    This patch doesn't discard the error, it just allows rails to display the error to the client instead of issuing a 500.

    The code accessing query_parameters is u...