Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Jon Leighton

Jon Leighton

Programmer · Member of 1 project: Ruby on Rails

Jon Leighton's latest activity

Sunday, October 31 2010
5845 ActiveRecord 3 eager loading fail was updated in Ruby on Rails
  • Jon Leighton
    Jon Leighton commented at 11:19 AM
  • Jon Leighton
    Jon Leighton commented at 11:18 AM

    This tests in this commit were failing for me. Which is due to a missing fixtures declaration in the tests.

    I've attached a patch which fixes it.

    Cheers
Saturday, October 30 2010
5838 [PATCH] Refactoring AssociationProxy and subclasses to avoid @finder_sql, @co... was updated in Ruby on Rails
Thursday, October 28 2010
5838 [PATCH] Refactoring AssociationProxy and subclasses to avoid @finder_sql, @co... was updated in Ruby on Rails
  • Jon Leighton
    Jon Leighton commented at 3:00 PM

    Hiya,

    Is it possible to re-mark this as "open" as I have fixed the patch? I've re-applied and tested it today, it still applies cleanly and works. Just don't wa...
Thursday, October 21 2010
5838 [PATCH] Refactoring AssociationProxy and subclasses to avoid @finder_sql, @co... was updated in Ruby on Rails
  • Jon Leighton
    Jon Leighton commented at 5:54 PM

    Hi Aaron,

    Damn! Thanks for taking the time to look at this and really sorry that I messed it up. It looks like a teeny bit of my nested associations patch slipp...
Tuesday, October 19 2010
1152 Support for nested has_many :through associations was updated in Ruby on Rails
  • Jon Leighton
    Jon Leighton commented at 9:46 PM

    Hi all,

    TL;DR: Please help review this patch!

    I've got this patch to the point where I am happy with it now. There are plenty of tests and I have considered lot...
  • Jon Leighton
    Jon Leighton commented at 11:15 AM

    Hi all,

    I am getting quite close to finishing this now.

    I have submitted another independent refactoring patch at #5838. It would really help if some people cou...
1812 default_scope can't take procs was updated in Ruby on Rails
  • Jon Leighton
    Jon Leighton commented at 6:05 PM

    Heh, we're really grasping at straws now!

    I have my head in my own patch at the moment, but will try to run the tests on this later and add a +1.
  • Jon Leighton
    Jon Leighton commented at 5:49 PM

    Nice one for doing a patch.

    Personally I prefer:

        def current_scoped_methods #:nodoc:
      last = scoped_methods.last
      if last.is_a?(Proc)
        uns...
5838 [PATCH] Refactoring AssociationProxy and subclasses to avoid @finder_sql, @co... was updated in Ruby on Rails
  • Jon Leighton
    • Tag changed from active_record, associations, refactoring to active_record, associations, patch, refactoring
    by Jon Leighton at 2:49 PM