Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Johan Sørensen's latest activity

Saturday, May 30 2009
2703 [PATCH] 2.3.2 need a way to check if a session exists without creating one was updated in Ruby on Rails
  • Johan Sørensen
    Johan Sørensen commented at 11:29 AM

    facepalm

    That's quite a gaping hole indeed, I suggest reverting the commits as well until I (or someone else) come up with a better patch.

Wednesday, May 27 2009
2703 [PATCH] 2.3.2 need a way to check if a session exists without creating one was updated in Ruby on Rails
  • Johan Sørensen
    Johan Sørensen commented at 2:28 PM

    Second part of the patch

  • Johan Sørensen
    • Title changed from 2.3.2 need a way to check if a session exists without creating one to [PATCH] 2.3.2 need a way to check if a session exists without creating one
    • Tag set to cookies, session
    by Johan Sørensen at 2:27 PM

    I couldn't agree more. Attached is a patch series that only writes to the session store if the SessionHash setter was accessed.

    As a bonus, there's also a patch...

Tuesday, April 28 2009
2480 Cookie's expire value malformed in actionpack-2.3.2 was updated in Ruby on Rails
  • Johan Sørensen
    Johan Sørensen commented at 12:35 PM

    Stephen Seidt: could you elaborate on the source of the problem (localization code)? This very issue is bugging me right now…

1988 Make utf8 partial rendering from within a content_for work in ruby1.9 was updated in Ruby on Rails
  • Johan Sørensen
    Johan Sørensen commented at 12:26 PM

    TextHelper #concat should always deal with utf8 content while we're at it

  • Johan Sørensen
    Johan Sørensen commented at 12:26 PM

    Updated patch for latest 2-3-stable

Monday, March 09 2009
1988 Make utf8 partial rendering from within a content_for work in ruby1.9 was updated in Ruby on Rails
  • Johan Sørensen
    Johan Sørensen commented at 2:53 PM

    I haven't found any other places it's needed, but granted I've only been running this particular app where I found that issue on 1.9 for a few weeks. Other thin...

Friday, March 06 2009
2095 Adding public options to client-side caching was updated in Ruby on Rails
  • Johan Sørensen
    Johan Sørensen commented at 9:26 AM

    Due to the fact that this commit introduces two test methods named test_expires_in_header this is never exposed in the tests.

    Attached is a patch that renames o...

Thursday, March 05 2009
2095 Adding public options to client-side caching was updated in Ruby on Rails
  • Johan Sørensen
    • Assigned user set to DHH
    by Johan Sørensen at 3:40 PM

    Actually, the default Cache-Control seems to be no-cache now, when you use the conditional GET helpers at least. So this patch only helps if you only want publi...

Monday, February 16 2009
1988 Make utf8 partial rendering from within a content_for work in ruby1.9 was updated in Ruby on Rails