Ravil Bayramgalin

Rafael Mendonça França, I would gladly provide an additional patch for domain :all handling so you could set an arbitrary TLD length or provide a list of base d...

Fjan, could you give an example why do you think that patch sets illegal cookie domain name on localhost? As you could see in tests from patch I explicitly chec...

ActiveRecord uses partial updates. It means that only changed (dirty) attributes will be updated. To keep track of dirty attributes ActiveRecord checks on assig...

In irc we've come to conclusion that rails should set nil domain for ipv4/ipv6 addresses. It equals to implicit setting of domain for cookies. Therefore behavio...

http://gist.github.com/705069 - I've updated patch so explicit domain for cookies with domain :all option is set only when host is a domain name.

Always glad to...

http://gist.github.com/705069 - I've updated patch to prevent setting of localhost as domain for cookies.

I'm not sure of a reason, but I can not attach a patch via lighthouse. So you can get it at http://gist.github.com/705069. Sorry, for inconvenience.

Currently, if you use :all option for cookie store domain, cookies are created with wrong domain when site accessed via ip address or localhost.

For example, if...

Specifying gems in Gemfile doesn't require them automatically. You always need to require them manually, i prefer to do it in initializer.

+1 I've attached a patch which fixes grammar mistake in previous one, adds correct whitespace offset for generator names and updates a failing test.