Michael Koziarski
Coder Guy · Account member
Michael Koziarski's latest activity
Sunday, July 12 2009
-
Michael Koziarski commented at 4:24 AMRemove the ternary operator, it just obfuscates things:
if proc.arity == 1
proc.call ... else
proc.call ... endAlso update the docs so that it explains why you...
Friday, July 10 2009
Monday, July 06 2009
-
Michael Koziarski commented at 10:06 AMSounds good, can you attach that as a diff (assuming it's failing
:)). If it doesn't fail then we have a whole other problem :)
Sunday, July 05 2009
-
Michael Koziarski commented at 4:58 AMYeah, I'm kinda opposed to making those kind of changes, but would be
happy to look at a patch which achieved it.Fundamentally if you're directly working with ...
-
Michael Koziarski commented at 4:56 AMJeremy's the guy who did all the work the last time we had to deal
with test/unit, so he's probably the best one to comment on any
unified approach.But yeah, f...
-
Michael Koziarski commented at 3:58 AMAt the same time it could be worthwhile attempting to rationalise the 3 different implementations of url_for to make sure that they code they share, isn't repea...
-
- State changed from invalid to open
change UrlWriter#url_for to handle Strings as options?
This seems like the right place to handle this for me.
Saturday, July 04 2009
-
Michael Koziarski commented at 2:20 AMCan you provide us with a failing test in the activerecord test suite rather than a stand alone app? That'd make it much easier to reproduce and verify
Friday, July 03 2009
-
Michael Koziarski commented at 1:06 AMOK, I'm in agreement with will here. Can someone upload a patch to do
this, and then I think we're good to go.(or does it do this already?)
Thursday, July 02 2009
-
Michael Koziarski commented at 10:40 AMMy brain's a bit fried by this head-cold so I'm not sure on yehuda's
changes either. Will check them out properly in the morning, but odds
are this lighthouse e...