Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Michael Koziarski's latest activity

Friday, January 16 2009
1696 Problem with nested include missing data and old-style single query eager loa... was updated in Ruby on Rails
  • Michael Koziarski
    Michael Koziarski commented at 12:31 AM

    OK, the commit message should get redone to just describe the bug getting fixed rather than having review notes. There's some whitespace stuff

    Beyond that I thi...

Thursday, January 15 2009
1735 after_save callback should not be called if a before_* callback was cancelled was updated in Ruby on Rails
  • Michael Koziarski
    Michael Koziarski commented at 9:09 PM

    This change is consistent with the documentation so I'm going to apply it.

    However I think we'll just put it into 2.3, not a 2.2 point release. This should limi...

1696 Problem with nested include missing data and old-style single query eager loa... was updated in Ruby on Rails
1738 connection.columns doesn't get cached was updated in Ruby on Rails
  • Michael Koziarski
    • Assigned user set to Michael Koziarski
    by Michael Koziarski at 8:54 PM

    This is primarily an issue with HABTM though right? As the other associations don't look at their columns every time you try to use them?

    Luke, perhaps the best...

1755 JSON encoding of hashes does not always properly double quote keys was updated in Ruby on Rails
  • Michael Koziarski
    • Assigned user set to Michael Koziarski
    by Michael Koziarski at 8:43 PM

    Is there any reason we couldn't do this instead?

1178 Re-implemented support for updating a belongs to association from the foreign... was updated in Ruby on Rails
  • Michael Koziarski
    Michael Koziarski commented at 8:36 PM

    Could we perhaps push this logic into the proxy class itself? It knows the owner and the attribute that it matches?

    It'd make it a lot less intrusive than havin...

Monday, January 12 2009
1339 AR::Base should not be nuking it's children, just because it lost interest was updated in Ruby on Rails
  • Michael Koziarski
    Michael Koziarski commented at 9:10 AM

    Yep, if it still applies cleanly to master and/or 2-2-stable just let me know.

  • Michael Koziarski
    Michael Koziarski commented at 6:30 AM

    Perhaps the best bet here is to provide a patch which makes just the one potentially leaking change. Ideally one that applies cleanly to 2.2

    We can then ask peo...

1178 Re-implemented support for updating a belongs to association from the foreign... was updated in Ruby on Rails
  • Michael Koziarski
    Michael Koziarski commented at 7:44 AM

    hmm, that's a compelling point.

    Can you give us an updated rebased patch with a commit message explaining the feature rather than comparing it to the previous i...

  • Michael Koziarski
    • State changed from new to incomplete
    by Michael Koziarski at 5:59 AM

    I'd like to do this, but by adding a writer that invalidates all the cached associations.