Aaron Patterson
tenderlovemaker · Member of 1 project: Ruby on Rails
Aaron Patterson's latest activity
Monday, October 18 2010
-
- State changed from new to resolved
- Importance changed from to Low
You need to also use ARel-head. This is a bug fixed in ARel, and a new version of ARel will be released along with Rails 3.0.2.
Friday, October 15 2010
-
Aaron Patterson commented at 11:12 PMYou could set a custom formatter on the log object. This may not work for SyslogLogger because I don't think it conforms with the built in Logger interface.
Her...
Wednesday, October 13 2010
-
- State changed from needs-more-info to committed
@Jon awesome. Much easier to review. I've applied all your patches to master and pushed. Thank you very much!
Tuesday, October 12 2010
-
Aaron Patterson commented at 6:59 PMDamn! Thanks for the detailed explanation, I really appreciate it. The problem though, is that the first ~200 lines of the patch are mostly formatting and chang...
-
- State changed from new to needs-more-info
Are you sure about that? I see it right here:
http://github.com/rails/arel/blob/master/lib/arel/visitors.rb#L27
My tests pass, the rails CI seems happy. I thin...
Monday, October 11 2010
-
- State changed from new to needs-more-info
Hi @Jon,
It's very difficult for me to review this patch. Could you break it up in to multiple patches please? It looks like you're renaming variables and chang...
Sunday, October 10 2010
Friday, October 08 2010
-
- State changed from new to resolved
- Importance changed from to Low
This is fixed by ARel 2.0. Upgrading to Rails 3.0.2 should fix the problem (when it's released).
Thursday, September 30 2010
-
Aaron Patterson commented at 6:32 PM@Marcelo do you mind rebasing this patch against 3-0-stable? Then I'll apply it.
Thanks!