Geoff Buesing

Good catch. The call to #utc should fix this. In addition to asserting equality in the tests, we should also assert mtime.utc.utc? and mtime.time.utc? to check...

I think this is because Time#since does a DST adjustment if the passed-in value is >= 86400 seconds -- hence, the difference between adding 24.hours and adding...

re: TimeZone#=~

1. I think returning just true or nil is fine for now

2. instead of matching tzinfo.name, which will preload the tzinfo instance for every Ti...

Hmmm why did Lighthouse say I just added all of those tags?

Ernie,

I think the =~ method should be on the TimeZone instance, not the class, so that we're mirroring the semantics of String#=~

We could then do the on-th...

Time#to_s(:db) ignores Time#zone -- example:

>> Time.mktime(2008, 06, 20, 0, 31, 7).to_s(:db)
=> "2008-06-20 00:31:07"
>> Time.utc(2008, 06, 20, 0, 31, 7).t...

...also, just for reference: if you want to write a test for a specific system time zone, you can set ENV['TZ'] for that test -- see the with_env_tz helper in ...

Ok, I've looked into this a little more -- this is not an issue with 2.1 (irrespective of whether you're using config.time_zone or the system time zone), but i...

I wasn't able to replicate this in the console with Rails 2.1.

Would you be able to provide a failing test case for this?