Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Nick Sieger

Nick Sieger

Lackey · Not a member

Nick Sieger's latest activity

Thursday, February 19 2009
1752 Adding cleanup_connection method was updated in Ruby on Rails
  • Nick Sieger
    Nick Sieger commented at 5:04 PM

    Koz: with_connection doesn't associate the connection with the thread, so that regular code like Model.find would still pull another connection. That's yet anot...
Wednesday, February 18 2009
1752 Adding cleanup_connection method was updated in Ruby on Rails
  • Nick Sieger
    Nick Sieger commented at 8:28 PM

    Here's a patch w/ coderrr's tests and my approach with passing the block down through AR::Base.connection.
  • Nick Sieger
    Nick Sieger commented at 1:48 AM

    If you're satisfied with that pattern, we could push the logic up to the AR::Base class method to do the cleanup and it could do so with clear_active_connection...
Tuesday, February 17 2009
1752 Adding cleanup_connection method was updated in Ruby on Rails
  • Nick Sieger
    Nick Sieger commented at 10:48 PM

    I can appreciate the desire for this patch, but what about just piggy-backing off the existing connection method instead? Consider this patch:

    http://gist.githu...
Tuesday, January 06 2009
1685 Add AR test-connections for JDBC via JRuby was updated in Ruby on Rails
  • Nick Sieger
    Nick Sieger commented at 9:05 PM

    +1 from me, with this additional patch.
Thursday, December 11 2008
1558 Memory problem on reset_session in around_filter was updated in Ruby on Rails
Tuesday, September 30 2008
1144 Object#subclasses_of broken on JRuby was updated in Ruby on Rails
  • Nick Sieger
    Nick Sieger commented at 7:04 PM

    Try 7:03 PM patch
  • Nick Sieger
    Nick Sieger created the ticket at 6:07 PM

    6c970d79a064b953d3d9555a362a1ad1e0058d1c breaks JRuby, because JRuby disables ObjectSpace.each_object for anything other than Class by default for performance.
Friday, August 29 2008
936 Connection pooling was created in Ruby on Rails
  • Nick Sieger
    Nick Sieger created the ticket at 8:22 PM

    Connection pooling implementation for ActiveRecord
Friday, August 08 2008
782 Fix Failing "test_any_should_not_load_results" was updated in Ruby on Rails
  • Nick Sieger
    Nick Sieger commented at 4:30 AM

    +1 from me as the commenter on the commit.