Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Luke Melia's latest activity

Saturday, April 18 2009
2516 Avoid loading AR:SessionStore if not used was created in Ruby on Rails
  • Luke Melia
    Luke Melia created the ticket at 6:48 AM

    During initialization, a check to see whether ActiveRecord::SessionStore is the configured session store causes the ActiveRecord::SessionStore class to be loade...

Saturday, March 14 2009
2054 :requirements not passed to named_route generated by :member was updated in Ruby on Rails
  • Luke Melia
    Luke Melia commented at 4:04 AM

    I can confirm that Mike's new patch not only passes the test but also works properly in the real-world app that surfaced this issue.

Friday, March 13 2009
2054 :requirements not passed to named_route generated by :member was updated in Ruby on Rails
  • Luke Melia
    Luke Melia commented at 9:37 PM

    This change breaks collection routes when a resource has a collection action and member action named the same. Attached is a failing test demonstrating as much....

Friday, December 05 2008
553 config.gem compatibility with vendor/gem git submodule workflow was updated in Ruby on Rails
  • Luke Melia
    Luke Melia commented at 4:27 PM

    We've taken a similar approach to Aaron (called our dir vendor/garnets) to avoid a spattering of warnings at startup.

Tuesday, November 18 2008
1399 undefined method `format_and_extension' for #<ActionView::InlineTemplate> was updated in Ruby on Rails
  • Luke Melia
    • Tag changed from 2.2, actionview, partial to 2.2, actionview, partial, patch
    by Luke Melia at 7:24 AM

    You can ignore the previous attachment. Attached to this comment is a cleaner patch that also contains a fix.

  • Luke Melia
    Luke Melia commented at 6:59 AM

    I put together a failing test. While this may seem a little nuts, I am doing something similar in a production app and it works in 2.1.

  • Luke Melia
    Luke Melia created the ticket at 6:25 AM

    I don't have a simple reproducible case yet, but I'm receiving this error on 2-2-stable when trying to render a partial within a render_to_string. Full stack tr...

Monday, November 17 2008
553 config.gem compatibility with vendor/gem git submodule workflow was updated in Ruby on Rails
  • Luke Melia
    Luke Melia commented at 5:56 AM

    I'm running into this issue, too. In particular, there are some gems I want to track the trunk of our own fork via a submodule.

Sunday, November 16 2008
1383 render_to_string :inline before normal render causes assert_template failures was created in Ruby on Rails
  • Luke Melia
    Luke Melia created the ticket at 5:10 AM

    When render_to_string :inline => ... is called in a controller action a normal template render later occurs, the response.template's @_first_render variable is ...

Wednesday, June 25 2008
481 Route optimisation adds hanging question mark when passed empty options hash was created in Ruby on Rails
  • Luke Melia
    Luke Melia created the ticket at 4:05 AM

    From a view, when calling something like

    widget_path(5, {})

    you get

    /widgets/5?

    but I want

    /widgets/5

    Attached is a patch that fixes the problem, but I h...