Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Andrew Vit's latest activity

Monday, September 22 2008
1095 Time columns don't handle timezone correctly was created in Ruby on Rails
  • Andrew Vit
    Andrew Vit created the ticket at 10:50 PM

    When saving to a :time column, the value is converted to the database timezone (expect UTC in a normal setting).

    When reading the value back from the database, ...

Sunday, July 13 2008
584 Route matching in assert_redirected_to was updated in Ruby on Rails
  • Andrew Vit
    Andrew Vit commented at 9:33 AM

    Thanks... that does clear up a part of it.

  • Andrew Vit
    Andrew Vit commented at 9:27 AM

    Ok, let's leave it unless anyone else has an opinion. My closing arguments:

    "you can pass any argument to assert_redirected_to which resolves to the same pla...

Saturday, July 12 2008
584 Route matching in assert_redirected_to was updated in Ruby on Rails
  • Andrew Vit
    Andrew Vit commented at 10:57 PM

    Thanks for the quick patch... I was just trying it now, but it doesn't really change what I illustrated. If the controller says redirect_to string and the test...

Wednesday, July 09 2008
308 Fix assert_redirected_to for nested controllers was updated in Ruby on Rails
  • Andrew Vit
    Andrew Vit commented at 7:13 PM

    The follow-up ticket is #584. The test I attached to that ticket is the same as here, I stayed out of the nested modules ("components?").

    Thanks!

  • Andrew Vit
    Andrew Vit commented at 6:52 AM

    Gabe, it doesn't look like your patch attached here is the culprit, because the whole thing has since been rewritten... See ticket #c3aaba01

    A comment on the ...

  • Andrew Vit
    Andrew Vit commented at 5:15 AM

    It looks like this patch modified existing tests to specify the controller wherever it was omitted. For the record, I did try adding the controller in my own t...

  • Andrew Vit
    • Tag set to actionpack, patch
    by Andrew Vit at 5:08 AM

    This patch looks like it breaks existing documented functionality of assert_redirected_to. It's now too fussy about getting exact parameters in order to match ...

584 Route matching in assert_redirected_to was created in Ruby on Rails
  • Andrew Vit
    Andrew Vit created the ticket at 11:38 AM

    When testing redirects, the ability to partially match routes broke with the refactoring in commit #c3aaba01. Previously, it was possible to simply assert that...

Monday, May 05 2008
96 Form helpers don't handle "question?" methods was updated in Ruby on Rails
  • Andrew Vit
    Andrew Vit commented at 8:50 PM

    Updated patch to cache sanitized method name instead of doing the regex each time.