Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Josh Sharpe

Josh Sharpe

Not a member

Josh Sharpe's latest activity

Thursday, September 10 2009
2904 Avoid copying errors from child to parent on autosave was updated in Ruby on Rails
  • Josh Sharpe
    Josh Sharpe commented at 7:33 AM

    Hmm, I can't get 0001 to apply to 2.3. In the original post Jose mentioned it was to be applied on top of Eloy's branch, did those parts make it into 2.3?

    Also,...
  • Josh Sharpe
    Josh Sharpe commented at 7:21 AM

    Also, after looking at these patches, it doesn't look like :excepts works the same way that :associations does.

    Say I want to show errors for an association

    :as...
  • Josh Sharpe
    Josh Sharpe commented at 7:18 AM

    Also, what is the status of the above 3 patches? Is anyone currently working on them?

    I can consolidate them and attempt Jose's last addition.
  • Josh Sharpe
    Josh Sharpe commented at 7:11 AM

    I don't mean to pile on... but this is turning into a error_messages_for refactor...

    Would anyone be opposed to allowing :style to be passed to error_messages_f...
Wednesday, September 02 2009
2520 Patch - ActiveRecord#touch without validations was updated in Ruby on Rails
  • Josh Sharpe
    Josh Sharpe commented at 4:40 PM

    IMO any time save is called I want to know if my record is invalid so that I can do something about it. With this patch/idea it's not quite so obvious that touc...
Tuesday, September 01 2009
3122 [PATCH] Support of OR as condition connector in merge_conditions was updated in Ruby on Rails
  • Josh Sharpe
    Josh Sharpe commented at 8:12 PM

    -1 applies cleanly to master
    breaks existing tests
    no new tests
3130 [PATCH] add strip_attributes support to ActiveModel and Active Record was created in Ruby on Rails
  • Josh Sharpe
    Josh Sharpe created the ticket at 3:22 PM

    Added support for ActiveModel#strip_attributes and ActiveRecord::Base.strip_attributes!

    ActiveModel#strip_attributes removes leading and trailing
    white spaces f...
Monday, August 31 2009
2650 Added previous_changes to ActiveRecord::Dirty [PATCH] was updated in Ruby on Rails
  • Josh Sharpe
    • Tag changed from activerecord, bugmash, dirty, patch to activerecord, dirty, patch, previous_changes
    • Title changed from Added previous_changes to ActiveRecord::Dirty to Added previous_changes to ActiveRecord::Dirty [PATCH]
    by Josh Sharpe at 5:36 PM

    Rebased Scott's patch for master.
Saturday, August 08 2009
2944 Titleize doesn't take all-uppercase words into account was updated in Ruby on Rails
  • Josh Sharpe
    Josh Sharpe commented at 6:24 AM

    Here's an addition to the previous patch that titleizes ALL CAPS strings.
  • Josh Sharpe
    Josh Sharpe commented at 5:52 AM

    I agree with steve, but I don't like the config option idea... What if we changed the patch to detect a caps-locked entry:

    pseudo-code

    if str == str.upcase
    titl...