Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Lawrence Pit's latest activity

Tuesday, February 16 2010
3185 Docs and tests for the Errors.each_error method was updated in Ruby on Rails
  • Lawrence Pit
    Lawrence Pit commented at 11:44 PM

    close this one... its now moot, given the rails 3 Errors class.

3288 Using destroy on AR association collection updates the collection in memory. was updated in Ruby on Rails
  • Lawrence Pit
    Lawrence Pit commented at 11:37 PM

    So are you +1 on the patch? ;-)

    To me it's very simple: If one deletes something from a collection, then no one would expect it to be still part of that collect...

Tuesday, January 05 2010
2036 Linking and unlinking via accepts_nested_attributes_for was updated in Ruby on Rails
  • Lawrence Pit
    Lawrence Pit commented at 11:19 PM

    Hi, a few months ago I made a plugin for this, I've been using it since then to satisfaction in a real live app.

    I've just uploaded this plugin, see:

    http://git...

Tuesday, December 01 2009
3185 Docs and tests for the Errors.each_error method was updated in Ruby on Rails
Tuesday, October 13 2009
3185 Docs and tests for the Errors.each_error method was updated in Ruby on Rails
  • Lawrence Pit
    • Assigned user set to Michael Koziarski
    by Lawrence Pit at 7:47 AM
Thursday, October 01 2009
2578 accepts_nested_attributes_for causes stack level too deep was updated in Ruby on Rails
  • Lawrence Pit
    Lawrence Pit commented at 9:27 AM

    Bryan, applied your patch again, confirmed that without my patch your test will go into a stack overflow.

    +1, if I may :)

  • Lawrence Pit
    Lawrence Pit commented at 4:37 AM

    The test was indeed faulty in my opinion. Attached is a patch with all tests passing.

    What remains is to add a test that mimics your original scenario.

  • Lawrence Pit
    Lawrence Pit commented at 4:21 AM

    The suggestion was from the top of my head ;-) The following works a lot better, though still 2 failing tests (actually it's 1 test)... but I'm thinking the tes...

Monday, September 28 2009
2100 Change behaviour of association's after_add callback was updated in Ruby on Rails
  • Lawrence Pit
    Lawrence Pit commented at 1:43 AM

    I don't think the behaviour of before_add/after_add/before_remove/after_remove should be changed, even though many times I was tempted to do the same.

    Instead I...