Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Amos King

Amos King

Software Developer · Not a member

Amos King's latest activity

Thursday, April 23 2009
2545 validations based on methods and not actual attributes was updated in Ruby on Rails
  • Amos King
    • Tag changed from invalid to validations
    by Amos King at 1:25 PM

    It is not ok. If your database isn't constraining that column you may have bad data in the database.
Wednesday, April 22 2009
2545 validations based on methods and not actual attributes was created in Ruby on Rails
  • Amos King
    Amos King created the ticket at 11:43 PM

    The validations are calling methods. Let's say I have an attribute 'attr' and I have a validates_presence_of :attr. Now I have the following method

    def attr sup...
Friday, April 03 2009
2403 TestRequest initializes session_options without defaults was updated in Ruby on Rails
  • Amos King
    Amos King commented at 3:13 AM

    Works for me.

    +1
Wednesday, February 04 2009
1862 Running autolink on text containing a mailto: link breaks was updated in Ruby on Rails
  • Amos King
    • Tag changed from ruby 1.8.7, actionview, auto_link, bug, edge, text_helper to ruby 1.8.7, actionview, auto_link, bug, edge, patch, text_helper
    by Amos King at 3:12 AM

    +1
Tuesday, February 03 2009
1852 Patch to add index length support was updated in Ruby on Rails
  • Amos King
    Amos King commented at 3:34 PM

    This is a great idea. Anything that can help speed things up a little is wonderful.

    +1
Tuesday, January 27 2009
1801 TestSession and AbstractStore delete and update methods do not match in param... was updated in Ruby on Rails
  • Amos King
    Amos King commented at 7:04 PM

    Josh, why didn't you take the tests that gaffo had committed?
  • Amos King
    Amos King commented at 2:05 PM

    backfilled tests, and fixed a bug. +2
Friday, January 02 2009
1143 Make #respond_to implicit in controller actions was updated in Ruby on Rails
  • Amos King
    Amos King commented at 9:16 PM

    This is great. I would add a dep warning to the old way and remove the old block way on the next release from there. That way we can get rid of the block check ...
1295 [PATCH] making ActiveRecord #with_scope merge :selects was updated in Ruby on Rails
  • Amos King
    Amos King commented at 9:12 PM

    I'm willing to try this, but why not just have a different named scope for you select clause?

    +0
Tuesday, December 16 2008
1249 New Feature - grouped_collection_select was updated in Ruby on Rails
  • Amos King
    • Tag changed from feature, formoptionshelper to actionview, enhancement, formoptionshelper, patch
    by Amos King at 2:39 PM

    I think the attempt to make the api consistent is great, and it sure is a lot less typing. You also documented and tested. You get my vote. +1