Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Ernie Miller's latest activity

Friday, December 18 2009
765 PATCH: primary_key option for belongs_to was updated in Ruby on Rails
  • Ernie Miller
    Ernie Miller commented at 6:16 PM

    This seems as useful a place to put the following patch as well. Looks like association.rb wassn't accounting for :primary_key option in association_join.

    This ...

Thursday, November 06 2008
1102 Added :counter_sql to valid keys for HABTM was updated in Ruby on Rails
  • Ernie Miller
    Ernie Miller commented at 8:26 PM

    Tekin,

    Thanks for jumping on this so fast! You saved me the pain. :)

Wednesday, September 24 2008
831 count on HABTMs broken by Ruby 1.8.7 Array.count was updated in Ruby on Rails
  • Ernie Miller
    Ernie Miller commented at 2:40 PM

    I checked, and it hasn't been fixed in edge yet. See #1102 for the one-liner patch. We should really get some fixtures that use counter_sql on a HABTM to catch ...

  • Ernie Miller
    Ernie Miller commented at 2:02 PM

    Good catch. This is a trivial fix -- Jeremy, do you want me to submit another patch, or is this fixed in edge already?

1102 Added :counter_sql to valid keys for HABTM was created in Ruby on Rails
  • Ernie Miller
    Ernie Miller created the ticket at 2:37 PM

    In #831, I submitted a patch to refactor AssociationCollection#count and fix problems with HABTM count in Ruby 1.8.7. I forgot to add :counter_sql to the list o...

Thursday, August 28 2008
831 count on HABTMs broken by Ruby 1.8.7 Array.count was updated in Ruby on Rails
  • Ernie Miller
    • Tag changed from 2.1, activerecord, bug, edge, patch to 2.1, activerecord, bug, edge, patch, tests
    by Ernie Miller at 7:10 PM

    Added a test based on Mike's example above, and merged Tarmo's :offset and :limit constraints from #348 as well.

Friday, August 15 2008
839 Time columns do not support time zones was updated in Ruby on Rails
  • Ernie Miller
    Ernie Miller commented at 2:05 PM

    I'm not sure I agree on this one. When only time, and not date is being persisted in the database, part of the information required to make an intelligent decis...

831 count on HABTMs broken by Ruby 1.8.7 Array.count was updated in Ruby on Rails
  • Ernie Miller
    Ernie Miller commented at 3:30 AM

    Updated patch to add a bit of documentation.

    I'm a little concerned about the handling of a has_many association's :conditions option if passed to count. Befor...

Thursday, August 14 2008
831 count on HABTMs broken by Ruby 1.8.7 Array.count was updated in Ruby on Rails
  • Ernie Miller
    Ernie Miller commented at 9:38 PM

    If you get the chance, try the patch I attached and let me know how it works for you... and if it breaks anything new and exotic! ;)

  • Ernie Miller
    • Tag changed from 2.1, activerecord, edge to 2.1, activerecord, bug, edge, patch
    by Ernie Miller at 9:14 PM

    There's actually no count method defined on the habtm association class, which would help explain the issue. ;)

    After a quick look through the association code...