John Trupiano's profile

John Trupiano commented at 9:44 PM
@sr.iniv.t this patch does not apply cleanly for me. I have attached a new patch.

John Trupiano commented at 9:29 PM
Patch attached.
John Trupiano created the ticket at 9:23 PM
This patch builds on top of #3106 ( https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets... ). Please apply that patch first if it has not alrea...

John Trupiano commented at 9:23 PM
fyi, I created a separate ticket that builds on this patch as Dan Pickett suggested: https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets...
John Trupiano commented at 5:52 PM
Looking at this other example:
```
  distance_of_time_in_words(from_time, from_time + 50.minutes)        # => about 1 hour
```
I'd think we'd just keep with 'about' i...
John Trupiano commented at 5:42 PM
Dan, I was thinking at 9 months. In the general case, I was thinking that once it's past 3/4 the distance between the 2 whole values that we should switch to "a...
John Trupiano commented at 4:55 PM
I'd be in favor of introducing the "almost" identifier as well. For instance, I'd think that distance_of_time_in_words(from_time, from_time + 3.years + 10.month...

John Trupiano commented at 6:40 PM
My point is that a TimeZone object exists in the absence of a specific time. It's a matter of responsibility. A TimeZone should only take DST into account if it...
John Trupiano commented at 4:31 PM
Now that I think about this further, I'm not sure that a change is warranted. A TimeZone object exists outside of the context of an actual Time instance. It's s...

John Trupiano commented at 4:23 PM

Verified that it's only a problem in DST.

  john-mbp:rails john$ ruby script/console 
  Loading development environment (Rails 3.0.pre)
  /Users/john/projects/...