Tom Lea
Developer · Not a member
Tom Lea's latest activity
Monday, November 03 2008
-
Tom Lea commented at 2:04 PMWell spotted! I have a couple of enhancements to the patch that could be made.
-
match = matches_dynamic_method?(method_symbol)looks clearly broken as of 3cf773...
-
Saturday, November 01 2008
-
Tom Lea commented at 6:00 PMRight, went a little further, built up an array and then &&'d them, felt more readable, all the requirements with a line each.
Final merged + rebased patch atta...
-
Tom Lea commented at 4:46 PMSo from my understanding, the url_for in ActionView will fallback to the controller's default_url_options. Because of this the faster routes guard conditions d...
Friday, October 31 2008
-
Tom Lea commented at 8:08 PMI got bored, so here is a possible implementation of delegating named routes away to the controller.
Patch attached.
-
Tom Lea commented at 2:26 PMKoz: The guard conditions don't fire because default_url_options is not defined on the action view.
The patch should just disable _url methods and not _path met...
Thursday, October 30 2008
Tuesday, October 28 2008
-
Tom Lea commented at 12:41 AMNew patch, error message was not as expected. Copied through relationship exception format by accident... oops.
Also rebased against HEAD while I was at it.
Monday, October 27 2008
-
Tom Lea commented at 5:48 PMIndeed it is... but the fact that it pretends to work is the issue.
The whole thing seems to work just fine, we were several unit tests in before it started beh...
Wednesday, October 22 2008
-
Tom Lea created the ticket at 11:36 PMSelf referential HABTM associations should not be allowed to be created unless the association_foreign_key has been manually assigned.
If this is not prevented,...
Tuesday, October 14 2008
-
- Tag changed from activesupport, bug, core_ext, patch to activesupport, bug, core_ext, patch
Thanks for the commit Geoff.