Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Tom Lea's latest activity

Monday, November 03 2008
1318 Make ActionMailer::Base.method_missing more precise was updated in Ruby on Rails
  • Tom Lea
    Tom Lea commented at 2:04 PM

    Well spotted! I have a couple of enhancements to the patch that could be made.

    1. match = matches_dynamic_method?(method_symbol) looks clearly broken as of 3cf773...
Saturday, November 01 2008
1301 [PATCH] Named Routes in ActionView Scope Don't Respect AC::Base#default_url_o... was updated in Ruby on Rails
  • Tom Lea
    Tom Lea commented at 6:00 PM

    Right, went a little further, built up an array and then &&'d them, felt more readable, all the requirements with a line each.

    Final merged + rebased patch atta...

  • Tom Lea
    Tom Lea commented at 4:46 PM

    So from my understanding, the url_for in ActionView will fallback to the controller's default_url_options. Because of this the faster routes guard conditions d...

Friday, October 31 2008
1301 [PATCH] Named Routes in ActionView Scope Don't Respect AC::Base#default_url_o... was updated in Ruby on Rails
  • Tom Lea
    Tom Lea commented at 8:08 PM

    I got bored, so here is a possible implementation of delegating named routes away to the controller.

    Patch attached.

  • Tom Lea
    Tom Lea commented at 2:26 PM

    Koz: The guard conditions don't fire because default_url_options is not defined on the action view.

    The patch should just disable _url methods and not _path met...

Thursday, October 30 2008
1301 [PATCH] Named Routes in ActionView Scope Don't Respect AC::Base#default_url_o... was created in Ruby on Rails
  • Tom Lea
    Tom Lea created the ticket at 6:09 PM

    As discussed on the mailing list:

    I have added a test case [1] in url_helper_test.rb (1st commit), that replicates a scenario we are seeing in production.

    This ...

Tuesday, October 28 2008
1252 Bad self referential HABTM associations should fail fast. was updated in Ruby on Rails
  • Tom Lea
    Tom Lea commented at 12:41 AM

    New patch, error message was not as expected. Copied through relationship exception format by accident... oops.

    Also rebased against HEAD while I was at it.

Monday, October 27 2008
1252 Bad self referential HABTM associations should fail fast. was updated in Ruby on Rails
  • Tom Lea
    Tom Lea commented at 5:48 PM

    Indeed it is... but the fact that it pretends to work is the issue.

    The whole thing seems to work just fine, we were several unit tests in before it started beh...

Wednesday, October 22 2008
1252 Bad self referential HABTM associations should fail fast. was created in Ruby on Rails
  • Tom Lea
    Tom Lea created the ticket at 11:36 PM

    Self referential HABTM associations should not be allowed to be created unless the association_foreign_key has been manually assigned.

    If this is not prevented,...

Tuesday, October 14 2008
970 1.5.days.ago != 36.hours.ago was updated in Ruby on Rails
  • Tom Lea
    • Tag changed from activesupport, bug, core_ext, patch to activesupport, bug, core_ext, patch
    by Tom Lea at 5:35 PM

    Thanks for the commit Geoff.