Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Tom Lea's latest activity

Thursday, August 14 2008
785 Caching models fails in development was updated in Ruby on Rails
  • Tom Lea
    Tom Lea commented at 8:21 PM

    Rob is right about consistency... but we need core to agree on what to consist upon (if you follow my bad grammar).

    Should Cache::Store just store strings, or ...

  • Tom Lea
    Tom Lea commented at 5:48 PM

    Right, managed to replicate what I think jshumate was experiencing.

    The attached patch seems to fix it for my simple test site (sorry no unit tests)... but if ...

827 String#each_char 1.9 syntax fix was created in Ruby on Rails
  • Tom Lea
    Tom Lea created the ticket at 2:26 PM

    Hi, Was curious and tried rails with 1.9.. found it broke at start-up.

    This was due to || not accepting a void expression on it's RHS.

    This syntax error ca...

Wednesday, August 13 2008
799 MemoryStore cache contents should be immutable was updated in Ruby on Rails
  • Tom Lea
    Tom Lea commented at 6:51 PM

    As I understand it all Caches serialize (Martial or YAML) into the store, unless :raw is set. This is well tested and expected. Memory store should be no differ...

492 content_tag should accept block using variable was updated in Ruby on Rails
  • Tom Lea
    • Tag changed from content_tag, enhancement, helper, view to content_tag, enhancement, helper, patch, view
    by Tom Lea at 2:20 PM

    What about...

    
    content_tag(:p) do
      returning("") do |content|
        content << fetch_value
        content << fetch_value(2)
        content << another_value
      end
    end
    
    ...
Tuesday, August 12 2008
788 partial_updates clobbers serialized attributes was updated in Ruby on Rails
  • Tom Lea
    Tom Lea commented at 5:39 PM

    Thanks for the commit Koz!

  • Tom Lea
    • Title changed from Saving Only "changed" Attributes Hurts Serialization to partial_updates clobbers serialized attributes
    by Tom Lea at 1:57 PM
Monday, August 11 2008
788 Saving Only "changed" Attributes Hurts Serialization was updated in Ruby on Rails
  • Tom Lea
    Tom Lea commented at 10:27 PM

    It would be nice, but this would make the behaviour inconsistent with the (odd but expected) behaviour of other attributes (see #608).

    The patch will not fix a...

  • Tom Lea
    • Tag changed from activerecord, bug to 2.1, activerecord, bug, patch
    by Tom Lea at 6:20 PM

    This looks like a bug to me... with partial_updates update will only save attributes that are dirty, so serialized attributes are skipped.

    Trivial quick patch ...

799 MemoryStore cache contents should be dup'd.. was updated in Ruby on Rails
  • Tom Lea
    Tom Lea commented at 4:57 PM

    Not sure if this is a show stopper but the following test (inserted in MemoryStoreTest) fails:

    
      class SimpleClass
        attr_accessor :value
        def initialize...