Mike Breen
Not a member
Mike Breen's latest activity
Saturday, October 24 2009
-
Mike Breen commented at 8:13 PM@Mislav - Thanks for the feedback. I guess it would be better to handle anything that has a to_a:
ids.inject([]) {|m,o| m << (o.respond_to? :to_a ? o.to_a : o)... -
Mike Breen created the ticket at 5:58 PMThis patch will allow you to pass a Range of IDs to find:
Person.find(1..5) Person.find(1, 3..8)
Saturday, September 26 2009
-
- Tag changed from active_record, counter_cache, patch to active_record, bugmash, counter_cache, patch
Thursday, August 13 2009
-
Mike Breen commented at 12:24 AMIs there a reason we can't get this patch into 2-3-stable. It applies cleanly.
Monday, August 10 2009
-
Mike Breen commented at 1:24 AMsorry, this does not apply cleanly to master:
error: patch failed: actionpack/test/template/form_options_helper_test.rb:681
error: actionpack/test/template/form... -
- Assigned user set to Pratik
- Tag changed from actionview, enhancement, formoptionshelper, patch to actionview, bugmash, enhancement, formoptionshelper, patch
+1 for this change and I have verified that this patch applies cleanly to master.
-
Mike Breen commented at 1:18 AM+1 verified Elad's patch applies cleanly to master. all tests are green
-
Mike Breen commented at 1:14 AMsame for master:
error: patch failed: activerecord/lib/active_record/attribute_methods.rb:224
error: activerecord/lib/active_record/attribute_methods.rb: patch ... -
- Tag changed from activerecord, patch to activerecord, bugmash, patch
+1 for the change but I have verified that the patch does not apply cleanly:
activerecord/../merge-attributes-rename-with-deprecation.diff:161: trailing whites...