ronin-37814 (at lighthouseapp)

Yes, the issue you pointed out is exactly why I created this ticket.

We need more than what your implementation of with_connection provides. If you have nested ...

Well there are two versions...

In the original version (cleanup_connection method), if a connection is already checked out it won't check out a new one. But wil...

with_connection isn't good enough. It only releases the connection which it checks out. And the connection it checks out will be different from AR::B#connection

Hey nick

The only issue with that is that if you have multiple connections (in different AR models) you'd need to do a connection call for each of them. If you ...

As requested by lifo

Real World Usecase:

You have 100 threads which stay alive and running throughout the entire life of your process. These threads are intermi...

Moved cleanup_connection method to ConnectionHandler. Using clear_active_connections! instead of release_connection so we release connections from all connectio...

renamed thread local variable to cleanup_connection

added more real-world test case for nesting safety

Realized all I really care about is cleaning up the connection at the end of the block, so here's a simpler version. It doesn't explicitly check out the connect...

example of why nesting protection is very helpful

def x
  using_connection do
    User.all.each {|u| y(u) }
  end
end

def y(u)
  using_connection do
...