Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Elomar França's latest activity

Sunday, September 27 2009
3162 Memoizable doesn't memoize overriden methods was updated in Ruby on Rails
  • Elomar França
    • Tag changed from bugmash to activesupport, bugmash, memoizable
    by Elomar França at 8:06 PM

    +1, verified.

    In this case, memoization would only work if Bar#foo called super.

    I've attached a patch with a failing test, applies on 2-3-stable and master.

3188 [ActiveRecord] create(:association_id => @object.id) vs create(:association_i... was updated in Ruby on Rails
  • Elomar França
    Elomar França commented at 7:27 PM

    +1, verified.

    I had some failures when applying the patch from Elad Meidar, both on master and 2-3-stable.

    I think this issue could also be solved in "write_att...

3275 [PATCH] Optimization for dropping multiple columns in MySQL was updated in Ruby on Rails
  • Elomar França
    Elomar França commented at 5:53 PM

    +1, verified.

    I think that optimizations like this (tiny but significative) are always welcome. The patch applies on 2-3-stable and master.

3234 change_column carries over default when it can't be carried was updated in Ruby on Rails
  • Elomar França
    Elomar França commented at 5:45 PM

    +1, verified on Mysql 5.0.81 in TRADITIONAL mode.

    I've attached a patch with a test based on the one from dira and a tiny fix. Applies on 2-3-stable and master.

  • Elomar França
    Elomar França commented at 5:44 PM

    +1, verified on Mysql 5.0.81 in TRADITIONAL mode.

    I've attached a patch with a test based on the one from dira and a tiny fix. Applies on 2-3-stable and master.

1828 ActiveResource breaks when encounters <object> tag in XML was updated in Ruby on Rails
  • Elomar França
    Elomar França commented at 4:24 PM

    Verified the bug, but I do not agree with the hardcoded solution.

    I think it would be better to have some kind of reserved words list, as Peer Allan proposed. I...

2114 ActiveSupport lacks beginning_of_hour was updated in Ruby on Rails
  • Elomar França
    Elomar França commented at 3:52 PM

    +1, verified.

    Agree with the addition, and both patches apply.

3278 [PATCH] Allow PKG_NAME env variable to control the directory name used when ... was updated in Ruby on Rails
  • Elomar França
    Elomar França commented at 3:48 PM

    +1, verified.

    I agree with this addition, and the patch applies cleanly to master and 2-3-stable.

2132 Confusing behavior with attr_readonly was updated in Ruby on Rails
  • Elomar França
    Elomar França commented at 2:26 PM

    +1 for the feature, but the patches does not seem to work on SQLite3:

    /test/cases/base_test.rb:937:in test_update_attribute_raises_an_exception_if_given_a_reado...

Saturday, September 26 2009
3088 [PATCH] Make has_one with :conditions hash scope build or creation of object ... was updated in Ruby on Rails
  • Elomar França
    Elomar França commented at 7:32 PM

    +1 for this feature.

    Both patches from luciano.panaro applied successfully.