Jeff Dean
Not a member
Jeff Dean's latest activity
Wednesday, June 23 2010
-
Jeff Dean commented at 7:19 AMSorry - that patch didn't come through too well on 2-3-stable. Here's an updated version for 2-3-stable. It applies cleanly for me, and tests pass.
-
Jeff Dean commented at 6:13 AMThank you for the feedback.
I'll find a good way to remove that loop and resubmit.
Saturday, June 19 2010
-
- Tag changed from 2-3-stable, active_record, associations, belongs_to to active_record, associations, belongs_to, patch
This issue is far more complex than I realized, but luckily the fix was simple and clean. Take this example:
class Client < Company belongs_to :firm, :foreig...
-
Jeff Dean commented at 3:13 AMThe
firstmethod ignores that id in all database drivers.firstjust adds alimit 1to the query - so in your case, it looks like in your mysql database, the fi...
Saturday, June 12 2010
-
Jeff Dean commented at 3:43 AMI agree that the db errors should be consistent, and I believe they are. However, when you execute
remove_column(:name)it's never getting to mysql at all becau...
-
Jeff Dean commented at 2:18 AMThank you for verifying.
The block syntax of fetch only evaluates the default value if the key is not present in the hash.
In the
options.fetch(:foo, bar)case,... -
Jeff Dean commented at 1:29 AMThe attached patch contains:
- a fix for the nil-id
- tests
- a minor refactoring to the fetch syntax for better performance (using the block syntax instead of the a...
-
Jeff Dean created the ticket at 1:25 AMCurrently you cannot set the value of a text_field or hidden_field to nil:
f.text_field :some_field, :value => nil # => will output an input with a value equal...
-
Jeff Dean commented at 1:34 AMPratik - any chance you could elaborate on why routes should be case-sensitive?
Are you aware of any apps in production that rely on case-sensitive routes? Is t...