Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Jeff Dean's latest activity

Wednesday, June 23 2010
4839 [PATCH] form fields should allow developers to set values to nil was updated in Ruby on Rails
  • Jeff Dean
    Jeff Dean commented at 7:19 AM

    Sorry - that patch didn't come through too well on 2-3-stable. Here's an updated version for 2-3-stable. It applies cleanly for me, and tests pass.

2989 Setting the id of a belongs_to object does not update the reference to the ob... was updated in Ruby on Rails
  • Jeff Dean
    Jeff Dean commented at 6:13 AM

    Thank you for the feedback.

    I'll find a good way to remove that loop and resubmit.

Saturday, June 19 2010
2989 Setting the id of a belongs_to object does not update the reference to the ob... was updated in Ruby on Rails
  • Jeff Dean
    • Tag changed from 2-3-stable, active_record, associations, belongs_to to active_record, associations, belongs_to, patch
    by Jeff Dean at 7:38 AM

    This issue is far more complex than I realized, but luckily the fix was simple and clean. Take this example:

    class Client < Company
      belongs_to :firm, :foreig...
4893 Rails 2 AR#first method was updated in Ruby on Rails
  • Jeff Dean
    Jeff Dean commented at 3:13 AM

    The first method ignores that id in all database drivers. first just adds a limit 1 to the query - so in your case, it looks like in your mysql database, the fi...

Saturday, June 12 2010
4803 [PATCH] remove_column should raise an ArgumentError when no columns are passed was updated in Ruby on Rails
  • Jeff Dean
    Jeff Dean commented at 3:43 AM

    I agree that the db errors should be consistent, and I believe they are. However, when you execute remove_column(:name) it's never getting to mysql at all becau...

4839 [PATCH] form fields should allow developers to set values to nil was updated in Ruby on Rails
  • Jeff Dean
    Jeff Dean commented at 2:18 AM

    Thank you for verifying.

    The block syntax of fetch only evaluates the default value if the key is not present in the hash.

    In the options.fetch(:foo, bar) case,...

  • Jeff Dean
    Jeff Dean commented at 1:29 AM

    The attached patch contains:

    • a fix for the nil-id
    • tests
    • a minor refactoring to the fetch syntax for better performance (using the block syntax instead of the a...
  • Jeff Dean
    Jeff Dean created the ticket at 1:25 AM

    Currently you cannot set the value of a text_field or hidden_field to nil:

    f.text_field :some_field, :value => nil # => will output an input with a value equal...
393 Routes are case sensitive was updated in Ruby on Rails
  • Jeff Dean
    Jeff Dean commented at 1:34 AM

    Pratik - any chance you could elaborate on why routes should be case-sensitive?

    Are you aware of any apps in production that rely on case-sensitive routes? Is t...

Wednesday, June 09 2010
4778 Can't create a model called Task - conflicts with Rake::Task?? was updated in Ruby on Rails
  • Jeff Dean
    Jeff Dean commented at 6:11 AM

    This has happened to me in the past when loading a gem or plugin that requires rake. For example whenever.

    If you are using bundler, you may have to add :requir...