Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Brian Lopez's latest activity

Friday, June 18 2010
4897 Yajl backend discovery fails in ActiveSupport::JSON was updated in Ruby on Rails
Tuesday, May 04 2010
4532 [PATCH] add support for mysql2 adapter to dbconsole was created in Ruby on Rails
  • Brian Lopez
    Brian Lopez created the ticket at 9:49 PM

    Currently script/dbconsole only supports the mysql, postgresql, sqlite and sqlite3 adapters. This [tiny] patch adds support for using the Mysql2 adapter as well...

4514 [PATCH] Check and immediately return value from an average if it's already a ... was updated in Ruby on Rails
  • Brian Lopez
    Brian Lopez commented at 8:23 PM

    Attaching the backport for 2.3

  • Brian Lopez
    Brian Lopez commented at 7:35 PM

    new patch per code-review

  • Brian Lopez
    Brian Lopez commented at 7:10 PM

    Was worried that wouldn't be desired - in our short chat on IRC about it you mentioned returning 0 for nil which is why I put it in there.
    It does make sense to...

  • Brian Lopez
    Brian Lopez commented at 9:30 AM

    Ok, here's the patch with updated and passing tests (based on master)

Monday, May 03 2010
4514 [PATCH] Check and immediately return value from an average if it's already a ... was updated in Ruby on Rails
  • Brian Lopez
    Brian Lopez commented at 10:55 PM

    Here's the updated patch, still looking into test failures to see if they're from this or something else

  • Brian Lopez
    Brian Lopez commented at 7:11 PM

    Was hoping to fix and repost the patch this weekend but didn't end up having time. I'll try and get it up today or tomorrow

Saturday, May 01 2010
4520 #as_json should only ever return a Hash, Array, Numeric, String, nil, true or... was updated in Ruby on Rails
  • Brian Lopez
    • Tag set to activerecord, activesupport, json, serialization
    by Brian Lopez at 7:38 PM
  • Brian Lopez
    Brian Lopez created the ticket at 7:38 PM

    By my understanding, the #as_json method should return an object that can be nearly mapped directly to JSON (given the data types mentioned in this issue's titl...