Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

phs's latest activity

Monday, April 19 2010
4442 [PATCH] "nested *?+ in regexp" in Engine initializer for funny FS paths. was updated in Ruby on Rails
  • phs
    phs commented at 11:12 PM

    I'm happy to supply a test, but I need a tip on what suite I could put it in. Is there one around that can run engine initializers?

  • phs
    • Title changed from "nested *?+ in regexp" in Engine initializer for funny FS paths. to [PATCH] "nested *?+ in regexp" in Engine initializer for funny FS paths.
    by phs at 8:46 PM
  • phs
    • Tag set to rails3 routes, engines
    by phs at 8:46 PM

    The patch.

  • phs
    phs created the ticket at 8:37 PM

    /opt/local/lib/ruby/gems/1.8/gems/railties-3.0.0.beta2/lib/rails/engine.rb:169: nested *?+ in regexp: /\/private\/var\/folders\/jk\/jkDWr4rvFmaZpmyyRu83zE+++TI...

Friday, April 16 2010
4412 [PATCH] Timestamped migrations should detect collisions was updated in Ruby on Rails
  • phs
    • Title changed from Timestamped migrations should detect collisions to [PATCH] Timestamped migrations should detect collisions
    by phs at 6:39 AM
  • phs
    phs commented at 6:38 AM

    The patch. Timestamp migration numbers are [current timestamp, current_migration_number + 1].max

  • phs
    phs created the ticket at 3:54 AM

    The timestamp in timestamped migrations does not account for other migrations sharing the same timestamp. The corner case was previously pathological.

    One reaso...

2058 Rake tasks for run engine migrations was updated in Ruby on Rails
  • phs
    phs commented at 1:53 AM

    +1 for @James Adam 's approach. Particularly I'd prefer copying the migrations into the hosting application, since it gives the host's maintainer an opportunity...

Thursday, April 15 2010
4400 [PATCH] Avoid app_const when drawing routes in app generator was updated in Ruby on Rails
  • phs
    phs commented at 7:07 AM

    And the patch.

  • phs
    phs created the ticket at 7:02 AM

    The app generator's config/routes.rb template draws it routes with <%= app_const %>.routes.draw.

    If the application intent is to become an engine, then the app_...