Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

David Trasbo's latest activity

Tuesday, June 29 2010
379 [PATCH] ActiveRecord::Base class_name weirdness was updated in Ruby on Rails
  • David Trasbo
    David Trasbo commented at 3:56 PM

    Sure, I've made two patches: One that applies to master which simply removes the method and the corresponding test, and one that applies to 2-3-stable that issu...

  • David Trasbo
    David Trasbo commented at 1:14 PM

    Ignore 2901.diff. It's a patch for another ticket. :)

  • David Trasbo
    David Trasbo commented at 1:14 PM

    The ActiveSupport::Deprecation has native support for deprecating methods. I've attached a patch that makes use of that. Also, I propose not removing the test u...

  • David Trasbo
    • Assigned user changed from Tarmo Tänav to José Valim
    • Importance changed from to
    by David Trasbo at 1:13 PM

    The ActiveSupport::Deprecation has native support for deprecating methods. I've attached a patch that makes use of that. Also, I propose not removing the test u...

4569 rake db:drop, db:create don't work was updated in Ruby on Rails
  • David Trasbo
    • Importance changed from to Low
    by David Trasbo at 10:49 AM

    Rohit,

    I think it might be to stop people from accidentally deleting production databases. It's not something I know, though.

2901 Increase error message output in boot.rb was updated in Ruby on Rails
  • David Trasbo
    David Trasbo commented at 10:44 AM

    I see your point, but basically: No, it can't. :)

    Sure, one of the dependencies (activesupport, actionpack, etc.) could be missing, but if the Rails gem itself ...

  • David Trasbo
    David Trasbo commented at 10:13 AM

    Definitely a good point. I've attached another patch that tells the user that the Rails gem is missing if that's the case, otherwise it simply re-raises the Gem...

4851 Remove require 'rake' from Rakefile? was updated in Ruby on Rails
  • David Trasbo
    • Assigned user set to José Valim
    by David Trasbo at 10:22 AM
Sunday, June 27 2010
2901 Increase error message output in boot.rb was updated in Ruby on Rails
  • David Trasbo
    • Assigned user set to José Valim
    • Importance changed from to
    by David Trasbo at 1:06 PM

    A better solution is to simply re-raise the Gem::LoadError. I've attached a patch that does just that.

    Other than that I definitely think it's a useful change. ...

4983 ActiveSupport Tests Failing was updated in Ruby on Rails
  • David Trasbo
    David Trasbo commented at 12:32 PM

    Ryan, just for your information: I assigned the ticket to you because I thought it could be closed.

    Which I still think it can, by the way. If the errors you're...