Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Andrew White's latest activity

Sunday, April 04 2010
2627 has_many :dependent => :delete_all throws exception on models in modules was updated in Ruby on Rails
  • Andrew White
    Andrew White commented at 1:32 AM

    Patch for 2-3-stable backporting changes from Carl's commits and adding tests from patch above

  • Andrew White
    Andrew White commented at 1:31 AM

    Patch for master adding tests for preventing regression.

Saturday, April 03 2010
4002 Subdomains constraits in routing don't work was updated in Ruby on Rails
  • Andrew White
    Andrew White commented at 6:07 PM

    Looks like Rack::Mount uses the method list of Rack::Request by default to validate condition keys. This can be overriden by passing in :request_class when the ...

2627 has_many :dependent => :delete_all throws exception on models in modules was updated in Ruby on Rails
  • Andrew White
    Andrew White commented at 5:00 PM

    Jeremy, that's because the compute type fix from from 2283 is needed. Carl's recent commit makes my patch on this ticket redundant, though it still needs back...

4311 Singular option unavailable in the new Routes was updated in Ruby on Rails
  • Andrew White
    Andrew White commented at 7:21 AM

    I saw it was missing the other day and thought about adding a patch, but I got the impression that the preferred method was to add a custom inflection.

    I'll add...

Wednesday, March 31 2010
2627 has_many :dependent => :delete_all throws exception on models in modules was updated in Ruby on Rails
  • Andrew White
    • Tag changed from active_record, dependent, has_many, module, review to active_record, dependent, has_many, module, patch, review
    • Assigned user set to Yehuda Katz (wycats)
    by Andrew White at 7:51 AM

    My patch for compute_type from 2283 is a necessary fix but some other changes are required as well. The attached patch provides those fixes and tests. The depe...

2283 Unnecessary exception raised in AS::Dependencies.load_missing_constant was updated in Ruby on Rails
  • Andrew White
    Andrew White commented at 3:13 AM

    Backport patch to 2-3-stable.

  • Andrew White
    Andrew White commented at 3:06 AM

    Updated patch with spelling fixed - somehow I managed to spell candidates wrong consistently.

Monday, March 29 2010
3987 Time.zone.today returns Date instead of ActiveSupport::TimeWithZone was updated in Ruby on Rails
4227 Wrong parsing paremeters with a semilocon ( ; ) char was updated in Ruby on Rails
  • Andrew White
    Andrew White commented at 10:20 AM

    Whether it's a poor choice is open for debate but it is a W3C recommendation that the semicolon is supported as a parameter separator:

    http://www.w3.org/TR/html...