Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Rolf Bjaanes's latest activity

Thursday, April 15 2010
4404 [PATCH] Remove deprecation warnings and avoid TypeErrors in actionpack/lib/ab... was updated in Ruby on Rails
  • Rolf Bjaanes
    Rolf Bjaanes commented at 2:19 PM

    Just reporting that this patch works for me on a project based on rails3 edge.

    Ran both controller/base_test.rb and my own cucumber tests which passed on previo...

Wednesday, April 14 2010
220 habtm: collection.build doesn't build join associations (unlike collection.cr... was updated in Ruby on Rails
  • Rolf Bjaanes
    Rolf Bjaanes commented at 6:35 PM

    Had a quick look at the gist, and this is not a bug.

    You are saving the instance of the associated object,
    but not the object carrying the association to be sav...

Tuesday, April 13 2010
4108 rails/jquery-ujs links broken in IE; patch attached was updated in Ruby on Rails
  • Rolf Bjaanes
    Rolf Bjaanes commented at 3:19 PM

    That should be :


    form = $('<form method="post" action="'+href+'"></form>')

    to be HTML 5 compliant. :)

  • Rolf Bjaanes
    Rolf Bjaanes commented at 3:17 PM

    This should be fixed, but it shouldn't say


    form = $('<form method="post" action="'+href+'" />')

    rather


    form = $('<form method="post" action="'+href+'">')

    to b...

Thursday, April 08 2010
3576 Inflections for uncountables works badly for "funky jeans" was updated in Ruby on Rails
  • Rolf Bjaanes
    Rolf Bjaanes commented at 9:07 PM

    A bit later than expected, but here it is.
    Patch with tests attached.

Monday, April 05 2010
3576 Inflections for uncountables works badly for "funky jeans" was updated in Ruby on Rails
  • Rolf Bjaanes
    Rolf Bjaanes commented at 11:44 PM

    I'll find time for it tomorrow or the day after.
    Crazy busy changing apartments :)

    Thanks btw :)
    This feel good.

Saturday, April 03 2010
3576 Inflections for uncountables works badly for "funky jeans" was updated in Ruby on Rails
  • Rolf Bjaanes
    Rolf Bjaanes commented at 7:29 PM

    Oh, it said milestone 2.x

    Btw, I can't think of many cases other than "jeans" and "[put word here] jeans" it'll be applicable, but
    atleast it won't try to singu...

  • Rolf Bjaanes
    • Assigned user cleared.
    by Rolf Bjaanes at 7:13 PM

    No problems :)

    I see the same code is used / unpatched in master, so you might want to see if it should go there too?

  • Rolf Bjaanes
    Rolf Bjaanes commented at 6:44 PM

    Point wasn't adding the extra inflection itself, but that funky jeans was singularized to funky jean – which at the moment held true for any uncountable with ba...

4226 Possible bug with uncountable inflections and namedspace routes? was updated in Ruby on Rails
  • Rolf Bjaanes
    Rolf Bjaanes commented at 6:34 PM

    Uhm, seems as this is regarding uncountables with two or more words in them, might be wrong.