Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Andrea Campi's latest activity

Saturday, October 16 2010
4346 time_select not interpreting the multi-parameter correctly was updated in Ruby on Rails
  • Andrea Campi
    • Tag changed from errors, helpers, patch, time_select to errors, helpers, milestone:3.x, patch, time_select
    by Andrea Campi at 8:15 PM
  • Andrea Campi
    Andrea Campi commented at 8:13 PM

    +1 to this version, thanks for cleaning it up :)

    You should probably rebase the two commit together, just for clarity, but that's just me. Nice work regardless.

Friday, October 15 2010
4346 time_select not interpreting the multi-parameter correctly was updated in Ruby on Rails
  • Andrea Campi
    Andrea Campi commented at 8:13 AM

    Your patch makes sense if we want to implicitly accept a missing part of a multiparameter and interpret it just the same as if it where empty.

    In other words, s...

Wednesday, October 13 2010
4346 time_select not interpreting the multi-parameter correctly was updated in Ruby on Rails
  • Andrea Campi
    Andrea Campi commented at 10:47 PM

    Good point. I'll give that I try.

  • Andrea Campi
    Andrea Campi commented at 4:32 PM

    Aditya: here is my current patch (not in git format-patch yet), as you can see it's pretty similar in principle to yours :)

    I want to go over it once more, beca...

  • Andrea Campi
    • Tag changed from errors, helpers, patch, security, time_select to errors, helpers, patch, time_select
    by Andrea Campi at 8:08 AM

    (and just after I press update--sorry for following up on myself)

    Maybe considering this a security issue is a bit of a stretch, as any web application trusting...

  • Andrea Campi
    • Tag changed from errors, helpers, patch, time_select to errors, helpers, patch, security, time_select
    by Andrea Campi at 7:58 AM

    Note this applies to edge too (just verified), so the milestone should be reset accordingly.

    My first hunch was to find a fix for the root issue, as an alternat...

Tuesday, October 12 2010
5777 Rails 3 Session Cookies and Render Calls was updated in Ruby on Rails
  • Andrea Campi
    Andrea Campi commented at 7:32 AM

    -1

    I think you misunderstood. The bug is that if you don't explicitly set a session value, the Set-Cookie header will not be present in the response when using ...
5772 Calling a model "Update" leads to unexpected behavior was updated in Ruby on Rails
  • Andrea Campi
    • Tag changed from activerecord, patch to 3.0, activerecord, edge, patch
    by Andrea Campi at 6:45 AM
  • Andrea Campi
    Andrea Campi commented at 6:44 AM

    In my patch, #instance_method_already_implemented? will raise an exception at load time, although that is not apparent from reading the patch.
    So in theory what...