Jeff Kreeftmeijer
programmer · Member of 1 project: Ruby on Rails
Jeff Kreeftmeijer's latest activity
Tuesday, March 01 2011
-
- State changed from open to verified
- Assigned user set to Santiago Pastorino
Verified. The patch I posted was Lars' patch in which I removed some whitespace, I'm not verifying my own. ;)
The patch applies cleanly to master and nicely rem...
Monday, February 28 2011
-
- State changed from open to verified
Verified. The patch applies to master and the provided test fails without it. :)
-
- State changed from new to needs-more-info
- Assigned user set to Jeff Kreeftmeijer
Sorry, in my last comment I previously confirmed the issue, but I was doing something wrong. I can't reproduce this issue and I updated my last comment.
Can any...
-
- State changed from new to open
- Importance changed from to Low
I couldn't reproduce this issue on master or 3.0.4:
# app/models/user.rb class User < ActiveRecord::Base validates :email, :presence => true #validates :n...
-
- State changed from new to verified
- Assigned user set to Santiago Pastorino
- Importance changed from to Low
Verified. Patch applies to master cleanly and tests pass. Test is good and fails without the fix. :)
We might want to push this one to stable too. Santiago, wha...
-
- State changed from new to verified
- Assigned user set to Santiago Pastorino
- Importance changed from to Low
Verified. The added test fails (raising a
NameErrorbecausesuperclassis undefined) without the patch. Thanks Josep! :)
-
- State changed from new to verified
- Assigned user set to Santiago Pastorino
- Importance changed from to Low
Verified. Applies cleanly to master and test pass.
test_loopinginordered_options_test(https://github.com/rails/rails/blob/master/activesupport/test/order...)...
Sunday, February 27 2011
-
- State changed from new to duplicate
- Importance changed from to Low
Closing this one as it's a duplicate of #6481.
-
- State changed from new to open
- Assigned user changed from Jeff Kreeftmeijer to Santiago Pastorino
After discussing with José, it turned out testing this would be difficult and result in a brittle test:
(07:44:10 PM) José Valim: there is no need to test it (...