Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Jeff Kreeftmeijer's latest activity

Tuesday, March 01 2011
5901 suppress the generation of the authenticity_token div was updated in Ruby on Rails
  • Jeff Kreeftmeijer
    • State changed from open to verified
    • Assigned user set to Santiago Pastorino
    by Jeff Kreeftmeijer at 11:29 AM

    Verified. The patch I posted was Lars' patch in which I removed some whitespace, I'm not verifying my own. ;)

    The patch applies cleanly to master and nicely rem...

Monday, February 28 2011
6379 accept header with */* does not match html templates was updated in Ruby on Rails
  • Jeff Kreeftmeijer
    • State changed from open to verified
    by Jeff Kreeftmeijer at 11:43 PM

    Verified. The patch applies to master and the provided test fails without it. :)

6447 reload! doesn't reload was updated in Ruby on Rails
  • Jeff Kreeftmeijer
    • State changed from new to needs-more-info
    • Assigned user set to Jeff Kreeftmeijer
    by Jeff Kreeftmeijer at 9:02 PM

    Sorry, in my last comment I previously confirmed the issue, but I was doing something wrong. I can't reproduce this issue and I updated my last comment.

    Can any...

  • Jeff Kreeftmeijer
    • State changed from new to open
    • Importance changed from to Low
    by Jeff Kreeftmeijer at 8:17 PM

    I couldn't reproduce this issue on master or 3.0.4:

    # app/models/user.rb
    
    class User < ActiveRecord::Base
      validates :email, :presence => true
      #validates :n...
6480 Action cache filter code incorrectly renders nil response body if response is... was updated in Ruby on Rails
  • Jeff Kreeftmeijer
    • State changed from new to verified
    • Assigned user set to Santiago Pastorino
    • Importance changed from to Low
    by Jeff Kreeftmeijer at 4:21 PM

    Verified. Patch applies to master cleanly and tests pass. Test is good and fails without the fix. :)

    We might want to push this one to stable too. Santiago, wha...

6486 Make ActiveSupport::Configurable work with Modules was updated in Ruby on Rails
  • Jeff Kreeftmeijer
    • State changed from new to verified
    • Assigned user set to Santiago Pastorino
    • Importance changed from to Low
    by Jeff Kreeftmeijer at 2:35 PM

    Verified. The added test fails (raising a NameError because superclass is undefined) without the patch. Thanks Josep! :)

6484 Ignore test/tmp folder created by ActiveSupport tests was updated in Ruby on Rails
6483 ActiveSupport::OrderedOptions calls to_sym redundantly was updated in Ruby on Rails
Sunday, February 27 2011
6482 ActiveRecord: PostgreSQL floats returned as Strings; SQLite floats returned a... was updated in Ruby on Rails
  • Jeff Kreeftmeijer
    • State changed from new to duplicate
    • Importance changed from to Low
    by Jeff Kreeftmeijer at 7:28 PM

    Closing this one as it's a duplicate of #6481.

6431 Thor LoadError message should not output --dev twice was updated in Ruby on Rails
  • Jeff Kreeftmeijer
    • State changed from new to open
    • Assigned user changed from Jeff Kreeftmeijer to Santiago Pastorino
    by Jeff Kreeftmeijer at 6:55 PM

    After discussing with José, it turned out testing this would be difficult and result in a brittle test:

    (07:44:10 PM) José Valim: there is no need to test it
    (...