Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Diego Algorta's latest activity

Tuesday, May 11 2010
2896 collection_singular_ids breaks when used with :include was updated in Ruby on Rails
  • Diego Algorta
    Diego Algorta commented at 7:25 PM

    As there where too many patch files already, I deleted the ones which were mine and I'm submitting them merged in just 2 files.

    • 1-new_failing_test.diff adds a ...
  • Diego Algorta
    Diego Algorta commented at 12:47 AM
  • Diego Algorta
    Diego Algorta commented at 12:36 AM

    I forgot to include one file in the test patch, So I'm attaching a new commit with the missing file.

Monday, May 10 2010
2896 collection_singular_ids breaks when used with :include was updated in Ruby on Rails
  • Diego Algorta
    • Assigned user set to Jeremy Kemper
    by Diego Algorta at 9:27 AM

    I'm attaching two separate patches in case the core team doesn't like my fix, or someone shows up with a better one (which is quite possible).

    add_failing_singu...

4556 When using conditional layouts, actions fallback to parent layout was updated in Ruby on Rails
  • Diego Algorta
    • Tag set to patch
    by Diego Algorta at 6:03 AM

    Applied patch over ce5827ea4791e8b8143919ecceb0231e36e8932e (master from today) and actionpack's tests all pass.

    +1

    I'm attaching an optional patch to apply ove...

Monday, November 23 2009
3472 AssociationCollection#include? ignoring build associated objects was updated in Ruby on Rails
Thursday, July 09 2009
2896 collection_singular_ids breaks when used with :include was created in Ruby on Rails
  • Diego Algorta
    Diego Algorta created the ticket at 9:30 PM

    Given a has_many association defined with an :include option, you can't use the #collection_singular_ids method because it fails trying to eager load the 2nd le...

Friday, February 20 2009
1677 Association proxies using class methods with named scopes was updated in Ruby on Rails
1960 Make named_scopes remember the current scope when defined was updated in Ruby on Rails
  • Diego Algorta
    Diego Algorta commented at 1:45 PM

    Yes. This patch should fix #1677 too. It's the same problem.

Tuesday, February 17 2009
1770 Backtracking association proxy chained methods was updated in Ruby on Rails
  • Diego Algorta
    Diego Algorta commented at 6:37 PM

    Maybe you'd like to test if the patch in #1960 fixes this problem? Haven't had the time to test your diff there.