85 3 true 2009-02-26T09:59:54+00:00 5639 2009-01-31T00:00:00+00:00 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 2 8994 resolved activeresource activesupport patch verified xml 2009-03-12T17:07:57+00:00 85 Jeremy Kemper Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 The XMLmini implementation now switches between a LibXML or REXML implementation, depending on weather the LibXML library is available. As the implementation of the XMLmini is now separated out, it is very easy to implement Nokogiri or JREXML. The speed increase is quite stunning (up to 10 times as fast, probably more for large XML files). The XMLmini implementation now switches between a LibXML or REXML implementation, depending on weather the LibXML library is available. As the implementation of the XMLmini is now separated out, it is very easy to implement Nokogiri or JREXML. The speed increase is quite stunning (up to 10 times as fast, probably more for large XML files). <div><p>The XMLmini implementation now switches between a LibXML or REXML implementation, depending on weather the LibXML library is available. As the implementation of the XMLmini is now separated out, it is very easy to implement Nokogiri or JREXML. The speed increase is quite stunning (up to 10 times as fast, probably more for large XML files).</p></div> 85 0 The XMLmini implementation now switches between a LibXML or REXML implementation, depending on weather the LibXML library is available. As the implementation of the XMLmini is now separated out, it is very easy to implement Nokogiri or JREXML. The speed increase is quite stunning (up to 10 times as fast, probably more for large XML files). It falls back to the old ruby implementation (REXML) if no other parsers are available. <div><p>The XMLmini implementation now switches between a LibXML or REXML implementation, depending on weather the LibXML library is available. As the implementation of the XMLmini is now separated out, it is very easy to implement Nokogiri or JREXML. The speed increase is quite stunning (up to 10 times as fast, probably more for large XML files).</p> <p>It falls back to the old ruby implementation (REXML) if no other parsers are available.</p></div> false 2009-02-26T09:59:54+00:00 5639 --- {} 9903 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 new activeresource activesupport patch xml 2009-02-26T10:03:52+00:00 5639 Bart ten Brinke Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 2.x 85 1 Really great! +1 Just noticed that the patch file contains two patches: [PATCH] Added deflate, gzip support to active resource And: [PATCH] xml mini libxml support I think you want to send just the second one! Cheers! <div><p>Really great! +1 Just noticed that the patch file contains two patches:</p> <p>[PATCH] Added deflate, gzip support to active resource</p> <p>And:</p> <p>[PATCH] xml mini libxml support</p> <p>I think you want to send just the second one!</p> <p>Cheers!</p></div> false 2009-02-26T12:42:16+00:00 5639 --- {} 9903 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 new activeresource activesupport patch xml 2009-02-26T12:42:20+00:00 19965 José Valim Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 2.x 85 1 +1 <div><p>+1</p></div> false 2009-02-26T13:23:47+00:00 5639 --- {} 9903 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 new activeresource activesupport patch xml 2009-02-26T13:23:50+00:00 13626 Alex Coles Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 2.x 85 1 Sorry, squashed the correct tickets into a new diff. <div><p>Sorry, squashed the correct tickets into a new diff.</p></div> false 2009-02-26T13:26:32+00:00 5639 --- {} 9903 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 new activeresource activesupport patch xml 2009-02-26T13:26:33+00:00 5639 Bart ten Brinke Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 2.x 85 1 +1, this would be really helpful for our API needs as well. <div><p>+1, this would be really helpful for our API needs as well.</p></div> false 2009-02-26T13:30:15+00:00 5639 --- {} 9903 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 new activeresource activesupport patch xml 2009-02-26T13:30:17+00:00 20779 Willem van Bergen Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 2.x 85 1 I'd be nice to be able to choose between the different parsers rather than just relying on the presence of libxml, though that'd be a sensible default. Also, the new non-derivative work code (your changes) shouldn't have the copyright header as they can safely be MIT licensed. <div><p>I'd be nice to be able to choose between the different parsers rather than just relying on the presence of libxml, though that'd be a sensible default.</p> <p>Also, the new non-derivative work code (your changes) shouldn't have the copyright header as they can safely be MIT licensed.</p></div> false 2009-03-02T05:49:00+00:00 5639 --- :tag: activeresource activesupport patch xml 9903 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 new activeresource activesupport patch verified xml 2009-03-02T05:49:01+00:00 141 Michael Koziarski Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 2.x 85 1 Also, how would you suggest the jruby guys could plug in an alternative implementation with this patch? Could be a good thought experiment to make sure the modularity works. <div><p>Also, how would you suggest the jruby guys could plug in an alternative implementation with this patch? Could be a good thought experiment to make sure the modularity works.</p></div> false 2009-03-02T05:49:50+00:00 5639 --- {} 9903 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 new activeresource activesupport patch verified xml 2009-03-02T05:49:53+00:00 141 Michael Koziarski Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 2.x 85 1 Well, the selection code currently is located in the XMLmini Module. You could easily have a fall through there, but I could also set something up like a hook. Which would you prefer? <div><p>Well, the selection code currently is located in the XMLmini Module. You could easily have a fall through there, but I could also set something up like a hook. Which would you prefer?</p></div> false 2009-03-03T21:08:42+00:00 5639 --- {} 9903 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 new activeresource activesupport patch verified xml 2009-03-03T21:08:44+00:00 5639 Bart ten Brinke Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 2.x 85 1 Let me rephrase that, as editing my comment seems to be impossible. This should be viewed as the base for alternative XML to hash parser implementations. XMLMini will be the front end and all alternative parsers should just implement ActiveSupport::XmlMini.parse In the future alternative parsers can be added to Rails core (and placed in the xml_mini sub folder). XMLmini can then implement a fall through that will decide which implementation is available. In the mean time people can write their own mixin in config/initializers that implements XmlMini.parse. The JRuby/Nokogiri people can either do the mix in on require or have a special function like Nokogiri.enable_active_resource. If you have a better suggestion to do this, please post it or post an example. You are right about the licenses. I have attached a new diff in which they are removed. <div><p>Let me rephrase that, as editing my comment seems to be impossible. This should be viewed as the base for alternative XML to hash parser implementations. XMLMini will be the front end and all alternative parsers should just implement ActiveSupport::XmlMini.parse</p> <p>In the future alternative parsers can be added to Rails core (and placed in the xml_mini sub folder). XMLmini can then implement a fall through that will decide which implementation is available.</p> <p>In the mean time people can write their own mixin in config/initializers that implements XmlMini.parse. The JRuby/Nokogiri people can either do the mix in on require or have a special function like Nokogiri.enable_active_resource.</p> <p>If you have a better suggestion to do this, please post it or post an example.</p> <p>You are right about the licenses. I have attached a new diff in which they are removed.</p></div> false 2009-03-03T22:49:07+00:00 5639 --- {} 9903 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 new activeresource activesupport patch verified xml 2009-03-03T22:49:10+00:00 5639 Bart ten Brinke Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 2.x 85 2 (from [822c41d69d9228c9912d29ac45155d3a16bb5c50]) XmlMini supports different backend parsers, starting with libxml [#2084 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> http://github.com/rails/rails/commit/822c41d69d9228c9912d29ac45155d3a16bb5c50 <div><p>(from [822c41d69d9228c9912d29ac45155d3a16bb5c50]) XmlMini supports different backend parsers, starting with libxml</p> <p>[<a href="/projects/8994/tickets/2084" title="Ticket #2084">#2084</a> state:committed]</p> <p>Signed-off-by: Jeremy Kemper <a href="mailto:jeremy@bitsweat.net">jeremy@bitsweat.net</a> <a href="http://github.com/rails/rails/commit/822c41d69d9228c9912d29ac45155d3a16bb5c50"> http://github.com/rails/rails/co...</a></p></div> true 2009-03-08T20:42:51+00:00 5639 --- :state: new 9903 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 committed activeresource activesupport patch verified xml 2009-03-08T20:42:52+00:00 17393 Repository Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 2.x 85 2 I'm seeing *lots* of failures now with: @@@ test_serialization_of_nested_resource(FormatTest): NoMethodError: undefined method `default_keep_blanks=' for XML:Module @@@ Do we need an additional check on the version of libxml that's installed? This is with a stock ruby install from 10.5.6 <div><p>I'm seeing <em>lots</em> of failures now with:</p> <pre><code> test_serialization_of_nested_resource(FormatTest): NoMethodError: undefined method `default_keep_blanks=' for XML:Module </code></pre> <p>Do we need an additional check on the version of libxml that's installed? This is with a stock ruby install from 10.5.6</p></div> false 2009-03-09T08:08:42+00:00 5639 --- :state: committed :milestone: 9903 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 open activeresource activesupport patch verified xml 2009-03-09T08:08:44+00:00 141 Michael Koziarski Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 85 2 > Do we need an additional check on the version of libxml that's installed? This is with a stock ruby install from 10.5.6 Yes I think we do. The version that ships with OSX 10.5.x is 0.3.8.4, after installing 1.0.0 it works as expected. <div><blockquote> <p>Do we need an additional check on the version of libxml that's installed? This is with a stock ruby install from 10.5.6</p> </blockquote> <p>Yes I think we do. The version that ships with OSX 10.5.x is 0.3.8.4, after installing 1.0.0 it works as expected.</p></div> false 2009-03-09T09:31:18+00:00 5639 --- {} 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 open activeresource activesupport patch verified xml 2009-03-09T09:31:22+00:00 8406 Eloy Duran Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 85 2 I'm seeing a failure on a Debian box with libxml-ruby 1.0.0: @@@ Name: test_expansion_count_is_limited(QueryTest) Type: Failure Message: <RuntimeError> exception expected but was Class: <LibXML::XML::Error> Message: <"Fatal error: Detected an entity reference loop at :12."> ---Backtrace--- ./test/../lib/active_support/xml_mini/libxml.rb:16:in `parse' ./test/../lib/active_support/xml_mini/libxml.rb:16:in `parse' ./test/../lib/active_support/core_ext/hash/conversions.rb:153:in `from_xml' ./test/core_ext/hash_ext_test.rb:903:in `test_expansion_count_is_limited' ./test/core_ext/hash_ext_test.rb:887:in `test_expansion_count_is_limited' /usr/local/lib/ruby/gems/1.8/gems/mocha-0.9.5/lib/mocha/test_case_adapter.rb:69:in `__send__' /usr/local/lib/ruby/gems/1.8/gems/mocha-0.9.5/lib/mocha/test_case_adapter.rb:69:in `run' @@@ This is using the standard Rails CI setup with just a few changes (like installing libxml-ruby) so it's a pretty clean test environment. <div><p>I'm seeing a failure on a Debian box with libxml-ruby 1.0.0:</p> <pre><code> Name: test_expansion_count_is_limited(QueryTest) Type: Failure Message: &lt;RuntimeError&gt; exception expected but was Class: &lt;LibXML::XML::Error&gt; Message: &lt;&quot;Fatal error: Detected an entity reference loop at :12.&quot;&gt; ---Backtrace--- ./test/../lib/active_support/xml_mini/libxml.rb:16:in `parse' ./test/../lib/active_support/xml_mini/libxml.rb:16:in `parse' ./test/../lib/active_support/core_ext/hash/conversions.rb:153:in `from_xml' ./test/core_ext/hash_ext_test.rb:903:in `test_expansion_count_is_limited' ./test/core_ext/hash_ext_test.rb:887:in `test_expansion_count_is_limited' /usr/local/lib/ruby/gems/1.8/gems/mocha-0.9.5/lib/mocha/test_case_adapter.rb:69:in `__send__' /usr/local/lib/ruby/gems/1.8/gems/mocha-0.9.5/lib/mocha/test_case_adapter.rb:69:in `run' </code></pre> <p>This is using the standard Rails CI setup with just a few changes (like installing libxml-ruby) so it's a pretty clean test environment.</p></div> false 2009-03-09T12:37:37+00:00 5639 --- {} 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 open activeresource activesupport patch verified xml 2009-03-09T12:37:41+00:00 7211 Mike Gunderloy Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 85 2 Thats weird. How can the wrapper throw a different exception on Debian as on OSX? Currently I can't reproduce this because I had to send my Debian machine RMA :(. If I build fix, could you test it for me, Mike? <div><p>Thats weird. How can the wrapper throw a different exception on Debian as on OSX? Currently I can't reproduce this because I had to send my Debian machine RMA :(. If I build fix, could you test it for me, Mike?</p></div> false 2009-03-09T12:44:02+00:00 5639 --- {} 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 open activeresource activesupport patch verified xml 2009-03-09T12:44:06+00:00 5639 Bart ten Brinke Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 85 2 Sure. Probably best to post any proposed patch here as I've heard a couple other reports of failure on os x this morning. <div><p>Sure. Probably best to post any proposed patch here as I've heard a couple other reports of failure on os x this morning.</p></div> false 2009-03-09T12:58:52+00:00 5639 --- {} 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 open activeresource activesupport patch verified xml 2009-03-09T12:58:55+00:00 7211 Mike Gunderloy Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 85 2 Isn't that the libxml 1.0.0 version issue? <div><p>Isn't that the libxml 1.0.0 version issue?</p></div> false 2009-03-09T13:01:27+00:00 5639 --- {} 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 open activeresource activesupport patch verified xml 2009-03-09T13:01:35+00:00 5639 Bart ten Brinke Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 85 2 I am using 0.9.7 on OSX BTW. I thought I was default. My bad. <div><p>I am using 0.9.7 on OSX BTW. I thought I was default. My bad.</p></div> false 2009-03-09T13:53:57+00:00 5639 --- {} 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 open activeresource activesupport patch verified xml 2009-03-09T13:54:00+00:00 5639 Bart ten Brinke Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 85 2 It seems that libxml-ruby 1.0.0 is pretty broken on OSX. Well at least it gives me a segfault on the recursion test ([BUG] Bus Error). I will make the patch libxml 0.9.7 specific if I can, but at the moment I haven't really got a good idea as how to do that. <div><p>It seems that libxml-ruby 1.0.0 is pretty broken on OSX. Well at least it gives me a segfault on the recursion test ([BUG] Bus Error). I will make the patch libxml 0.9.7 specific if I can, but at the moment I haven't really got a good idea as how to do that.</p></div> false 2009-03-09T15:39:22+00:00 5639 --- {} 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 open activeresource activesupport patch verified xml 2009-03-09T15:39:26+00:00 5639 Bart ten Brinke Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 85 2 Seems like patch that ends up needing to target one specific version of the library should probably just be reverted until things are stabilized. <div><p>Seems like patch that ends up needing to target one specific version of the library should probably just be reverted until things are stabilized.</p></div> false 2009-03-09T15:47:46+00:00 5639 --- {} 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 open activeresource activesupport patch verified xml 2009-03-09T15:47:51+00:00 7211 Mike Gunderloy Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 85 2 I would think 1.0 would be stabilized :X. I think we should keep the XMLmini and rexml separation, but drop the LibXML implementation. It would be a shame as it really is a LOT faster. <div><p>I would think 1.0 would be stabilized :X. I think we should keep the XMLmini and rexml separation, but drop the LibXML implementation. It would be a shame as it really is a LOT faster.</p></div> false 2009-03-09T15:59:18+00:00 5639 --- {} 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 open activeresource activesupport patch verified xml 2009-03-09T15:59:21+00:00 5639 Bart ten Brinke Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 85 2 This limits it to libxml 0.9.4 and 0.9.7. Could you check it, Mike? <div><p>This limits it to libxml 0.9.4 and 0.9.7. Could you check it, Mike?</p></div> false 2009-03-09T16:12:26+00:00 5639 --- {} 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 open activeresource activesupport patch verified xml 2009-03-09T16:12:29+00:00 5639 Bart ten Brinke Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 85 3 I really feel strongly about the fact that ActiveResource needs a fast XML parser if it is to be considered as an option in any real world application. <div><p>I really feel strongly about the fact that ActiveResource needs a fast XML parser if it is to be considered as an option in any real world application.</p></div> false 2009-03-09T20:00:25+00:00 5639 --- {} 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 open activeresource activesupport patch verified xml 2009-03-09T20:00:28+00:00 5639 Bart ten Brinke Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 85 3 We could just adjust the defaults to always be rexml. Then let people do something like XmlMini.parser=:libxml to switch to the libxml implementation. As for the test failure for the ci box, that's actually fine. the test is really just meant to be testing "won't die when passed a loop" so the fact that libxml is raising a different error, is no big thing. Just need to adjust the test. <div><p>We could just adjust the defaults to always be rexml. Then let people do something like XmlMini.parser=:libxml to switch to the libxml implementation.</p> <p>As for the test failure for the ci box, that's actually fine. the test is really just meant to be testing "won't die when passed a loop" so the fact that libxml is raising a different error, is no big thing. Just need to adjust the test.</p></div> false 2009-03-09T20:05:44+00:00 5639 --- {} 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 open activeresource activesupport patch verified xml 2009-03-09T20:05:45+00:00 141 Michael Koziarski Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 85 3 You misunderstood. It raises something else in Debian 1.0.0, which is fine, but it segfaults in OSX, which is NOT fine. Wow, Jeremy fixed everything perfectly: http://github.com/rails/rails/commit/87d82ef76e88d7ce97cfc09151b677b552f2840a Nice work! <div><p>You misunderstood. It raises something else in Debian 1.0.0, which is fine, but it segfaults in OSX, which is NOT fine.</p> <p>Wow, Jeremy fixed everything perfectly: <a href="http://github.com/rails/rails/commit/87d82ef76e88d7ce97cfc09151b677b552f2840a"> http://github.com/rails/rails/co...</a></p> <p>Nice work!</p></div> false 2009-03-09T20:15:39+00:00 5639 --- {} 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 open activeresource activesupport patch verified xml 2009-03-09T20:15:41+00:00 5639 Bart ten Brinke Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 85 3 He has a habit of doing that :) If it's only our million-laughs test that causes a segfault, perhaps that should be included in a test case to upstream? Or are there additional cases which segfault? <div><p>He has a habit of doing that :)</p> <p>If it's only our million-laughs test that causes a segfault, perhaps that should be included in a test case to upstream? Or are there additional cases which segfault?</p></div> false 2009-03-09T20:18:14+00:00 5639 --- {} 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 open activeresource activesupport patch verified xml 2009-03-09T20:18:20+00:00 141 Michael Koziarski Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 85 3 His fix however, is not working in my environment: ruby script/console Loading development environment (Rails 2.3.1) >> gem 'libxml-ruby', '=0.9.4', '=0.9.7' Gem::LoadError: RubyGem version error: libxml-ruby(0.9.4 not = 0.9.4, = 0.9.7) >> Gem.loaded_specs['libxml-ruby'].version.version => "0.9.7" <div><p>His fix however, is not working in my environment:</p> <p>ruby script/console Loading development environment (Rails 2.3.1)</p> <p>&gt;&gt; gem 'libxml-ruby', '=0.9.4', '=0.9.7' Gem::LoadError: RubyGem version error: libxml-ruby(0.9.4 not = 0.9.4, = 0.9.7)</p> <p>&gt;&gt; Gem.loaded_specs['libxml-ruby'].version.version =&gt; "0.9.7"</p></div> false 2009-03-09T20:29:52+00:00 5639 --- {} 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 open activeresource activesupport patch verified xml 2009-03-09T20:29:56+00:00 5639 Bart ten Brinke Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 85 3 What version of rubygems? <div><p>What version of rubygems?</p></div> false 2009-03-09T20:36:38+00:00 5639 --- {} 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 open activeresource activesupport patch verified xml 2009-03-09T20:36:42+00:00 85 Jeremy Kemper Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 85 3 1.3.1 <div><p>1.3.1</p></div> false 2009-03-09T20:41:02+00:00 5639 --- {} 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 open activeresource activesupport patch verified xml 2009-03-09T20:41:04+00:00 5639 Bart ten Brinke Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 85 3 http://github.com/rails/rails/commit/4458edc882b229ea44602da20a6440a6f233f1c8 <div><p><a href="http://github.com/rails/rails/commit/4458edc882b229ea44602da20a6440a6f233f1c8"> http://github.com/rails/rails/co...</a></p></div> true 2009-03-09T20:44:26+00:00 5639 --- :state: open 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 resolved activeresource activesupport patch verified xml 2009-03-09T20:44:27+00:00 85 Jeremy Kemper Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 85 3 That probably is the best solution :). Nice! <div><p>That probably is the best solution :). Nice!</p></div> true 2009-03-09T20:56:01+00:00 5639 --- {} 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 resolved activeresource activesupport patch verified xml 2009-03-09T20:56:04+00:00 5639 Bart ten Brinke Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 85 3 The delegation seems to break if you switch it to libxml :( <div><p>The delegation seems to break if you switch it to libxml :(</p></div> true 2009-03-09T21:04:11+00:00 5639 --- {} 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 resolved activeresource activesupport patch verified xml 2009-03-09T21:04:15+00:00 5639 Bart ten Brinke Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 85 3 E(__DELEGATION__):2: warning: instance variable @backend not initialized. The libxml.rb does not return to the Xml_mini.rb flow after the mixin. I have no clue why not. <div><p>E(<strong>DELEGATION</strong>):2: warning: instance variable @backend not initialized. The libxml.rb does not return to the Xml_mini.rb flow after the mixin. I have no clue why not.</p></div> true 2009-03-10T07:35:58+00:00 5639 --- {} 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 resolved activeresource activesupport patch verified xml 2009-03-10T07:36:04+00:00 5639 Bart ten Brinke Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 85 3 (from [d4091d3bc79731f55491cfb51c604a66502c944f]) Properly set up libxml includes. Don't include LibXML in toplevel. [#2084 state:resolved] http://github.com/rails/rails/commit/d4091d3bc79731f55491cfb51c604a66502c944f <div><p>(from [d4091d3bc79731f55491cfb51c604a66502c944f]) Properly set up libxml includes. Don't include LibXML in toplevel.</p> <p>[<a href="/projects/8994/tickets/2084" title="Ticket #2084">#2084</a> state:resolved] <a href="http://github.com/rails/rails/commit/d4091d3bc79731f55491cfb51c604a66502c944f"> http://github.com/rails/rails/co...</a></p></div> true 2009-03-10T18:58:02+00:00 5639 --- {} 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 resolved activeresource activesupport patch verified xml 2009-03-10T19:02:39+00:00 17393 Repository Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 85 3 Hey guys, Integrating libxml-ruby bindings in Rails would be great. But you positively, absolutely want to use libxml 1.1.1 and higher. Its the first version that works with ruby 1.9.1 and compiles cleanly on OS X. Let me know if you run into any issues and we'll get them cleaned up on our side. Charlie Savage (maintainer libxml-ruby). <div><p>Hey guys,</p> <p>Integrating libxml-ruby bindings in Rails would be great. But you positively, absolutely want to use libxml 1.1.1 and higher. Its the first version that works with ruby 1.9.1 and compiles cleanly on OS X. Let me know if you run into any issues and we'll get them cleaned up on our side.</p> <p>Charlie Savage (maintainer libxml-ruby).</p></div> true 2009-03-12T16:52:27+00:00 5639 --- {} 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 resolved activeresource activesupport patch verified xml 2009-03-12T16:52:32+00:00 50347 cfis (at savagexi) Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 85 3 Hey Charlie, was 1.1.1 just released? The latest release segfaulted. 0.9.7 works and compiles fine on OSX (though not on 1.9). <div><p>Hey Charlie, was 1.1.1 just released? The latest release segfaulted. 0.9.7 works and compiles fine on OSX (though not on 1.9).</p></div> true 2009-03-12T17:07:57+00:00 5639 --- {} 2084 alternative-xml-parsers-support-in-activesupport-for-activeresource 0 8994 resolved activeresource activesupport patch verified xml 2009-03-12T17:07:57+00:00 85 Jeremy Kemper Bart ten Brinke Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2084 3e0604ccea57c64bebfac9188adb0ea85569e9c4 text/plain 2009-02-26T13:26:32+00:00 alternative-xml-parsers.diff 93324 11280 5639 http://rails.lighthouseapp.com/attachments/93324/alternative-xml-parsers.diff 3d7200c5cc55c41d65f169dfe737ae3868ffb399 text/plain 2009-03-03T22:49:07+00:00 alternative-xml-parsers.diff 95557 11880 5639 http://rails.lighthouseapp.com/attachments/95557/alternative-xml-parsers.diff 8a6365fa41889951fef58983b60cf20065a0b45f text/plain 2009-03-09T16:12:26+00:00 alternative_xml_parser_fix.diff 97560 1149 5639 http://rails.lighthouseapp.com/attachments/97560/alternative_xml_parser_fix.diff