Allow if option for caches_page
Reported by Paul Horsfall | April 19th, 2008 @ 01:35 PM
This is a patch to allow an if option to be passed to caches_page, much as you can for session management. e.g.
caches_page :index, :if => Proc.new { |c| !c.request.format.json? }
I've included a test, and split the call to caches_page in the test controller into two, so that caches_page is called with and without an if option.
I've also moved the test for whether an action should be cached out of the block passed to after_filter, and instead pass the actions we want caching to after_filter via the only option.
Comments and changes to this ticket
-
Joshua Peek April 19th, 2008 @ 03:27 PM
- → State changed from “new” to “open”
- → Assigned user changed from “” to “Joshua Peek”
-
Repository April 19th, 2008 @ 04:21 PM
- → State changed from “open” to “resolved”
(from [14a40804a29a57ad05ca6bffbe1e5334089593a9]) Add conditional options to caches_page method [#25 state:resolved]
Signed-off-by: Joshua Peek
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
The latest development for the 1.2.x and 2.0.x releases are on the 1-2-stable and 2-0-stable branches.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
