424 2 true 2008-04-16T17:54:32+01:00 5965 9 adding-records-to-a-has_many-collection-does-not-work-on-initialization 10897 8994 resolved activerecord patch 2008-05-08T06:07:14+01:00 17393 Repository Andreas Neuhaus Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/9 (from Trac http://dev.rubyonrails.org/ticket/9577. As far as I know, this is still an issue) @@@ ruby class User < AR:Base has_many :email_addresses def email= (address) email_addresses.build(:address => address) end end class EmailAddress < AR:Base belongs_to :user end @@@ I use User#email= to create an initial email address record for each user created. It works fine, except if you access User#email_addresses on non-saved user records: @@@ ruby # Works fine (creates user record and associated email address record): User.create!(:username=>'foo', :email=>'foo@bar.baz') # Also works fine: u = User.new(:username=>'foo', :email=>'foo@bar.baz') u.save! # Does NOT work (user record saved, email address record lost): u = User.new(:username=>'foo', :email=>'foo@bar.baz') u.email_addresses # => [] u.save! @@@ Is this a bug or intended behaviour? It looks like the has_many collection cache does not recognize associated objects that are build during initialization. minaguib suggested a temp workaround: @@@ ruby def email= (address) email_addresses(true) unless email_addresses.loaded? # Temp fix for for rails bug #9577 email_addresses.build(:address => address) end @@@ Some more info in my "blog":http://zargony.com/2007/09/17/vanishing-records-on-creating-multiple-models-in-one-action (from Trac http://dev.rubyonrails.org/ticket/9577. As far as I know, this is still an issue) @@@ ruby class User < AR:Base has_many :email_addresses def email= (address) email_addresses.build(:address => address) end end class EmailAddress < AR:Base belongs_to :user end @@@ I use User#email= to create an initial email address record for each user created. It works fine, except if you access User#email_addresses on non-saved user records: @@@ ruby # Works fine (creates user record and associated email address record): User.create!(:username=>'foo', :email=>'foo@bar.baz') # Also works fine: u = User.new(:username=>'foo', :email=>'foo@bar.baz') u.save! # Does NOT work (user record saved, email address record lost): u = User.new(:username=>'foo', :email=>'foo@bar.baz') u.email_addresses # => [] u.save! @@@ Is this a bug or intended behaviour? It looks like the has_many collection cache does not recognize associated objects that are build during initialization. minaguib suggested a temp workaround: @@@ ruby def email= (address) email_addresses(true) unless email_addresses.loaded? # Temp fix for for rails bug #9577 email_addresses.build(:address => address) end @@@ Some more info in my "blog":http://zargony.com/2007/09/17/vanishing-records-on-creating-multiple-models-in-one-action <div><p> (from Trac <a href="http://dev.rubyonrails.org/ticket/9577">http://dev.rubyonrails.org/ticke...</a>. As far as I know, this is still an issue) </p> <pre><code class="ruby">class User &lt; AR:Base has_many :email_addresses def email= (address) email_addresses.build(:address =&gt; address) end end class EmailAddress &lt; AR:Base belongs_to :user end </code></pre> <p> I use User#email= to create an initial email address record for each user created. It works fine, except if you access User#email_addresses on non-saved user records: </p> <pre><code class="ruby"># Works fine (creates user record and associated email address record): User.create!(:username=&gt;'foo', :email=&gt;'<a href="mailto:foo@bar.baz">foo@bar.baz</a>') # Also works fine: u = User.new(:username=&gt;'foo', :email=&gt;'<a href="mailto:foo@bar.baz">foo@bar.baz</a>') u.save! # Does NOT work (user record saved, email address record lost): u = User.new(:username=&gt;'foo', :email=&gt;'<a href="mailto:foo@bar.baz">foo@bar.baz</a>') u.email_addresses # =&gt; [] u.save! </code></pre> <p> Is this a bug or intended behaviour? It looks like the has_many collection cache does not recognize associated objects that are build during initialization. </p><p> minaguib suggested a temp workaround: </p> <pre><code class="ruby"> def email= (address) email_addresses(true) unless email_addresses.loaded? # Temp fix for for rails bug <a href="/projects/8994/tickets/9577" title="Ticket #9577">#9577</a> email_addresses.build(:address =&gt; address) end </code></pre> <p> Some more info in my <a href="http://zargony.com/2007/09/17/vanishing-records-on-creating-multiple-models-in-one-action">blog</a> </p></div> 0 (from Trac http://dev.rubyonrails.org/ticket/9577. As far as I know, this is still an issue) @@@ ruby class User < AR:Base has_many :email_addresses def email= (address) email_addresses.build(:address => address) end end class EmailAddress < AR:Base belongs_to :user end @@@ I use User#email= to create an initial email address record for each user created. It works fine, except if you access User#email_addresses on non-saved user records: @@@ ruby # Works fine (creates user record and associated email address record): User.create!(:username=>'foo', :email=>'foo@bar.baz') # Also works fine: u = User.new(:username=>'foo', :email=>'foo@bar.baz') u.save! # Does NOT work (user record saved, email address record lost): u = User.new(:username=>'foo', :email=>'foo@bar.baz') u.email_addresses # => [] u.save! @@@ Is this a bug or intended behaviour? It looks like the has_many collection cache does not recognize associated objects that are build during initialization. minaguib suggested a temp workaround: @@@ ruby def email= (address) email_addresses(true) unless email_addresses.loaded? # Temp fix for for rails bug #9577 email_addresses.build(:address => address) end @@@ Some more info in my "blog":http://zargony.com/2007/09/17/vanishing-records-on-creating-multiple-models-in-one-action <div><p> (from Trac <a href="http://dev.rubyonrails.org/ticket/9577">http://dev.rubyonrails.org/ticke...</a>. As far as I know, this is still an issue) </p> <pre><code class="ruby">class User &lt; AR:Base has_many :email_addresses def email= (address) email_addresses.build(:address =&gt; address) end end class EmailAddress &lt; AR:Base belongs_to :user end </code></pre> <p> I use User#email= to create an initial email address record for each user created. It works fine, except if you access User#email_addresses on non-saved user records: </p> <pre><code class="ruby"># Works fine (creates user record and associated email address record): User.create!(:username=&gt;'foo', :email=&gt;'<a href="mailto:foo@bar.baz">foo@bar.baz</a>') # Also works fine: u = User.new(:username=&gt;'foo', :email=&gt;'<a href="mailto:foo@bar.baz">foo@bar.baz</a>') u.save! # Does NOT work (user record saved, email address record lost): u = User.new(:username=&gt;'foo', :email=&gt;'<a href="mailto:foo@bar.baz">foo@bar.baz</a>') u.email_addresses # =&gt; [] u.save! </code></pre> <p> Is this a bug or intended behaviour? It looks like the has_many collection cache does not recognize associated objects that are build during initialization. </p><p> minaguib suggested a temp workaround: </p> <pre><code class="ruby"> def email= (address) email_addresses(true) unless email_addresses.loaded? # Temp fix for for rails bug <a href="/projects/8994/tickets/9577" title="Ticket #9577">#9577</a> email_addresses.build(:address =&gt; address) end </code></pre> <p> Some more info in my <a href="http://zargony.com/2007/09/17/vanishing-records-on-creating-multiple-models-in-one-action">blog</a> </p></div> false 2008-04-16T17:54:32+01:00 5965 --- {} 9 adding-records-to-a-has_many-collection-does-not-work-on-initialization 0 8994 new 2008-04-16T17:54:32+01:00 5965 Andreas Neuhaus Andreas Neuhaus http://rails.lighthouseapp.com/projects/8994/tickets/9 424 0 I wrote up some ActiveRecord tests for it, however they are passing for me. Did you try this on edge? Or are my test cases not covering the same thing you are referring too? <div><p> I wrote up some ActiveRecord tests for it, however they are passing for me. Did you try this on edge? Or are my test cases not covering the same thing you are referring too? </p></div> false 2008-04-16T20:16:03+01:00 5965 --- :assigned_user: 9 adding-records-to-a-has_many-collection-does-not-work-on-initialization 0 8994 new 2008-04-16T20:16:03+01:00 424 Joshua Peek Andreas Neuhaus Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/9 424 1 false 2008-04-16T20:17:00+01:00 5965 --- :state: new 9 adding-records-to-a-has_many-collection-does-not-work-on-initialization 0 8994 open 2008-04-16T20:17:00+01:00 424 Joshua Peek Andreas Neuhaus Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/9 424 1 I've had a quick poke around with this and I can't seem to get a failing test either. However, I was able to replicate the problem in a Rails app using the exact models and code described by zargony. <div><p> I've had a quick poke around with this and I can't seem to get a failing test either. However, I was able to replicate the problem in a Rails app using the exact models and code described by zargony. </p></div> false 2008-04-16T22:43:21+01:00 5965 --- {} 9 adding-records-to-a-has_many-collection-does-not-work-on-initialization 0 8994 open 2008-04-16T22:43:21+01:00 993 Simon Jefford Andreas Neuhaus Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/9 424 1 I can only get this to happen inside script/console. Again, using the models described by Andreas, I ran the following using script/runner: @@@ ruby u = User.new(:username => 'foo', :email => 'foo@bar.baz') u.email_addresses u.save! puts u.email_addresses.first.address @@@ and got foo@bar.baz. <div><p> I can only get this to happen inside script/console. </p><p> Again, using the models described by Andreas, I ran the following using script/runner: </p> <pre><code class="ruby">u = User.new(:username =&gt; 'foo', :email =&gt; '<a href="mailto:foo@bar.baz">foo@bar.baz</a>') u.email_addresses u.save! puts u.email_addresses.first.address </code></pre> <p> and got </p><p> <a href="mailto:foo@bar.baz">foo@bar.baz</a>. </p></div> false 2008-04-17T13:36:12+01:00 5965 --- {} 9 adding-records-to-a-has_many-collection-does-not-work-on-initialization 0 8994 open 2008-04-17T13:36:12+01:00 993 Simon Jefford Andreas Neuhaus Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/9 424 1 Interestingly, the test also passes for me. But the bug still occurs when using the console of a project where I disabled the described workaround. Though I don't see why, there must be something wrong with the test. I'll do some more tests later today. <div><p> Interestingly, the test also passes for me. But the bug still occurs when using the console of a project where I disabled the described workaround. </p><p> Though I don't see why, there must be something wrong with the test. I'll do some more tests later today. </p></div> false 2008-04-17T14:37:50+01:00 5965 --- {} 9 adding-records-to-a-has_many-collection-does-not-work-on-initialization 0 8994 open 2008-04-17T14:37:50+01:00 5965 Andreas Neuhaus Andreas Neuhaus Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/9 424 1 Joshua: yes, I'm trying with rails edge pulled from git. The problem occurs, if you create an object of a model which builds associated objects during initialization. If you access these associated objects before saving the object itself, all associated objects are lost. I guess, that this problem might be related to the lazy-loading of an associated collection. If an object builds associated objects in its initializer, the association is still marked as loaded?==false; so on first access to the association proxy, it'll try to load the collection and wipes the ones built in memory. For some reason, it looks like accessing email_addresses.first is ok, but accessing email_addresses or doing email_addresses.inspect results in an empty array: @@@ >> u=User.new(:username=>'foo', :email=>'foo@bar.baz') => #<User id: nil, username: "foo", created_at: nil, updated_at: nil> >> u.email_addresses.loaded? => false >> u.email_addresses.first => #<EmailAddress id: nil, address: "foo@bar.baz", user_id: nil, created_at: nil, updated_at: nil> >> u.email_addresses.loaded? => true >> u.email_addresses => [#<EmailAddress id: nil, address: "foo@bar.baz", user_id: nil, created_at: nil, updated_at: nil>] >> ?> u=User.new(:username=>'foo', :email=>'foo@bar.baz') => #<User id: nil, username: "foo", created_at: nil, updated_at: nil> >> u.email_addresses.loaded? => false >> u.email_addresses => [] >> u.email_addresses.loaded? => true @@@ I can reproduce this with script/console and with script/runner, but for some reason not with a test... <div><p> Joshua: yes, I'm trying with rails edge pulled from git. </p><p> The problem occurs, if you create an object of a model which builds associated objects during initialization. If you access these associated objects before saving the object itself, all associated objects are lost. </p><p> I guess, that this problem might be related to the lazy-loading of an associated collection. If an object builds associated objects in its initializer, the association is still marked as loaded?==false; so on first access to the association proxy, it'll try to load the collection and wipes the ones built in memory. </p><p> For some reason, it looks like accessing email_addresses.first is ok, but accessing email_addresses or doing email_addresses.inspect results in an empty array: </p> <pre><code class="">&gt;&gt; u=User.new(:username=&gt;'foo', :email=&gt;'<a href="mailto:foo@bar.baz">foo@bar.baz</a>') =&gt; #&lt;User id: nil, username: &quot;foo&quot;, created_at: nil, updated_at: nil&gt; &gt;&gt; u.email_addresses.loaded? =&gt; false &gt;&gt; u.email_addresses.first =&gt; #&lt;EmailAddress id: nil, address: &quot;<a href="mailto:foo@bar.baz">foo@bar.baz</a>&quot;, user_id: nil, created_at: nil, updated_at: nil&gt; &gt;&gt; u.email_addresses.loaded? =&gt; true &gt;&gt; u.email_addresses =&gt; [#&lt;EmailAddress id: nil, address: &quot;<a href="mailto:foo@bar.baz">foo@bar.baz</a>&quot;, user_id: nil, created_at: nil, updated_at: nil&gt;] &gt;&gt; ?&gt; u=User.new(:username=&gt;'foo', :email=&gt;'<a href="mailto:foo@bar.baz">foo@bar.baz</a>') =&gt; #&lt;User id: nil, username: &quot;foo&quot;, created_at: nil, updated_at: nil&gt; &gt;&gt; u.email_addresses.loaded? =&gt; false &gt;&gt; u.email_addresses =&gt; [] &gt;&gt; u.email_addresses.loaded? =&gt; true </code></pre> <p> I can reproduce this with script/console and with script/runner, but for some reason not with a test... </p></div> false 2008-04-17T15:33:59+01:00 5965 --- {} 9 adding-records-to-a-has_many-collection-does-not-work-on-initialization 0 8994 open 2008-04-17T15:33:59+01:00 5965 Andreas Neuhaus Andreas Neuhaus Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/9 424 1 Please reopen this ticket once you've got some tests. <div><p> Please reopen this ticket once you've got some tests. </p></div> true 2008-04-19T22:38:36+01:00 5965 --- :state: open 9 adding-records-to-a-has_many-collection-does-not-work-on-initialization 0 8994 hold 2008-04-19T22:38:36+01:00 424 Joshua Peek Andreas Neuhaus Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/9 424 1 I think I finally tracked it down. It's the inspect method of AssociationProxy that does a reload if the target isn't loaded yet and therefore wipes the collection in this case. The console automatically does #inspect to display an object. That's why it always happened in the console but not in tests. I attached a patch that fixes this problem and adds a proper test. Unfortunately, I cannot reopen this ticket myself. <div><p> I think I finally tracked it down. It's the inspect method of AssociationProxy that does a reload if the target isn't loaded yet and therefore wipes the collection in this case. </p><p> The console automatically does #inspect to display an object. That's why it always happened in the console but not in tests. </p><p> I attached a patch that fixes this problem and adds a proper test. </p><p> Unfortunately, I cannot reopen this ticket myself. </p></div> true 2008-04-21T13:54:48+01:00 5965 --- {} 9 adding-records-to-a-has_many-collection-does-not-work-on-initialization 0 8994 hold 2008-04-21T13:54:48+01:00 5965 Andreas Neuhaus Andreas Neuhaus Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/9 424 2 false 2008-05-02T23:36:09+01:00 5965 --- :state: hold 9 adding-records-to-a-has_many-collection-does-not-work-on-initialization 0 8994 open 2008-05-02T23:36:09+01:00 141 Michael Koziarski Andreas Neuhaus Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/9 424 2 (from [bcb090c56b842a76397e0ea32f54c942fd11910e]) Calling ActiveRecord#inspect on an unloaded association won't wipe the collection [#9 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> http://github.com/rails/rails/commit/bcb090c56b842a76397e0ea32f54c942fd11910e <div><p> (from [bcb090c56b842a76397e0ea32f54c942fd11910e]) Calling ActiveRecord#inspect on an unloaded association won't wipe the collection [#9 state:resolved] </p><p> Signed-off-by: Joshua Peek </p><p> <a href="http://github.com/rails/rails/commit/bcb090c56b842a76397e0ea32f54c942fd11910e">http://github.com/rails/rails/co...</a> </p></div> true 2008-05-08T06:07:14+01:00 5965 --- :state: open 9 adding-records-to-a-has_many-collection-does-not-work-on-initialization 0 8994 resolved 2008-05-08T06:07:14+01:00 17393 Repository Andreas Neuhaus Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/9 bf40dfc5f9f44991b0579088fb6587e7a954b6b6 text/plain 2008-04-16T20:16:03+01:00 has_many_initialization_tests.diff 18881 1397 424 http://rails.lighthouseapp.com/attachments/18881/has_many_initialization_tests.diff 0fd409a1dd86b33ad68c2a71245e1d0dbc404230 text/plain 2008-04-21T13:54:48+01:00 0001-Inspect-on-a-not-yet-loaded-association-does-no-long.patch 19455 2273 5965 http://rails.lighthouseapp.com/attachments/19455/0001-Inspect-on-a-not-yet-loaded-association-does-no-long.patch