Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Regexp requirements for PathSegment broken

#1772

The following commit:

http://github.com/rails/rails/co...

broke regexp requirements for PathSegment in a subtle way. Firstly if a regexp is specified then its passed back to build_pattern as a Regexp rather than a String as is the case with DynamicSegment. Also the the regexp in routes.rb needs to be wrapped with parenthesis for it to work which it didn't in 2.1.

This fix probably needs to be back-ported to 2.2 as well - the attached patch currently applies cleanly to both edge and 2-2-stable.

Reported by Andrew White · January 16th, 2009 @ 09:58 AM

State: committed
Milestone: none
Assigned to: Michael Koziarski Michael Koziarski
Importance: none

Activity

  1. Michael Koziarski
    Michael Koziarski
    • Assigned user set to Michael Koziarski
    • Milestone cleared.

    February 7th, 2009 @ 10:14 PM

  2. Repository
    Repository
    • State changed from new to committed

    (from [3248553d3299cbb723f1b4103c16bad7ecdd24a6]) Fix requirements regexp for path segments

    Signed-off-by: Michael Koziarski michael@koziarski.com [#1772 Regexp requirements for PathSegment broken state:committed] http://github.com/rails/rails/co...

    February 22nd, 2009 @ 02:42 AM