424 2 true 2009-02-15T18:45:06+00:00 12845 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 1165 8994 resolved 2.3.2 patch 2009-06-01T22:44:55+01:00 11310 Andreas Korth Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x Originally posted this as a question to the rubyonrails-talk Google group: http://groups.google.com/group/rubyonrails-talk/browse_thread/thread/323ff7ec2d95ee32 Quoting from that message: Just updated to 2.3.0 RC1 and I'm finding that my sweepers are throwing NameErrors (uninitialized constant ActionController::Caching::Sweeper) when evaluation reaches lines like this one: @@@ class PostSweeper < ActionController::Caching::Sweeper @@@ This only happens in the development environment, because that's the only environment where I have "cache_classes" set to false. Relevant stack trace is: @@@ vendor/rails/activesupport/lib/active_support/dependencies.rb:440:in `load_missing_constant' vendor/rails/activesupport/lib/active_support/dependencies.rb:80:in `const_missing' app/sweepers/post_sweeper.rb:1 vendor/rails/activesupport/lib/active_support/dependencies.rb:380:in `load_without_new_constant_marking' vendor/rails/activesupport/lib/active_support/dependencies.rb:380:in `load_file' vendor/rails/activesupport/lib/active_support/dependencies.rb:521:in `new_constants_in' vendor/rails/activesupport/lib/active_support/dependencies.rb:379:in `load_file' vendor/rails/activesupport/lib/active_support/dependencies.rb:259:in `require_or_load' vendor/rails/activesupport/lib/active_support/dependencies.rb:425:in `load_missing_constant' vendor/rails/activesupport/lib/active_support/dependencies.rb:80:in `const_missing' vendor/rails/activesupport/lib/active_support/dependencies.rb:92:in `const_missing' vendor/rails/actionpack/lib/action_controller/caching/sweeping.rb:43:in `const_get' vendor/rails/actionpack/lib/action_controller/caching/sweeping.rb:43:in `cache_sweeper' vendor/rails/actionpack/lib/action_controller/caching/sweeping.rb:41:in `each' vendor/rails/actionpack/lib/action_controller/caching/sweeping.rb:41:in `cache_sweeper' app/controllers/posts_controller.rb:5 @@@ On further digging, I've narrowed things down to commit 31ce92f7b5784bc5b6a441e88cd734c7b8b1c58f, "Use autoload instead of explicit requires for ActionController". Basically, when: @@@ require 'action_controller/caching/sweeping' @@@ Was ripped out in favor of: @@@ autoload :Sweeping, 'action_controller/caching/sweeping' @@@ Things break because the constant in question is not actually "Sweeping" but "Sweeper" (see line 56 of "actionpack/lib/action_controller/caching/sweeping.rb"). I imagine the issue is relatively common because when you write a sweeper you do it with: @@@ class PostSweeper < ActionController::Caching::Sweeper @@@ And don't actually make reference to the "Sweeping" constant mentioned in the autoload line. The fix? Conservatively I guess the fix is to add another autoload line: @@@ autoload :Sweeper, 'action_controller/caching/sweeping' @@@ Alternatively, if you think that nobody actually uses the "Sweeping" module directly, then you could actually replace the existing autoload line with the above. Originally posted this as a question to the rubyonrails-talk Google group: http://groups.google.com/group/rubyonrails-talk/browse_thread/thread/323ff7ec2d95ee32 Quoting from that message: Just updated to 2.3.0 RC1 and I'm finding that my sweepers are throwing NameErrors (uninitialized constant ActionController::Caching::Sweeper) when evaluation reaches lines like this one: @@@ class PostSweeper < ActionController::Caching::Sweeper @@@ This only happens in the development environment, because that's the only environment where I have "cache_classes" set to false. Relevant stack trace is: @@@ vendor/rails/activesupport/lib/active_support/dependencies.rb:440:in `load_missing_constant' vendor/rails/activesupport/lib/active_support/dependencies.rb:80:in `const_missing' app/sweepers/post_sweeper.rb:1 vendor/rails/activesupport/lib/active_support/dependencies.rb:380:in `load_without_new_constant_marking' vendor/rails/activesupport/lib/active_support/dependencies.rb:380:in `load_file' vendor/rails/activesupport/lib/active_support/dependencies.rb:521:in `new_constants_in' vendor/rails/activesupport/lib/active_support/dependencies.rb:379:in `load_file' vendor/rails/activesupport/lib/active_support/dependencies.rb:259:in `require_or_load' vendor/rails/activesupport/lib/active_support/dependencies.rb:425:in `load_missing_constant' vendor/rails/activesupport/lib/active_support/dependencies.rb:80:in `const_missing' vendor/rails/activesupport/lib/active_support/dependencies.rb:92:in `const_missing' vendor/rails/actionpack/lib/action_controller/caching/sweeping.rb:43:in `const_get' vendor/rails/actionpack/lib/action_controller/caching/sweeping.rb:43:in `cache_sweeper' vendor/rails/actionpack/lib/action_controller/caching/sweeping.rb:41:in `each' vendor/rails/actionpack/lib/action_controller/caching/sweeping.rb:41:in `cache_sweeper' app/controllers/posts_controller.rb:5 @@@ On further digging, I've narrowed things down to commit 31ce92f7b5784bc5b6a441e88cd734c7b8b1c58f, "Use autoload instead of explicit requires for ActionController". Basically, when: @@@ require 'action_controller/caching/sweeping' @@@ Was ripped out in favor of: @@@ autoload :Sweeping, 'action_controller/caching/sweeping' @@@ Things break because the constant in question is not actually "Sweeping" but "Sweeper" (see line 56 of "actionpack/lib/action_controller/caching/sweeping.rb"). I imagine the issue is relatively common because when you write a sweeper you do it with: @@@ class PostSweeper < ActionController::Caching::Sweeper @@@ And don't actually make reference to the "Sweeping" constant mentioned in the autoload line. The fix? Conservatively I guess the fix is to add another autoload line: @@@ autoload :Sweeper, 'action_controller/caching/sweeping' @@@ Alternatively, if you think that nobody actually uses the "Sweeping" module directly, then you could actually replace the existing autoload line with the above. <div><p>Originally posted this as a question to the rubyonrails-talk Google group:</p> <p><a href="http://groups.google.com/group/rubyonrails-talk/browse_thread/thread/323ff7ec2d95ee32"> http://groups.google.com/group/r...</a></p> <p>Quoting from that message:</p> <p>Just updated to 2.3.0 RC1 and I'm finding that my sweepers are throwing NameErrors (uninitialized constant ActionController::Caching::Sweeper) when evaluation reaches lines like this one:</p> <pre><code> class PostSweeper &lt; ActionController::Caching::Sweeper </code></pre> <p>This only happens in the development environment, because that's the only environment where I have "cache_classes" set to false. Relevant stack trace is:</p> <pre><code> vendor/rails/activesupport/lib/active_support/dependencies.rb:440:in `load_missing_constant' vendor/rails/activesupport/lib/active_support/dependencies.rb:80:in `const_missing' app/sweepers/post_sweeper.rb:1 vendor/rails/activesupport/lib/active_support/dependencies.rb:380:in `load_without_new_constant_marking' vendor/rails/activesupport/lib/active_support/dependencies.rb:380:in `load_file' vendor/rails/activesupport/lib/active_support/dependencies.rb:521:in `new_constants_in' vendor/rails/activesupport/lib/active_support/dependencies.rb:379:in `load_file' vendor/rails/activesupport/lib/active_support/dependencies.rb:259:in `require_or_load' vendor/rails/activesupport/lib/active_support/dependencies.rb:425:in `load_missing_constant' vendor/rails/activesupport/lib/active_support/dependencies.rb:80:in `const_missing' vendor/rails/activesupport/lib/active_support/dependencies.rb:92:in `const_missing' vendor/rails/actionpack/lib/action_controller/caching/sweeping.rb:43:in `const_get' vendor/rails/actionpack/lib/action_controller/caching/sweeping.rb:43:in `cache_sweeper' vendor/rails/actionpack/lib/action_controller/caching/sweeping.rb:41:in `each' vendor/rails/actionpack/lib/action_controller/caching/sweeping.rb:41:in `cache_sweeper' app/controllers/posts_controller.rb:5 </code></pre> <p>On further digging, I've narrowed things down to commit 31ce92f7b5784bc5b6a441e88cd734c7b8b1c58f, "Use autoload instead of explicit requires for ActionController".</p> <p>Basically, when:</p> <pre><code> require 'action_controller/caching/sweeping' </code></pre> <p>Was ripped out in favor of:</p> <pre><code> autoload :Sweeping, 'action_controller/caching/sweeping' </code></pre> <p>Things break because the constant in question is not actually "Sweeping" but "Sweeper" (see line 56 of "actionpack/lib/action_controller/caching/sweeping.rb").</p> <p>I imagine the issue is relatively common because when you write a sweeper you do it with:</p> <pre><code> class PostSweeper &lt; ActionController::Caching::Sweeper </code></pre> <p>And don't actually make reference to the "Sweeping" constant mentioned in the autoload line.</p> <p>The fix? Conservatively I guess the fix is to add another autoload line:</p> <pre><code> autoload :Sweeper, 'action_controller/caching/sweeping' </code></pre> <p>Alternatively, if you think that nobody actually uses the "Sweeping" module directly, then you could actually replace the existing autoload line with the above.</p></div> 424 0 Originally posted this as a question to the rubyonrails-talk Google group: http://groups.google.com/group/rubyonrails-talk/browse_thread/thread/323ff7ec2d95ee32 Quoting from that message: Just updated to 2.3.0 RC1 and I'm finding that my sweepers are throwing NameErrors (uninitialized constant ActionController::Caching::Sweeper) when evaluation reaches lines like this one: @@@ class PostSweeper < ActionController::Caching::Sweeper @@@ This only happens in the development environment, because that's the only environment where I have "cache_classes" set to false. Relevant stack trace is: @@@ vendor/rails/activesupport/lib/active_support/dependencies.rb:440:in `load_missing_constant' vendor/rails/activesupport/lib/active_support/dependencies.rb:80:in `const_missing' app/sweepers/post_sweeper.rb:1 vendor/rails/activesupport/lib/active_support/dependencies.rb:380:in `load_without_new_constant_marking' vendor/rails/activesupport/lib/active_support/dependencies.rb:380:in `load_file' vendor/rails/activesupport/lib/active_support/dependencies.rb:521:in `new_constants_in' vendor/rails/activesupport/lib/active_support/dependencies.rb:379:in `load_file' vendor/rails/activesupport/lib/active_support/dependencies.rb:259:in `require_or_load' vendor/rails/activesupport/lib/active_support/dependencies.rb:425:in `load_missing_constant' vendor/rails/activesupport/lib/active_support/dependencies.rb:80:in `const_missing' vendor/rails/activesupport/lib/active_support/dependencies.rb:92:in `const_missing' vendor/rails/actionpack/lib/action_controller/caching/sweeping.rb:43:in `const_get' vendor/rails/actionpack/lib/action_controller/caching/sweeping.rb:43:in `cache_sweeper' vendor/rails/actionpack/lib/action_controller/caching/sweeping.rb:41:in `each' vendor/rails/actionpack/lib/action_controller/caching/sweeping.rb:41:in `cache_sweeper' app/controllers/posts_controller.rb:5 @@@ On further digging, I've narrowed things down to commit 31ce92f7b5784bc5b6a441e88cd734c7b8b1c58f, "Use autoload instead of explicit requires for ActionController". Basically, when: @@@ require 'action_controller/caching/sweeping' @@@ Was ripped out in favor of: @@@ autoload :Sweeping, 'action_controller/caching/sweeping' @@@ Things break because the constant in question is not actually "Sweeping" but "Sweeper" (see line 56 of "actionpack/lib/action_controller/caching/sweeping.rb"). I imagine the issue is relatively common because when you write a sweeper you do it with: @@@ class PostSweeper < ActionController::Caching::Sweeper @@@ And don't actually make reference to the "Sweeping" constant mentioned in the autoload line. The fix? Conservatively I guess the fix is to add another autoload line: @@@ autoload :Sweeper, 'action_controller/caching/sweeping' @@@ Alternatively, if you think that nobody actually uses the "Sweeping" module directly, then you could actually replace the existing autoload line with the above. <div><p>Originally posted this as a question to the rubyonrails-talk Google group:</p> <p><a href="http://groups.google.com/group/rubyonrails-talk/browse_thread/thread/323ff7ec2d95ee32"> http://groups.google.com/group/r...</a></p> <p>Quoting from that message:</p> <p>Just updated to 2.3.0 RC1 and I'm finding that my sweepers are throwing NameErrors (uninitialized constant ActionController::Caching::Sweeper) when evaluation reaches lines like this one:</p> <pre><code> class PostSweeper &lt; ActionController::Caching::Sweeper </code></pre> <p>This only happens in the development environment, because that's the only environment where I have "cache_classes" set to false. Relevant stack trace is:</p> <pre><code> vendor/rails/activesupport/lib/active_support/dependencies.rb:440:in `load_missing_constant' vendor/rails/activesupport/lib/active_support/dependencies.rb:80:in `const_missing' app/sweepers/post_sweeper.rb:1 vendor/rails/activesupport/lib/active_support/dependencies.rb:380:in `load_without_new_constant_marking' vendor/rails/activesupport/lib/active_support/dependencies.rb:380:in `load_file' vendor/rails/activesupport/lib/active_support/dependencies.rb:521:in `new_constants_in' vendor/rails/activesupport/lib/active_support/dependencies.rb:379:in `load_file' vendor/rails/activesupport/lib/active_support/dependencies.rb:259:in `require_or_load' vendor/rails/activesupport/lib/active_support/dependencies.rb:425:in `load_missing_constant' vendor/rails/activesupport/lib/active_support/dependencies.rb:80:in `const_missing' vendor/rails/activesupport/lib/active_support/dependencies.rb:92:in `const_missing' vendor/rails/actionpack/lib/action_controller/caching/sweeping.rb:43:in `const_get' vendor/rails/actionpack/lib/action_controller/caching/sweeping.rb:43:in `cache_sweeper' vendor/rails/actionpack/lib/action_controller/caching/sweeping.rb:41:in `each' vendor/rails/actionpack/lib/action_controller/caching/sweeping.rb:41:in `cache_sweeper' app/controllers/posts_controller.rb:5 </code></pre> <p>On further digging, I've narrowed things down to commit 31ce92f7b5784bc5b6a441e88cd734c7b8b1c58f, "Use autoload instead of explicit requires for ActionController".</p> <p>Basically, when:</p> <pre><code> require 'action_controller/caching/sweeping' </code></pre> <p>Was ripped out in favor of:</p> <pre><code> autoload :Sweeping, 'action_controller/caching/sweeping' </code></pre> <p>Things break because the constant in question is not actually "Sweeping" but "Sweeper" (see line 56 of "actionpack/lib/action_controller/caching/sweeping.rb").</p> <p>I imagine the issue is relatively common because when you write a sweeper you do it with:</p> <pre><code> class PostSweeper &lt; ActionController::Caching::Sweeper </code></pre> <p>And don't actually make reference to the "Sweeping" constant mentioned in the autoload line.</p> <p>The fix? Conservatively I guess the fix is to add another autoload line:</p> <pre><code> autoload :Sweeper, 'action_controller/caching/sweeping' </code></pre> <p>Alternatively, if you think that nobody actually uses the "Sweeping" module directly, then you could actually replace the existing autoload line with the above.</p></div> false 2009-02-15T18:45:06+00:00 12845 --- {} 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 new 2009-02-15T18:45:11+00:00 12845 Wincent Colaiuta Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 0 Attaching a minimal patch. <div><p>Attaching a minimal patch.</p></div> false 2009-02-15T18:53:37+00:00 12845 --- :tag: 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 new 2.3.0 patch 2009-02-15T18:53:38+00:00 12845 Wincent Colaiuta Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 1 Sigh, forget that patch I just attached. "autoload" evidently doesn't work like I thought it did. <div><p>Sigh, forget that patch I just attached. "autoload" evidently doesn't work like I thought it did.</p></div> false 2009-02-15T19:02:24+00:00 12845 --- :tag: 2.3.0 patch 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 new 2.3.0 2009-02-15T19:02:26+00:00 12845 Wincent Colaiuta Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 1 Further digging shows that at the time "actionpack/lib/action_controller/caching/sweeping.rb" is evaluated, the "Sweeper" class can't be defined yet because either ActiveRecord or ActiveRecord::Observer isn't defined yet... @@@ if defined?(ActiveRecord) and defined?(ActiveRecord::Observer)¶ class Sweeper < ActiveRecord::Observer #:nodoc:¶ @@@ If I fire up a "script/console" session, I see "action_controller/caching/sweeping.rb" being immediately evaluated, but ActionController::Caching::Sweeper does not get defined. If I require "action_controller/caching/sweeping.rb", nothing is evaluated because the file has already been loaded, so "require" does nothing. If I force re-evaluation of the file by using a different path in my "require", './vendor/rails/actionpack/lib/action_controller/caching/sweeping.rb', for instance, then ActionController::Caching::Sweeper does get defined. So is there any way to change the load order, so that by the time "sweeping.rb" gets evaluated ActiveRecord and ActiveRecord::Observer are defined? <div><p>Further digging shows that at the time "actionpack/lib/action_controller/caching/sweeping.rb" is evaluated, the "Sweeper" class can't be defined yet because either ActiveRecord or ActiveRecord::Observer isn't defined yet...</p> <pre><code> if defined?(ActiveRecord) and defined?(ActiveRecord::Observer)¶ class Sweeper &lt; ActiveRecord::Observer #:nodoc:¶ </code></pre> <p>If I fire up a "script/console" session, I see "action_controller/caching/sweeping.rb" being immediately evaluated, but ActionController::Caching::Sweeper does not get defined.</p> <p>If I require "action_controller/caching/sweeping.rb", nothing is evaluated because the file has already been loaded, so "require" does nothing.</p> <p>If I force re-evaluation of the file by using a different path in my "require", './vendor/rails/actionpack/lib/action_controller/caching/sweeping.rb', for instance, then ActionController::Caching::Sweeper does get defined.</p> <p>So is there any way to change the load order, so that by the time "sweeping.rb" gets evaluated ActiveRecord and ActiveRecord::Observer are defined?</p></div> false 2009-02-15T19:13:38+00:00 12845 --- {} 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 new 2.3.0 2009-02-15T19:13:39+00:00 12845 Wincent Colaiuta Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 1 Looking at this, the "correct" (robust) solution seems to be to: 1. Move the Sweeper class out into a separate file, seeing as it depends on ActiveRecord::Observer. 2. Add an "autoload" line for Sweeper, leaving the existing "autoload" for Sweeping in place. 3. In Sweeper's new file, require ActiveRecord/ActiveRecord::Observer. Sound ok? If so, I can whip up a patch. <div><p>Looking at this, the "correct" (robust) solution seems to be to:</p> <ol> <li>Move the Sweeper class out into a separate file, seeing as it depends on ActiveRecord::Observer.</li> <li>Add an "autoload" line for Sweeper, leaving the existing "autoload" for Sweeping in place.</li> <li>In Sweeper's new file, require ActiveRecord/ActiveRecord::Observer.</li> </ol> <p>Sound ok? If so, I can whip up a patch.</p></div> false 2009-02-15T19:38:56+00:00 12845 --- {} 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 new 2.3.0 2009-02-15T19:39:00+00:00 12845 Wincent Colaiuta Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 1 Ok, I now have a relatively minimal test case that demonstrates the problem. First up, create a new Rails app with a minimal resource: @@@ rails demo cd demo script/generate resource foo rake db:migrate @@@ Set up a sweeper: @@@ echo "class FooSweeper < ActionController::Caching::Sweeper; end" > app/models/foo_sweeper.rb @@@ Add a "cache_sweeper" line and a basic index action to the "app/controllers/foos_controller.rb": @@@ cache_sweeper :foo_sweeper def index; end @@@ Set up the corresponding view template: @@@ touch app/views/foos/index.html.erb @@@ To actually trigger the issue, I had to install Haml, so add this line to "config/environment.rb": @@@ config.gem 'haml', :version => '2.0.8' @@@ And unpack it (I guess this step is optional): @@@ rake gems:unpack @@@ Now the critical step... add this to "config/environments/development.rb": @@@ Sass::Plugin.options[:always_update] = true Sass::Plugin.options[:always_check] = true @@@ It doesn't matter what configuration you actually add in there; the important thing is to access the "Sass::Plugin" constant from inside the environment file... Now start up the server: @@@ script/server @@@ And try hitting a URL like http://localhost:3000/foos Voila, there's your "Uninitialized constant ActionController::Caching::Sweeper" exception. I discovered this by printing out a backtrace from within "actionpack/lib/action_controller/caching/sweeping.rb". Here I could see that: 1. The "sweeping.rb" file was evaluated for the first time because the "sass/plugin.rb" file references ActionController 2. At the time "sweeping.rb" is evaluated, ActiveRecord is already defined by ActiveRecord::Observer is not, so the Sweeper class never gets defined Here's the backtrace: @@@ /private/tmp/demo/vendor/rails/actionpack/lib/action_controller/caching/sweeping.rb:59 /private/tmp/demo/vendor/rails/actionpack/lib/action_controller/caching.rb:43:in `included' /private/tmp/demo/vendor/rails/actionpack/lib/action_controller/caching.rb:33:in `class_eval' /private/tmp/demo/vendor/rails/actionpack/lib/action_controller/caching.rb:33:in `included' /private/tmp/demo/vendor/rails/actionpack/lib/action_controller/base.rb:1350:in `include' /private/tmp/demo/vendor/rails/actionpack/lib/action_controller/base.rb:1350 /private/tmp/demo/vendor/rails/actionpack/lib/action_controller/base.rb:1345:in `each' /private/tmp/demo/vendor/rails/actionpack/lib/action_controller/base.rb:1345 /private/tmp/demo/vendor/rails/actionpack/lib/action_controller/base.rb:1344:in `class_eval' /private/tmp/demo/vendor/rails/actionpack/lib/action_controller/base.rb:1344 /private/tmp/demo/vendor/gems/haml-2.0.8/lib/sass/plugin/rails.rb:11 /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in `gem_original_require' /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in `require' /private/tmp/demo/vendor/rails/activesupport/lib/active_support/dependencies.rb:156:in `require' /private/tmp/demo/vendor/rails/activesupport/lib/active_support/dependencies.rb:521:in `new_constants_in' /private/tmp/demo/vendor/rails/activesupport/lib/active_support/dependencies.rb:156:in `require' /private/tmp/demo/vendor/gems/haml-2.0.8/lib/sass/plugin.rb:168 /private/tmp/demo/vendor/rails/activesupport/lib/active_support/dependencies.rb:380:in `load_without_new_constant_marking' /private/tmp/demo/vendor/rails/activesupport/lib/active_support/dependencies.rb:380:in `load_file' /private/tmp/demo/vendor/rails/activesupport/lib/active_support/dependencies.rb:521:in `new_constants_in' /private/tmp/demo/vendor/rails/activesupport/lib/active_support/dependencies.rb:379:in `load_file' /private/tmp/demo/vendor/rails/activesupport/lib/active_support/dependencies.rb:259:in `require_or_load' /private/tmp/demo/vendor/rails/activesupport/lib/active_support/dependencies.rb:425:in `load_missing_constant' /private/tmp/demo/vendor/rails/activesupport/lib/active_support/dependencies.rb:80:in `const_missing' /private/tmp/demo/config/environments/development.rb:21:in `load_environment' ./script/../config/../vendor/rails/railties/lib/initializer.rb:356:in `load_environment' /private/tmp/demo/vendor/rails/activesupport/lib/active_support/core_ext/kernel/reporting.rb:11:in `silence_warnings' ./script/../config/../vendor/rails/railties/lib/initializer.rb:349:in `load_environment' ./script/../config/../vendor/rails/railties/lib/initializer.rb:138:in `process' ./script/../config/../vendor/rails/railties/lib/initializer.rb:113:in `send' ./script/../config/../vendor/rails/railties/lib/initializer.rb:113:in `run' /private/tmp/demo/config/environment.rb:9 /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in `gem_original_require' /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in `require' /private/tmp/demo/vendor/rails/activesupport/lib/active_support/dependencies.rb:156:in `require' /private/tmp/demo/vendor/rails/activesupport/lib/active_support/dependencies.rb:521:in `new_constants_in' /private/tmp/demo/vendor/rails/activesupport/lib/active_support/dependencies.rb:156:in `require' /private/tmp/demo/vendor/rails/railties/lib/commands/server.rb:82 /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in `gem_original_require' /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in `require' script/server:3 @@@ So one workaround I have available to me is to drop the Sass configuration from my "config/environments/development.rb" file, and instead put it in an initializer in "config/initializers" inside a conditional "if ENV['RAILS_ENV'] == 'development'" block. But I think a more robust fix might be to make the changes I suggested in my last comment. Like I said, if someone thinks this is a good idea, please let me know and I'll prepare a patch. <div><p>Ok, I now have a relatively minimal test case that demonstrates the problem.</p> <p>First up, create a new Rails app with a minimal resource:</p> <pre><code> rails demo cd demo script/generate resource foo rake db:migrate </code></pre> <p>Set up a sweeper:</p> <pre><code> echo &quot;class FooSweeper &lt; ActionController::Caching::Sweeper; end&quot; &gt; app/models/foo_sweeper.rb </code></pre> <p>Add a "cache_sweeper" line and a basic index action to the "app/controllers/foos_controller.rb":</p> <pre><code> cache_sweeper :foo_sweeper def index; end </code></pre> <p>Set up the corresponding view template:</p> <pre><code> touch app/views/foos/index.html.erb </code></pre> <p>To actually trigger the issue, I had to install Haml, so add this line to "config/environment.rb":</p> <pre><code> config.gem 'haml', :version =&gt; '2.0.8' </code></pre> <p>And unpack it (I guess this step is optional):</p> <pre><code> rake gems:unpack </code></pre> <p>Now the critical step... add this to "config/environments/development.rb":</p> <pre><code> Sass::Plugin.options[:always_update] = true Sass::Plugin.options[:always_check] = true </code></pre> <p>It doesn't matter what configuration you actually add in there; the important thing is to access the "Sass::Plugin" constant from inside the environment file...</p> <p>Now start up the server:</p> <pre><code> script/server </code></pre> <p>And try hitting a URL like <a href="http://localhost:3000/foos">http://localhost:3000/foos</a></p> <p>Voila, there's your "Uninitialized constant ActionController::Caching::Sweeper" exception.</p> <p>I discovered this by printing out a backtrace from within "actionpack/lib/action_controller/caching/sweeping.rb". Here I could see that:</p> <ol> <li>The "sweeping.rb" file was evaluated for the first time because the "sass/plugin.rb" file references ActionController</li> <li>At the time "sweeping.rb" is evaluated, ActiveRecord is already defined by ActiveRecord::Observer is not, so the Sweeper class never gets defined</li> </ol> <p>Here's the backtrace:</p> <pre><code> /private/tmp/demo/vendor/rails/actionpack/lib/action_controller/caching/sweeping.rb:59 /private/tmp/demo/vendor/rails/actionpack/lib/action_controller/caching.rb:43:in `included' /private/tmp/demo/vendor/rails/actionpack/lib/action_controller/caching.rb:33:in `class_eval' /private/tmp/demo/vendor/rails/actionpack/lib/action_controller/caching.rb:33:in `included' /private/tmp/demo/vendor/rails/actionpack/lib/action_controller/base.rb:1350:in `include' /private/tmp/demo/vendor/rails/actionpack/lib/action_controller/base.rb:1350 /private/tmp/demo/vendor/rails/actionpack/lib/action_controller/base.rb:1345:in `each' /private/tmp/demo/vendor/rails/actionpack/lib/action_controller/base.rb:1345 /private/tmp/demo/vendor/rails/actionpack/lib/action_controller/base.rb:1344:in `class_eval' /private/tmp/demo/vendor/rails/actionpack/lib/action_controller/base.rb:1344 /private/tmp/demo/vendor/gems/haml-2.0.8/lib/sass/plugin/rails.rb:11 /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in `gem_original_require' /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in `require' /private/tmp/demo/vendor/rails/activesupport/lib/active_support/dependencies.rb:156:in `require' /private/tmp/demo/vendor/rails/activesupport/lib/active_support/dependencies.rb:521:in `new_constants_in' /private/tmp/demo/vendor/rails/activesupport/lib/active_support/dependencies.rb:156:in `require' /private/tmp/demo/vendor/gems/haml-2.0.8/lib/sass/plugin.rb:168 /private/tmp/demo/vendor/rails/activesupport/lib/active_support/dependencies.rb:380:in `load_without_new_constant_marking' /private/tmp/demo/vendor/rails/activesupport/lib/active_support/dependencies.rb:380:in `load_file' /private/tmp/demo/vendor/rails/activesupport/lib/active_support/dependencies.rb:521:in `new_constants_in' /private/tmp/demo/vendor/rails/activesupport/lib/active_support/dependencies.rb:379:in `load_file' /private/tmp/demo/vendor/rails/activesupport/lib/active_support/dependencies.rb:259:in `require_or_load' /private/tmp/demo/vendor/rails/activesupport/lib/active_support/dependencies.rb:425:in `load_missing_constant' /private/tmp/demo/vendor/rails/activesupport/lib/active_support/dependencies.rb:80:in `const_missing' /private/tmp/demo/config/environments/development.rb:21:in `load_environment' ./script/../config/../vendor/rails/railties/lib/initializer.rb:356:in `load_environment' /private/tmp/demo/vendor/rails/activesupport/lib/active_support/core_ext/kernel/reporting.rb:11:in `silence_warnings' ./script/../config/../vendor/rails/railties/lib/initializer.rb:349:in `load_environment' ./script/../config/../vendor/rails/railties/lib/initializer.rb:138:in `process' ./script/../config/../vendor/rails/railties/lib/initializer.rb:113:in `send' ./script/../config/../vendor/rails/railties/lib/initializer.rb:113:in `run' /private/tmp/demo/config/environment.rb:9 /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in `gem_original_require' /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in `require' /private/tmp/demo/vendor/rails/activesupport/lib/active_support/dependencies.rb:156:in `require' /private/tmp/demo/vendor/rails/activesupport/lib/active_support/dependencies.rb:521:in `new_constants_in' /private/tmp/demo/vendor/rails/activesupport/lib/active_support/dependencies.rb:156:in `require' /private/tmp/demo/vendor/rails/railties/lib/commands/server.rb:82 /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in `gem_original_require' /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in `require' script/server:3 </code></pre> <p>So one workaround I have available to me is to drop the Sass configuration from my "config/environments/development.rb" file, and instead put it in an initializer in "config/initializers" inside a conditional "if ENV['RAILS_ENV'] == 'development'" block.</p> <p>But I think a more robust fix might be to make the changes I suggested in my last comment. Like I said, if someone thinks this is a good idea, please let me know and I'll prepare a patch.</p></div> false 2009-02-16T10:35:03+00:00 12845 --- {} 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 new 2.3.0 2009-02-16T10:35:05+00:00 12845 Wincent Colaiuta Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 1 (from [460269dcafd6d190d51176b2b03e65f3f44669b8]) Autoload ActionController::Caching::Sweeper constant [#1977 state:resolved] http://github.com/rails/rails/commit/460269dcafd6d190d51176b2b03e65f3f44669b8 <div><p>(from [460269dcafd6d190d51176b2b03e65f3f44669b8]) Autoload ActionController::Caching::Sweeper constant [<a href="/projects/8994/tickets/1977" title="Ticket #1977">#1977</a> state:resolved] <a href="http://github.com/rails/rails/commit/460269dcafd6d190d51176b2b03e65f3f44669b8"> http://github.com/rails/rails/co...</a></p></div> true 2009-02-16T20:38:23+00:00 12845 --- :state: new 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 resolved 2.3.0 2009-02-16T20:38:23+00:00 17393 Repository Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 1 I still have this issue. I think [Wincent's solution](http://rails.lighthouseapp.com/projects/8994/tickets/1977-actioncontrollercachingsweeper-autoloading-is-broken#ticket-1977-5) should solve this. <div><p>I still have this issue. I think <a href="http://rails.lighthouseapp.com/projects/8994/tickets/1977-actioncontrollercachingsweeper-autoloading-is-broken#ticket-1977-5"> Wincent's solution</a> should solve this.</p></div> true 2009-02-26T15:14:18+00:00 12845 --- {} 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 resolved 2.3.0 2009-02-26T15:14:20+00:00 42312 LacKac Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 1 Yes, it would. But... ...So the bug is that since the changes were made to Rails' class caching, and since switching to using "autoload" pervasively, Rails has become a lot more sensitive to certain load-ordering issues. And it's true that my suggested fix would address this one particular case. But having said all that, I realized that the way to fix my problem was to move my Sass stuff out of environments/development.rb and into an initializer in config/initializers. @@@ if ENV['RAILS_ENV'] == 'development' Sass::Plugin.options[:always_update] = true Sass::Plugin.options[:always_check] = true end @@@ You could argue that it's a bug that Rails has become less tolerant about where it accepts this kind of thing, but I think more than anything it's a documentation bug. Turns out that this is only the last of several issues that I've run into at startup time since these changes were made to Rails. I've come to the conclusion that pretty much the _only_ thing it is safe to use inside config/environment.rb and config/environments/*.rb are "config.*" statements. Pretty much everything else needs to go in an initializer to avoid this kind of problem. About the only thing that would have helped me avoid these issues would have been a big warning in the release notes, or a comment in the actual environment files advising that pretty much the only thing that should go in them should be "config.*" statements. I probably only ran into the issue because I was updating an app that was started with a significantly older version of Rails. It is a bit of a step backwards that you have to put this kind of stuff inside an "if" that explicitly checks RAILS_ENV rather than just sticking it in config/environments/development.rb like you used to. But I doubt anyone is going to be willing to do the work to make all that work again. <div><p>Yes, it would. But...</p> <p>...So the bug is that since the changes were made to Rails' class caching, and since switching to using "autoload" pervasively, Rails has become a lot more sensitive to certain load-ordering issues.</p> <p>And it's true that my suggested fix would address this one particular case.</p> <p>But having said all that, I realized that the way to fix my problem was to move my Sass stuff out of environments/development.rb and into an initializer in config/initializers.</p> <pre><code> if ENV['RAILS_ENV'] == 'development' Sass::Plugin.options[:always_update] = true Sass::Plugin.options[:always_check] = true end </code></pre> <p>You could argue that it's a bug that Rails has become less tolerant about where it accepts this kind of thing, but I think more than anything it's a documentation bug.</p> <p>Turns out that this is only the last of several issues that I've run into at startup time since these changes were made to Rails. I've come to the conclusion that pretty much the <em>only</em> thing it is safe to use inside config/environment.rb and config/environments/<em>.rb are "config.</em>" statements. Pretty much everything else needs to go in an initializer to avoid this kind of problem.</p> <p>About the only thing that would have helped me avoid these issues would have been a big warning in the release notes, or a comment in the actual environment files advising that pretty much the only thing that should go in them should be "config.*" statements. I probably only ran into the issue because I was updating an app that was started with a significantly older version of Rails.</p> <p>It is a bit of a step backwards that you have to put this kind of stuff inside an "if" that explicitly checks RAILS_ENV rather than just sticking it in config/environments/development.rb like you used to. But I doubt anyone is going to be willing to do the work to make all that work again.</p></div> true 2009-02-26T19:45:59+00:00 12845 --- {} 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 resolved 2.3.0 2009-02-26T19:46:03+00:00 12845 Wincent Colaiuta Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 1 I'm still seeing and error with RC2. @@@ ruby => Rails 2.3.1 application starting on http://0.0.0.0:3000 /Users/chris/workspace/petflight/vendor/rails/activesupport/lib/active_support/dependencies.rb:440:in `load_missing_constant': uninitialized constant ActionController::Caching::Sweeper (NameError) from /Users/chris/workspace/petflight/vendor/rails/activesupport/lib/active_support/dependencies.rb:80:in `const_missing' from /Users/chris/workspace/petflight/app/sweepers/definition_sweeper.rb:1 from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in `gem_original_require' from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in `require' from /Users/chris/workspace/petflight/vendor/rails/activesupport/lib/active_support/dependencies.rb:158:in `require' from /Users/chris/workspace/petflight/vendor/rails/activesupport/lib/active_support/dependencies.rb:265:in `require_or_load' from /Users/chris/workspace/petflight/vendor/rails/activesupport/lib/active_support/dependencies.rb:425:in `load_missing_constant' from /Users/chris/workspace/petflight/vendor/rails/activesupport/lib/active_support/dependencies.rb:80:in `const_missing' ... 26 levels... from /Users/chris/workspace/petflight/vendor/rails/railties/lib/commands/server.rb:84 from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in `gem_original_require' from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in `require' from ./script/server:3 @@@ <div><p>I'm still seeing and error with RC2.</p> <pre><code class="ruby"> =&gt; Rails 2.3.1 application starting on http://0.0.0.0:3000 /Users/chris/workspace/petflight/vendor/rails/activesupport/lib/active_support/dependencies.rb:440:in `load_missing_constant': uninitialized constant ActionController::Caching::Sweeper (NameError) from /Users/chris/workspace/petflight/vendor/rails/activesupport/lib/active_support/dependencies.rb:80:in `const_missing' from /Users/chris/workspace/petflight/app/sweepers/definition_sweeper.rb:1 from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in `gem_original_require' from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in `require' from /Users/chris/workspace/petflight/vendor/rails/activesupport/lib/active_support/dependencies.rb:158:in `require' from /Users/chris/workspace/petflight/vendor/rails/activesupport/lib/active_support/dependencies.rb:265:in `require_or_load' from /Users/chris/workspace/petflight/vendor/rails/activesupport/lib/active_support/dependencies.rb:425:in `load_missing_constant' from /Users/chris/workspace/petflight/vendor/rails/activesupport/lib/active_support/dependencies.rb:80:in `const_missing' ... 26 levels... from /Users/chris/workspace/petflight/vendor/rails/railties/lib/commands/server.rb:84 from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in `gem_original_require' from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in `require' from ./script/server:3 </code></pre></div> true 2009-03-14T00:33:14+00:00 12845 --- {} 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 resolved 2.3.0 2009-03-14T00:33:19+00:00 50638 Chris Nichols Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 1 i'm still seeing and error wirh 2.3.2. /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/dependencies.rb:440:in `load_missing_constant': uninitialized constant ActionController::Caching::Sweeper (NameError) from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/dependencies.rb:80:in `const_missing' from ./spec/../lib/user_stamp.rb:29 from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in `gem_original_require' from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in `require' from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/dependencies.rb:156:in `require' from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/dependencies.rb:521:in `new_constants_in' from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/dependencies.rb:156:in `require' from ./spec/spec_helper.rb:14 from ./spec/user_stamp_class_methods_spec.rb:1:in `require' from ./spec/user_stamp_class_methods_spec.rb:1 from /Library/Ruby/Gems/1.8/gems/rspec-1.2.0/lib/spec/runner/example_group_runner.rb:15:in `load' from /Library/Ruby/Gems/1.8/gems/rspec-1.2.0/lib/spec/runner/example_group_runner.rb:15:in `load_files' from /Library/Ruby/Gems/1.8/gems/rspec-1.2.0/lib/spec/runner/example_group_runner.rb:14:in `each' from /Library/Ruby/Gems/1.8/gems/rspec-1.2.0/lib/spec/runner/example_group_runner.rb:14:in `load_files' from /Library/Ruby/Gems/1.8/gems/rspec-1.2.0/lib/spec/runner/options.rb:87:in `run_examples' from /Library/Ruby/Gems/1.8/gems/rspec-1.2.0/lib/spec/runner/command_line.rb:9:in `run' from /Library/Ruby/Gems/1.8/gems/rspec-1.2.0/bin/spec:4 rake aborted! Command /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/bin/ruby -I"/Library/Ruby/Gems/1.8/gems/rspec-1.2.0/lib" "/Library/Ruby/Gems/1.8/gems/rspec-1.2.0/bin/spec" "spec/user_stamp_class_methods_spec.rb" "spec/user_stamp_spec.rb" "spec/user_stamp_sweeper_spec.rb" --colour --format progress --loadby mtime --reverse failed (See full trace by running task with --trace) <div><p>i'm still seeing and error wirh 2.3.2.</p> <p> /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/dependencies.rb:440:in <code>load_missing_constant': uninitialized constant ActionController::Caching::Sweeper (NameError)</code></p> <pre> <code>from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/dependencies.rb:80:in `const_missing' from ./spec/../lib/user_stamp.rb:29 from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in `gem_original_require' from /Library/Ruby/Site/1.8/rubygems/custom_require.rb:31:in `require' from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/dependencies.rb:156:in `require' from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/dependencies.rb:521:in `new_constants_in' from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/dependencies.rb:156:in `require' from ./spec/spec_helper.rb:14 from ./spec/user_stamp_class_methods_spec.rb:1:in `require' from ./spec/user_stamp_class_methods_spec.rb:1 from /Library/Ruby/Gems/1.8/gems/rspec-1.2.0/lib/spec/runner/example_group_runner.rb:15:in `load' from /Library/Ruby/Gems/1.8/gems/rspec-1.2.0/lib/spec/runner/example_group_runner.rb:15:in `load_files' from /Library/Ruby/Gems/1.8/gems/rspec-1.2.0/lib/spec/runner/example_group_runner.rb:14:in `each' from /Library/Ruby/Gems/1.8/gems/rspec-1.2.0/lib/spec/runner/example_group_runner.rb:14:in `load_files' from /Library/Ruby/Gems/1.8/gems/rspec-1.2.0/lib/spec/runner/options.rb:87:in `run_examples' from /Library/Ruby/Gems/1.8/gems/rspec-1.2.0/lib/spec/runner/command_line.rb:9:in `run' from /Library/Ruby/Gems/1.8/gems/rspec-1.2.0/bin/spec:4 </code> </pre> <p>rake aborted! Command /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/bin/ruby -I"/Library/Ruby/Gems/1.8/gems/rspec-1.2.0/lib" "/Library/Ruby/Gems/1.8/gems/rspec-1.2.0/bin/spec" "spec/user_stamp_class_methods_spec.rb" "spec/user_stamp_spec.rb" "spec/user_stamp_sweeper_spec.rb" --colour --format progress --loadby mtime --reverse failed</p> <p>(See full trace by running task with --trace)</p></div> true 2009-03-16T15:04:27+00:00 12845 --- :tag: 2.3.0 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 resolved 2.3.2 2009-03-16T15:04:33+00:00 19461 Kivanio Barbosa Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 1 I'm getting this error as well when using Rails 2.3.2 Here are some more specifics: if I put this line: <code> ActionController::Base.cache_store = :file_store, "#{RAILS_ROOT}/tmp/cache" </code> in either development.rb or in environment.rb then I receive this error: <code> undefined method `cache_sweeper' for Admin::BoardroomsController:Class </code> However, if I put the cache_store command in an initializer then everything seems to work just fine. <div><p>I'm getting this error as well when using Rails 2.3.2</p> <p>Here are some more specifics:</p> <p>if I put this line:</p> <p><code>ActionController::Base.cache_store = :file_store, "#{RAILS_ROOT}/tmp/cache"</code></p> <p>in either development.rb or in environment.rb then I receive this error:</p> <p><code>undefined method</code> cache_sweeper' for Admin::BoardroomsController:Class &lt;/code&gt;</p> <p>However, if I put the cache_store command in an initializer then everything seems to work just fine.</p></div> true 2009-03-16T20:45:56+00:00 12845 --- {} 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 resolved 2.3.2 2009-03-16T20:46:00+00:00 37336 francois Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 1 Having this issue as well, can we get this ticket reopened? Should we start a new one? <div><p>Having this issue as well, can we get this ticket reopened? Should we start a new one?</p></div> true 2009-03-17T20:42:01+00:00 12845 --- {} 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 resolved 2.3.2 2009-03-17T20:42:04+00:00 42199 Ben Reubenstein Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 1 I had this problem too. A workaround (for the time-being) is to force ActiveRecord to load first in the config. I added a line with ActiveRecord::Base to development/production/test.rb. <div><p>I had this problem too. A workaround (for the time-being) is to force ActiveRecord to load first in the config. I added a line with ActiveRecord::Base to development/production/test.rb.</p></div> true 2009-03-18T02:21:18+00:00 12845 --- {} 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 resolved 2.3.2 2009-03-18T02:21:22+00:00 20082 Brad Folkens Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 1 rails 2.3.2 has the same problem. <div><p>rails 2.3.2 has the same problem.</p></div> true 2009-03-18T08:18:05+00:00 12845 --- {} 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 resolved 2.3.2 2009-03-18T08:18:10+00:00 28273 Gudata Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 1 I have this problem in 2.3.2, as well. I haven't troubleshot what's causing it, but adding "ActiveRecord::Base" as the first line of my environment config files does fix it. <div><p>I have this problem in 2.3.2, as well. I haven't troubleshot what's causing it, but adding "ActiveRecord::Base" as the first line of my environment config files does fix it.</p></div> true 2009-03-18T19:44:54+00:00 12845 --- {} 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 resolved 2.3.2 2009-03-18T19:44:59+00:00 19184 Chris Heald Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 1 If you get this error maybe you are upgrading your app from an older rails version and you should check whats triggering the loading of AR in your environment.rb earlier. In my case it was lines: @@@ ruby ActionController::Base.logger = Logger.new(STDOUT) ActionController::Base.logger.level = Logger::INFO ActiveRecord::Base.logger = Logger.new(STDOUT) ActiveRecord::Base.logger.level = Logger::INFO @@@ After commenting them everthing was ok. Very big thanks to W. Colaiuta for defining the problem. He also has proposed **another** fix of this issue that will work better with most of the existing rails apps <div><p>If you get this error maybe you are upgrading your app from an older rails version and you should check whats triggering the loading of AR in your environment.rb earlier.</p> <p>In my case it was lines:</p> <pre><code class="ruby"> ActionController::Base.logger = Logger.new(STDOUT) ActionController::Base.logger.level = Logger::INFO ActiveRecord::Base.logger = Logger.new(STDOUT) ActiveRecord::Base.logger.level = Logger::INFO </code></pre> <p>After commenting them everthing was ok.</p> <p>Very big thanks to W. Colaiuta for defining the problem.</p> <p>He also has proposed <strong>another</strong> fix of this issue that will work better with most of the existing rails apps</p></div> true 2009-03-19T11:34:41+00:00 12845 --- {} 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 resolved 2.3.2 2009-03-19T11:34:46+00:00 28273 Gudata Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 1 For me it was: ActionController::Base.session_options[:domain] = ... <div><p>For me it was:</p> <p>ActionController::Base.session_options[:domain] = ...</p></div> true 2009-03-19T14:17:22+00:00 12845 --- {} 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 resolved 2.3.2 2009-03-19T14:17:27+00:00 20082 Brad Folkens Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 1 Despite all these tweaks, I still had the problem after upgrading from 2.2.2 to 2.3.2 In config/environnements/development.rb, I had @@@ ruby ActionController::Base.cache_store = :file_store, "#{RAILS_ROOT}/tmp/cache" @@@ After reading the "Rails Guides":http://guides.rubyonrails.org/caching_with_rails.html#cache-stores, I found that I could/should write @@@ ruby config.cache_store = :file_store, "#{RAILS_ROOT}/tmp/cache" @@@ And it worked ! In my case I found the culprit to be the cache_store definition, but I think the problem is more about calling ActionController directly and not the cache_store call itself. <div><p>Despite all these tweaks, I still had the problem after upgrading from 2.2.2 to 2.3.2</p> <p>In config/environnements/development.rb, I had</p> <pre><code class="ruby"> ActionController::Base.cache_store = :file_store, &quot;#{RAILS_ROOT}/tmp/cache&quot; </code></pre> <p>After reading the <a href="http://guides.rubyonrails.org/caching_with_rails.html#cache-stores"> Rails Guides</a>, I found that I could/should write</p> <pre><code class="ruby"> config.cache_store = :file_store, &quot;#{RAILS_ROOT}/tmp/cache&quot; </code></pre> <p>And it worked !</p> <p>In my case I found the culprit to be the cache_store definition, but I think the problem is more about calling ActionController directly and not the cache_store call itself.</p></div> true 2009-03-31T09:28:20+01:00 12845 --- {} 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 resolved 2.3.2 2009-03-31T09:28:24+01:00 52463 Jérémy Lecour Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 1 I'm sorry, but I'm still having the issue, and don't understand how to solve it. I'm migrating a rails 2.2.3 app to 2.3.2, and since my subdomain cookie don't work any more, I've changed : ActionController::CgiRequest::DEFAULT_SESSION_OPTIONS.update(:domain => ".mydomain.com") to ActionController::Base.session_options[:domain] = ".mydomain.com" Now I get this famous `uninitialized constant ActionController::Caching::Sweeper` error. I've tried some of the tips in this ticket without success anyway :( Thx <div><p>I'm sorry, but I'm still having the issue, and don't understand how to solve it. I'm migrating a rails 2.2.3 app to 2.3.2, and since my subdomain cookie don't work any more, I've changed :</p> <pre> <code>ActionController::CgiRequest::DEFAULT_SESSION_OPTIONS.update(:domain =&gt; ".mydomain.com") </code> </pre> <p>to</p> <pre> <code>ActionController::Base.session_options[:domain] = ".mydomain.com" </code> </pre> <p>Now I get this famous <code>uninitialized constant ActionController::Caching::Sweeper</code> error. I've tried some of the tips in this ticket without success anyway :(</p> <p>Thx</p></div> true 2009-04-10T14:20:09+01:00 12845 --- {} 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 resolved 2.3.2 2009-04-10T14:20:13+01:00 19160 Gravis Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 1 You can add these lines to your production.rb, development.rb .... ------------------------------- # this is a workaround for problems with loading caching sweepers ActiveRecord::Base ------------------------------- So you should just load AR:B first. <div><h2>You can add these lines to your production.rb, development.rb ....</h2> <h1>this is a workaround for problems with loading caching sweepers</h1> <h2>ActiveRecord::Base</h2> <p>So you should just load AR:B first.</p></div> true 2009-04-10T14:25:04+01:00 12845 --- {} 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 resolved 2.3.2 2009-04-10T14:25:08+01:00 18890 stanislav Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 1 Update : I've corrected the issue by using : @@@ ruby Rails.configuration.action_controller.session[:domain] = '.staging.mydomain.net' @@@ in my `config/environments/staging.rb` file. <div><p>Update : I've corrected the issue by using :</p> <pre><code class="ruby"> Rails.configuration.action_controller.session[:domain] = '.staging.mydomain.net' </code></pre> <p>in my <code>config/environments/staging.rb</code> file.</p></div> true 2009-04-10T14:26:29+01:00 12845 --- {} 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 resolved 2.3.2 2009-04-10T14:26:34+01:00 19160 Gravis Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 1 Ups, a strange formatting..... The workaround is just to add this line: ActiveRecord::Base In the begging of your production.rb, development.rb .... <div><p>Ups, a strange formatting.....</p> <p>The workaround is just to add this line: ActiveRecord::Base In the begging of your production.rb, development.rb ....</p></div> true 2009-04-10T14:27:03+01:00 12845 --- {} 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 resolved 2.3.2 2009-04-10T14:27:06+01:00 18890 stanislav Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 1 @stanislav : thx, what do you mean by adding these line ? just ActiveRecord::Base ? I get a `NameError: uninitialized constant ActiveRecord` error when doing this, I guess I'm doing something wrong :( <div><p>@stanislav : thx, what do you mean by adding these line ?</p> <p>just</p> <pre> <code>ActiveRecord::Base </code> </pre> <p>? I get a <code>NameError: uninitialized constant ActiveRecord</code> error when doing this, I guess I'm doing something wrong :(</p></div> true 2009-04-10T14:32:11+01:00 12845 --- {} 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 resolved 2.3.2 2009-04-10T14:32:13+01:00 19160 Gravis Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 1 Still having this issue when working with Rails 2.3.2. <div><p>Still having this issue when working with Rails 2.3.2.</p></div> true 2009-04-11T23:01:24+01:00 12845 --- {} 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 resolved 2.3.2 2009-04-11T23:01:29+01:00 49004 Ozgun Ataman Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 1 Even after removing all reference so ActionController direclty within the environment initializers, the sweepers are still not working. * Application loads successfully * Caching works as expected * Sweeper ActiveRecord observers don't seem to be properly hooked into callbacks, as their methods do not get called. This is when using Rails 2.3.2 <div><p>Even after removing all reference so ActionController direclty within the environment initializers, the sweepers are still not working.</p> <ul> <li>Application loads successfully</li> <li>Caching works as expected</li> <li>Sweeper ActiveRecord observers don't seem to be properly hooked into callbacks, as their methods do not get called.</li> </ul> <p>This is when using Rails 2.3.2</p></div> true 2009-04-11T23:48:29+01:00 12845 --- {} 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 resolved 2.3.2 2009-04-11T23:48:33+01:00 49004 Ozgun Ataman Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 1 I see this too, wincent, can you please provide a patch along the lines you indicated. <div><p>I see this too, wincent, can you please provide a patch along the lines you indicated.</p></div> false 2009-04-22T00:38:27+01:00 12845 --- :state: resolved 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 open 2.3.2 2009-04-22T00:38:31+01:00 141 Michael Koziarski Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 1 Ok, here's a patch against the 2-3-stable branch. The test suite passes but I haven't been able to actually test this out on a sample app because I don't know how to run the "rails" command or install gems from the branch... So perhaps someone who knows how to do that can try it out. <div><p>Ok, here's a patch against the 2-3-stable branch. The test suite passes but I haven't been able to actually test this out on a sample app because I don't know how to run the "rails" command or install gems from the branch... So perhaps someone who knows how to do that can try it out.</p></div> false 2009-04-22T10:34:42+01:00 12845 --- :tag: 2.3.2 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 open 2.3.2 patch 2009-04-22T10:34:46+01:00 12845 Wincent Colaiuta Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 2 (from [5ac05f15c6d8f496c4e152dbbecd8ccb12041770]) Extract ActionController::Caching::Sweeper into separate file [#1977 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> http://github.com/rails/rails/commit/5ac05f15c6d8f496c4e152dbbecd8ccb12041770 <div><p>(from [5ac05f15c6d8f496c4e152dbbecd8ccb12041770]) Extract ActionController::Caching::Sweeper into separate file [<a href="/projects/8994/tickets/1977" title="Ticket #1977">#1977</a> state:resolved]</p> <p>Signed-off-by: Joshua Peek <a href="mailto:josh@joshpeek.com">josh@joshpeek.com</a> <a href="http://github.com/rails/rails/commit/5ac05f15c6d8f496c4e152dbbecd8ccb12041770"> http://github.com/rails/rails/co...</a></p></div> true 2009-05-05T02:18:13+01:00 12845 --- :state: open 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 resolved 2.3.2 patch 2009-05-05T02:18:14+01:00 17393 Repository Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 2 I'm running the latest 2-3-stable branch with the above patch included but I'm still seeing the issue. @@@ ruby /Users/Me/MyApp/trunk/vendor/rails/activesupport/lib/active_support/dependencies.rb:440:in `load_missing_constant': uninitialized constant ActionController::Caching::Sweeper (NameError) from /Users/Me/MyApp/Code/trunk/vendor/rails/activesupport/lib/active_support/dependencies.rb:80:in `const_missing' from /Users/Me/MyApp/Code/trunk/app/sweepers/bank_sweeper.rb:1 from /Users/Me/MyApp/Code/trunk/vendor/rails/activesupport/lib/active_support/dependencies.rb:380:in `load_without_new_constant_marking' from /Users/Me/MyApp/Code/trunk/vendor/rails/activesupport/lib/active_support/dependencies.rb:380:in `load_file' from /Users/Me/MyApp/Code/trunk/vendor/rails/activesupport/lib/active_support/dependencies.rb:521:in `new_constants_in' from /Users/Me/MyApp/Code/trunk/vendor/rails/activesupport/lib/active_support/dependencies.rb:379:in `load_file' from /Users/Me/MyApp/Code/trunk/vendor/rails/activesupport/lib/active_support/dependencies.rb:259:in `require_or_load' from /Users/Me/MyApp/Code/trunk/vendor/rails/activesupport/lib/active_support/dependencies.rb:425:in `load_missing_constant' ... 38 levels... from /usr/local/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `require' @@@ <div><p>I'm running the latest 2-3-stable branch with the above patch included but I'm still seeing the issue.</p> <pre><code class="ruby"> /Users/Me/MyApp/trunk/vendor/rails/activesupport/lib/active_support/dependencies.rb:440:in `load_missing_constant': uninitialized constant ActionController::Caching::Sweeper (NameError) from /Users/Me/MyApp/Code/trunk/vendor/rails/activesupport/lib/active_support/dependencies.rb:80:in `const_missing' from /Users/Me/MyApp/Code/trunk/app/sweepers/bank_sweeper.rb:1 from /Users/Me/MyApp/Code/trunk/vendor/rails/activesupport/lib/active_support/dependencies.rb:380:in `load_without_new_constant_marking' from /Users/Me/MyApp/Code/trunk/vendor/rails/activesupport/lib/active_support/dependencies.rb:380:in `load_file' from /Users/Me/MyApp/Code/trunk/vendor/rails/activesupport/lib/active_support/dependencies.rb:521:in `new_constants_in' from /Users/Me/MyApp/Code/trunk/vendor/rails/activesupport/lib/active_support/dependencies.rb:379:in `load_file' from /Users/Me/MyApp/Code/trunk/vendor/rails/activesupport/lib/active_support/dependencies.rb:259:in `require_or_load' from /Users/Me/MyApp/Code/trunk/vendor/rails/activesupport/lib/active_support/dependencies.rb:425:in `load_missing_constant' ... 38 levels... from /usr/local/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `require' </code></pre></div> true 2009-05-08T14:22:54+01:00 12845 --- {} 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 resolved 2.3.2 patch 2009-05-08T14:23:00+01:00 18493 Olly Headey Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 2 Ditto on this error with the most recent 2.3 -- I was not having the issue before, and it seems the most recent commit actually caused it. Also, action_controller/caching/sweeper.rb has a syntax error -- it's missing an "end". No kidding -- http://github.com/rails/rails/blob/5ac05f15c6d8f496c4e152dbbecd8ccb12041770/actionpack/lib/action_controller/caching/sweeper.rb <div><p>Ditto on this error with the most recent 2.3 -- I was not having the issue before, and it seems the most recent commit actually caused it.</p> <p>Also, action_controller/caching/sweeper.rb has a syntax error -- it's missing an "end". No kidding --</p> <p><a href="http://github.com/rails/rails/blob/5ac05f15c6d8f496c4e152dbbecd8ccb12041770/actionpack/lib/action_controller/caching/sweeper.rb"> http://github.com/rails/rails/bl...</a></p></div> true 2009-05-09T22:32:51+01:00 12845 --- {} 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 resolved 2.3.2 patch 2009-05-09T22:32:54+01:00 22427 David Reese Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 2 I can confirm that the patch does not fix the bug on 2.3.2 and no workaround mentioned in this discussion works for me. Can someone please reopen this ticket. This is very frustrating. <div><p>I can confirm that the patch does not fix the bug on 2.3.2 and no workaround mentioned in this discussion works for me.</p> <p>Can someone please reopen this ticket. This is very frustrating.</p></div> true 2009-06-01T18:23:45+01:00 12845 --- {} 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 resolved 2.3.2 patch 2009-06-01T18:23:49+01:00 11310 Andreas Korth Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 2 Andreas, This is fixed in 2-3-stable isn't it? <div><p>Andreas,</p> <p>This is fixed in 2-3-stable isn't it?</p></div> true 2009-06-01T22:05:04+01:00 12845 --- {} 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 resolved 2.3.2 patch 2009-06-01T22:05:06+01:00 141 Michael Koziarski Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 2 Just thought I'd point out that it's working for me now <div><p>Just thought I'd point out that it's working for me now</p></div> true 2009-06-01T22:16:33+01:00 12845 --- {} 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 resolved 2.3.2 patch 2009-06-01T22:16:37+01:00 18493 Olly Headey Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 2 Michael, I'm still having this issue in Rails 2.3.2. It might be worth noting that the sweeper class is inside a plugin. Some of the reports indicate that the bug depends on the (auto)load order of classes. The NameError does not occur if I explicitely require the file that defines ActionController::Caching::Sweeper in an initializer, like so: require "#{RAILS_ROOT}/vendor/rails/actionpack/lib/action_controller/caching/sweeping.rb" What baffles me is that there is no sweeper.rb file in actionpack-2.3.2/lib/action_controller/caching/. I thought the patch involved moving ActionController::Caching::Sweeper into a separate file. <div><p>Michael,</p> <p>I'm still having this issue in Rails 2.3.2. It might be worth noting that the sweeper class is inside a plugin. Some of the reports indicate that the bug depends on the (auto)load order of classes.</p> <p>The NameError does not occur if I explicitely require the file that defines ActionController::Caching::Sweeper in an initializer, like so:</p> <p>require "#{RAILS_ROOT}/vendor/rails/actionpack/lib/action_controller/caching/sweeping.rb"</p> <p>What baffles me is that there is no sweeper.rb file in actionpack-2.3.2/lib/action_controller/caching/. I thought the patch involved moving ActionController::Caching::Sweeper into a separate file.</p></div> true 2009-06-01T22:29:34+01:00 12845 --- {} 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 resolved 2.3.2 patch 2009-06-01T22:29:39+01:00 11310 Andreas Korth Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 2 Andreas, We're aware of the problem in 2.3.2, however I'm pretty sure it's fixed in 2-3-stable (a branch in git). If you're able to confirm that, then I'll know we're good to go and we can release 2.3.3 in a few days which will include this fix. <div><p>Andreas,</p> <p>We're aware of the problem in 2.3.2, however I'm pretty sure it's<br> fixed in 2-3-stable (a branch in git). If you're able to confirm<br> that, then I'll know we're good to go and we can release 2.3.3 in a<br> few days which will include this fix.</p></div> true 2009-06-01T22:31:36+01:00 12845 --- {} 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 resolved 2.3.2 patch 2009-06-01T22:31:38+01:00 141 Michael Koziarski Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 424 2 Michael, I'm sorry there was a misunderstanding. I thought the bug was fixed in 2.3.2. I tried 2-3-stable and it works fine. Thanks for working this out with me :) I'm looking forward to 2.3.3! <div><p>Michael,</p> <p>I'm sorry there was a misunderstanding. I thought the bug was fixed in 2.3.2. I tried 2-3-stable and it works fine.</p> <p>Thanks for working this out with me :)</p> <p>I'm looking forward to 2.3.3!</p></div> true 2009-06-01T22:44:49+01:00 12845 --- {} 9903 1977 actioncontrollercachingsweeper-autoloading-is-broken 0 8994 resolved 2.3.2 patch 2009-06-01T22:44:55+01:00 11310 Andreas Korth Wincent Colaiuta Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1977 2.x 4db9372d3873cb4d9699747302df05fa865a2909 text/plain 2009-02-15T18:53:37+00:00 0001-Fix-autoloading-of-ActionController-Caching-Sweepe.patch 88998 1412 12845 http://rails.lighthouseapp.com/attachments/88998/0001-Fix-autoloading-of-ActionController-Caching-Sweepe.patch 797ccc5b5b898789e4d6cf33265b7cef7c20b5e9 text/plain 2009-04-22T10:34:42+01:00 0001-Extract-ActionController-Caching-Sweeper-into-sepa.patch 113880 5175 12845 http://rails.lighthouseapp.com/attachments/113880/0001-Extract-ActionController-Caching-Sweeper-into-sepa.patch