let cancels from before filters issue a ROLLBACK
Reported by Xavier Noria | August 24th, 2008 @ 02:26 AM | in 2.x
The AR methods save, save!, and destroy run within a transaction that wraps their entire callback chain.
Before filters may cancel the action returning false. Currently that triggers a ROLLBACK only in the case of save!. With this patch a ROLLBACK is issued as well for save and destroy, preserving their regular usage idioms.
The patch is backwards compatible in the sense that if someone raised exceptions to trigger ROLLBACKs that still works.
It breaks applications that expect COMMITs when canceling save or destroy calls. But I think those are going to be rare, and I believe this change is worth that price anyway.
Some documentation has been written as well. That goes into callbacks.rb because feels like the natural spot from the point of view of the user. It doesn't matter the implementation is split in different files.
Comments and changes to this ticket
-
Repository August 24th, 2008 @ 01:35 PM
- → State changed from “new” to “committed”
(from [e02f0dcc24f871d8429229db4219ee1e93636496]) Rollback the transaction when a before_* callback returns false.
Previously this would have committed the transaction but not carried out save or destroy operation.
[#891 state:committed] Signed-off-by: Michael Koziarski michael@koziarski.com http://github.com/rails/rails/co...
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
Repository is at http://github.com/rails/rails
Check out the development master (Edge Rails):
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too"..
Tarmo Tänav