This project is archived and is in readonly mode.

Activity (RSS)

Tuesday, April 26 2011

6745 [PATCH] full_messages generates lame messages for associations was updated

Josh Sharpe commented at 4:31 AM

okay, seriously, lighthouse won't accept my patch. no error, nothing:

http://pastebin.com/qVeRBp3R
Josh Sharpe created the ticket at 4:28 AM

Imagine you're a User and you accepts_nested_attributes for Profile. And your fun developer goes and does something like this:

@u = User.new @u.build_profile @u...

6744 ActiveModel Xml Serialization patch was created

jimmiesh created the ticket at 2:22 AM
When passing a :type option to to_xml, the passed type is propagated to all string attributes in the ActiveModel. For instance:
```
class Person
  include ActiveM...
```

~~6297~~ ~~[PATCH] Default scopes can't be merged with something that responds_to call~~ was updated

- State changed from open to stale
by rails at 1:00 AM
- State changed from new to open
by rails at 1:00 AM

This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limit...

6332 [PATCH] ActiveRecord::Relation#first convenience method was updated

- State changed from open to stale
by rails at 1:00 AM
- State changed from new to open
by rails at 1:00 AM

This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limit...

6334 to_xml should render valid xml or raise an error all the time was updated

- State changed from open to stale
by rails at 1:00 AM
- State changed from new to open
by rails at 1:00 AM

This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limit...

6720 Parameter Filter not working was updated

Steve Schwartz commented at 12:59 AM
Oh, and concerning the difficulty in being precise about key/value for each class's own to_s method, yes I agree, but when it comes to filtering sensitive info,...
Steve Schwartz commented at 12:57 AM
@neeraj, I think you misunderstood. I was referring to when ActionDispatch::RemoteIp::RemoteIpGetter is actually getting output (i.e. with print or puts or what...

Monday, April 25 2011

added test for number_to_phone with a... was committed by Diego Carrion at 9:58 PM

~~6730~~ ~~number_to_phone broken with empty number and area_code: true~~ was updated

- State changed from new to committed
- Importance changed from to Low
by Santiago Pastorino at 9:58 PM
Pushed!

~~3527~~ ~~undefined method `destroyed?' for ActiveRecord::Associations::BelongsToAssoci...~~ was updated

Tim Morton commented at 9:56 PM

I can confirm a few things about this issue:

1) It's still present in 2.3.11.
2) As a few other people have explained above, the problem occurs when you have a ...

~~6073~~ ~~Postgresql tsvector datatype not recognized in schema.rb~~ was updated

- Assigned user cleared.
by Scott Lowe at 9:50 PM
- Assigned user set to Aaron Patterson
by Scott Lowe at 9:37 PM

I've written some simple tests to support the PostgreSQL tsvector data type patch for #6073.

Writing these tests has raised some questions. Whilst we can now sc...

6738 [PATCH] Useless argument on #columns was updated

- Assigned user set to Santiago Pastorino
by Sebastian Martinez at 8:38 PM

~~2289~~ ~~_method=put ignored for xhr and xml requests~~ was updated

Michael Latta commented at 8:02 PM
By changing the call from $.post to $.ajax with type 'PUT' this seems to resolve the issue.
Michael Latta commented at 7:33 PM
This is still an issue with 3.0.6 and query parameters with method=put for ajax requests. I just ran into this today with porting 2.x code to the 3.x version of...

~~6743~~ ~~CSRF not working Rails 3.0.7~~ was updated

Matthew Daubert commented at 6:15 PM
mrbrdo - keep in mind that CSRF protection is meant to prevent session hijacking and has nothing to do with authorizing actions within your application. The Sec...
Santiago Pastorino commented at 5:50 PM
Because of API calls.
More info here http://groups.google.com/group/rubyonrails-core/browse_thread/threa...
mrbrdo commented at 5:38 PM

I see. Can you explain why the exception is not raised anymore? Is there a security issue if you raise an exception as suggested by Matthew Daubert?

Thank you.
- State changed from new to invalid
- Importance changed from to Low
by Santiago Pastorino at 5:00 PM
Please read http://weblog.rubyonrails.org/2011/2/8/csrf-protection-bypass-in-ru...
Basically you won't get an exception anymore, a session reset will happen no...
Matthew Daubert commented at 4:49 PM

Looks like this is the expected behavior as of Rails 3.0.4:
http://jasoncodes.com/posts/rails-csrf-vulnerability

For the old functionality you can add this to y...

2 earlier changes…

Matthew Daubert commented at 4:39 PM
The request_forgery_protection tests pass for me for both 3.0.7 and master branches but I also see the same behavior with your test app. I wonder if the change ...
mrbrdo created the ticket at 3:16 PM
Example project: https://github.com/mrbrdo/csrf-test (its just rails new csrf_test, rails g scaffold post title:string)
CSRF is enabled in application controlle...

~~873~~ ~~validates_inclusion/exclusion_of should also accept a symbol or proc as the :...~~ was updated

- Tag cleared.
by pmontrasio at 5:24 PM
It seems that shuber's patch didn't make it into Rails 3. Too bad because I was looking for a way to validate against some dynamic value. I'll fall back to writ...

6648 PostgreSQL add column behaves differently to other adaptors (SQlite, MySQL) w... was updated

John Barker commented at 5:11 PM
Just realised this was also fixed in master, so simply back-ported the fix and made the diff as per the guide, applied it with 'git am ...' and it works, passes...

6741 Rails 3: find_or_create_by gives ArgumentError (Unknown keys) with hash param... was updated

Matthew Daubert commented at 5:00 PM

Ary,

I suspect the low priority designation is because you an accomplish the same task by changing the last line. I plugged this into your test case and it seem...
Ary Borenszweig commented at 3:53 PM
Why low priority? The beauty of Rails 3 is to work with associations like this, and I can see many use cases where you would want to find or create by an attrib...
- State changed from open to new
by Ben Orenstein at 3:43 PM
- State changed from new to open
by Ben Orenstein at 3:43 PM
- Importance changed from to Low
by Ben Orenstein at 3:42 PM

1 earlier change…

Ary Borenszweig created the ticket at 6:08 AM
This is the code that fails, you can put it in a main.rb file and run it:
```
require 'rubygems'
require 'active_record'

ActiveRecord::Base.establish_connection(:...
```

Fix tests, main_app mounted helper mu... was committed by Piotr Sarnacki at 4:59 PM

6742 [Patch] Allow optional passwords in ActiveModel::SecurePassword was updated

Matthew Daubert commented at 2:22 PM
Rebased patch to master 2bc4856..d4bea35
Matthew Daubert created the ticket at 2:17 PM
The ActiveModel::SecurePassword module is outstanding but I think allowing a password to be optional would allow many more use cases for this feature. E.g. an a...

Make ActionController::Base.modules_f... was committed by Piotr Sarnacki at 2:04 PM

Explicitly define main_app proxy http... was committed by Piotr Sarnacki at 2:04 PM

Add Engine#helpers method which loads... was committed by Piotr Sarnacki at 12:45 PM

Go with latest Sass directly https://... was committed by David Heinemeier Hansson at 12:35 PM

Fix tests. https://github.com/rails/r... was committed by José Valim at 10:16 AM

4520 #as_json should only ever return a Hash, Array, Numeric, String, nil, true or... was updated

rke commented at 8:54 AM
Instead of Numeric shouldn't this be Float? http://www.ietf.org/rfc/rfc4627.txt does not allow Rationals or Complex numbers and although it does not impose a li...

rename test case to better describe u... was committed by David Chelimsky at 8:40 AM

6739 Move TranslationHelper to I18n gem and bump I18n to 0.6.0 was updated

José Valim commented at 8:39 AM
Hey Sven, I have pushed this commit but I could not install the I18n gem. Can you push the beta version? Tks!

~~4624~~ ~~router does not accept member for resource~~ was updated

brand shoes commented at 7:40 AM
It emanated from Carter. A high school dropout who lived with a mother on drugs, and who at one point saw all seven of his uncles in prison, at 35 Carter is the...

Ben Orenstein was invited to Ruby on Rails at 4:15 AM

Temporarily disable uglifier until a ... was committed by David Heinemeier Hansson at 2:35 AM

Merge branch 'master' of github.com:r... was committed by David Heinemeier Hansson at 2:35 AM

6740 [PATCH] proper reset all inflector scopes was created

MSNexploder created the ticket at 2:23 AM

Resetting all inflector scopes does not clear the :humans scope.

Patch including failing tests attached.

←
Page 9 of 1194
→