#6730 number_to_phone broken with empty number and area_code: true - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#6730 ✓committed

number_to_phone broken with empty number and area_code: true

Reported by dvdplm | April 20th, 2011 @ 03:12 PM

This raises a "TypeError Exception: can't convert nil into String" exception:

    number_to_phone "", area_code: true

These both work (returns ""):

    number_to_phone "", area_code: false
    number_to_phone ""

The reason for the exception is that the #gsub! on line 73 of actionpack/lib/action_view/helpers/number_helper.rb returns nil when there is no match and String#<< is called with a nil argument.

The fix is easy. Replace line 50:

    return nil if number.nil?

...with:

    return nil if number.blank?

Comments and changes to this ticket

You flagged this item as spam.
Vijay Dev April 20th, 2011 @ 06:23 PM
Can reproduce the error.
You flagged this item as spam.
Diego Carrion April 20th, 2011 @ 06:31 PM
- Assigned user set to “Santiago Pastorino”
This problem seems fixed in edge. I added a test case case this scenario is important.
- 0001-added-test-for-number_to_p.patch 1.2 KB
Santiago Pastorino April 25th, 2011 @ 09:58 PM
- State changed from “new” to “committed”
- Importance changed from “” to “Low”
Pushed!