Rails slice() helper incompatibility in Rails 2.1.1

I'm not able to find the issue. Everything works fine with this testcase:

def test_slice_access_with_symbols

original = { :username => 'motu', :password => 'motupass', :email => 'myemail@email.domain'}

original.slice!(:username, :password)

username = original[:username]
assert_equal username, "motu"

end

I guess the problem is that params is HashWithIndifferentAccess but slice gives back just plain Hash. Perhaps slice should give return of the same type as it's receiver?

Using the method @@@ ruby with_indifferent_access@@@ on the Hash converts the hash into an object of type @@@ruby HashWithIndifferentAccess@@@. So the following test case should fail, of there is an issue, I guess. I'm still not able to reproduce the problem. Maybe I on the wrong way.

  def test_indifferent_slice_access_with_symbols
    original = { :username => 'motu', :password => 'motupass', :email => 'myemail@email.domain'}.with_indifferent_access

    original.slice!(:username, :password).with_indifferent_access

    username = original[:username]
    assert_equal username, "motu"

  end

Failing test case is attached.

Now I understand the problem. Thank you for cleaning my eyes. ;-)

Let's see...

...and here is the fix.

Looks good,

Backported and applied

(from [2e75bd0808f4dcac328b690aaad176cbfe96773e]) slice now returns indifferent hash if called on one

Signed-off-by: Michael Koziarski michael@koziarski.com

[#1096 Rails slice() helper incompatibility in Rails 2.1.1 state:committed] http://github.com/rails/rails/co...