This project is archived and is in readonly mode.
Added :counter_sql to valid keys for HABTM
In #831, I submitted a patch to refactor AssociationCollection#count and fix problems with HABTM count in Ruby 1.8.7. I forgot to add :counter_sql to the list of valid keys for HABTM associations in associations.rb, as Tekin pointed out. This was causing the option to be rejected despite the documentation update stating it should work. This one-liner patch fixes that. Sorry!
(If someone wants to add a new fixture that is a HABTM association with a :counter_sql option and put in a test making sure it counts, it probably would be worthwhile. I just don't have the time to do that today, and wanted to get this in before the bug makes it into 2.2 beta.)
-
habtm_count.diff
1.06 KB
-
Michael KoziarskiThis doesn't apply cleanly any more, can you rebase it and reupload it please
-
-
Michael Koziarski
Also, we clearly don't have any tests for this feature, can you add a few (even just a simple declaration of the association and assertion on the count).
-
Tekin
OK, will try get some simply tests added to the patch.
-
Ernie MillerTekin,
Thanks for jumping on this so fast! You saved me the pain. :)
-
Tekin
No worries!
Here's an updated patch with a couple of tests. Hope that does the trick.
-
Repository- State changed from new to committed
(from [32a5cfcd7f8d14407f0c00ce2cdc82b1b568438e]) Added tests for HABTM associations with counter_sql
Signed-off-by: Michael Koziarski michael@koziarski.com [#1102 state:committed] http://github.com/rails/rails/co...